[PATCH] net: ethernet: ti: am65-cpsw: select PAGE_POOL

Sascha Hauer posted 1 patch 9 months, 4 weeks ago
There is a newer version of this series
drivers/net/ethernet/ti/Kconfig | 1 +
1 file changed, 1 insertion(+)
[PATCH] net: ethernet: ti: am65-cpsw: select PAGE_POOL
Posted by Sascha Hauer 9 months, 4 weeks ago
am65-cpsw uses page_pool_dev_alloc_pages(), thus needs PAGE_POOL
selected to avoid linker errors.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
 drivers/net/ethernet/ti/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/ti/Kconfig b/drivers/net/ethernet/ti/Kconfig
index 0d5a862cd78a6..3a13d60a947a8 100644
--- a/drivers/net/ethernet/ti/Kconfig
+++ b/drivers/net/ethernet/ti/Kconfig
@@ -99,6 +99,7 @@ config TI_K3_AM65_CPSW_NUSS
 	select NET_DEVLINK
 	select TI_DAVINCI_MDIO
 	select PHYLINK
+	select PAGE_POOL
 	select TI_K3_CPPI_DESC_POOL
 	imply PHY_TI_GMII_SEL
 	depends on TI_K3_AM65_CPTS || !TI_K3_AM65_CPTS

---
base-commit: 0ad2507d5d93f39619fc42372c347d6006b64319
change-id: 20250220-net-am654-nuss-kconfig-ab8e4f4e318b

Best regards,
-- 
Sascha Hauer <s.hauer@pengutronix.de>
Re: [PATCH] net: ethernet: ti: am65-cpsw: select PAGE_POOL
Posted by Jakub Kicinski 9 months, 4 weeks ago
On Thu, 20 Feb 2025 09:43:06 +0100 Sascha Hauer wrote:
> am65-cpsw uses page_pool_dev_alloc_pages(), thus needs PAGE_POOL
> selected to avoid linker errors.

If it can actually result in linker errors today could you add a Fixes
tag pointing to the commit that added the dependency?

If it can't (perhaps one of the many already selected symbols already
implies PAGE_POOL?) could you explain in the commit msg?
-- 
pw-bot: cr
Re: [PATCH] net: ethernet: ti: am65-cpsw: select PAGE_POOL
Posted by Sascha Hauer 9 months, 3 weeks ago
On Fri, Feb 21, 2025 at 04:16:13PM -0800, Jakub Kicinski wrote:
> On Thu, 20 Feb 2025 09:43:06 +0100 Sascha Hauer wrote:
> > am65-cpsw uses page_pool_dev_alloc_pages(), thus needs PAGE_POOL
> > selected to avoid linker errors.
> 
> If it can actually result in linker errors today could you add a Fixes
> tag pointing to the commit that added the dependency?

Sure. I just sent a v2.

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |