[v2] arm64: dts: qcom: sm8750: CDSP and modem

[PATCH v2 3/4] arm64: dts: qcom: sm8750-mtp: Enable CDSP and mention MPSS

Posted by Krzysztof Kozlowski 9 months, 4 weeks ago

Enable the CDSP on MPT8750 board and add firmware for the modem, however
keep it as failed because modem crashes after booting for unknown
reasons.

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 arch/arm64/boot/dts/qcom/sm8750-mtp.dts | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sm8750-mtp.dts b/arch/arm64/boot/dts/qcom/sm8750-mtp.dts
index 8eeed7f2f7766326cfc7830002768087e9783b9b..72f081a890dfe49bfbee5e91b9e51da53b9d8baf 100644
--- a/arch/arm64/boot/dts/qcom/sm8750-mtp.dts
+++ b/arch/arm64/boot/dts/qcom/sm8750-mtp.dts
@@ -791,6 +791,21 @@ &remoteproc_adsp {
 	status = "okay";
 };
 
+&remoteproc_cdsp {
+	firmware-name = "qcom/sm8750/cdsp.mbn",
+			"qcom/sm8750/cdsp_dtb.mbn";
+
+	status = "okay";
+};
+
+&remoteproc_mpss {
+	firmware-name = "qcom/sm8750/modem.mbn",
+			"qcom/sm8750/modem_dtb.mbn";
+
+	/* Modem crashes after some time with "DOG detects stalled initialization" */
+	status = "fail";
+};
+
 &tlmm {
 	/* reserved for secure world */
 	gpio-reserved-ranges = <36 4>, <74 1>;

-- 
2.43.0

Re: [PATCH v2 3/4] arm64: dts: qcom: sm8750-mtp: Enable CDSP and mention MPSS

Posted by Dmitry Baryshkov 9 months, 4 weeks ago

On Thu, Feb 20, 2025 at 04:44:13PM +0100, Krzysztof Kozlowski wrote:
> Enable the CDSP on MPT8750 board and add firmware for the modem, however
> keep it as failed because modem crashes after booting for unknown
> reasons.

So the modem crashes on MTP, but does not on QRD?

> 
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  arch/arm64/boot/dts/qcom/sm8750-mtp.dts | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sm8750-mtp.dts b/arch/arm64/boot/dts/qcom/sm8750-mtp.dts
> index 8eeed7f2f7766326cfc7830002768087e9783b9b..72f081a890dfe49bfbee5e91b9e51da53b9d8baf 100644
> --- a/arch/arm64/boot/dts/qcom/sm8750-mtp.dts
> +++ b/arch/arm64/boot/dts/qcom/sm8750-mtp.dts
> @@ -791,6 +791,21 @@ &remoteproc_adsp {
>  	status = "okay";
>  };
>  
> +&remoteproc_cdsp {
> +	firmware-name = "qcom/sm8750/cdsp.mbn",
> +			"qcom/sm8750/cdsp_dtb.mbn";
> +
> +	status = "okay";
> +};
> +
> +&remoteproc_mpss {
> +	firmware-name = "qcom/sm8750/modem.mbn",
> +			"qcom/sm8750/modem_dtb.mbn";
> +
> +	/* Modem crashes after some time with "DOG detects stalled initialization" */
> +	status = "fail";
> +};
> +
>  &tlmm {
>  	/* reserved for secure world */
>  	gpio-reserved-ranges = <36 4>, <74 1>;
> 
> -- 
> 2.43.0
> 

-- 
With best wishes
Dmitry

Re: [PATCH v2 3/4] arm64: dts: qcom: sm8750-mtp: Enable CDSP and mention MPSS

Posted by Krzysztof Kozlowski 9 months, 4 weeks ago

On 20/02/2025 17:19, Dmitry Baryshkov wrote:
> On Thu, Feb 20, 2025 at 04:44:13PM +0100, Krzysztof Kozlowski wrote:
>> Enable the CDSP on MPT8750 board and add firmware for the modem, however
>> keep it as failed because modem crashes after booting for unknown
>> reasons.
> 
> So the modem crashes on MTP, but does not on QRD?
QRD was not tested - which mentioned in that patch - and I hope someone
will test it and tell me :)

Best regards,
Krzysztof

Re: [PATCH v2 3/4] arm64: dts: qcom: sm8750-mtp: Enable CDSP and mention MPSS

Posted by Dmitry Baryshkov 9 months, 3 weeks ago

On Fri, Feb 21, 2025 at 09:38:09AM +0100, Krzysztof Kozlowski wrote:
> On 20/02/2025 17:19, Dmitry Baryshkov wrote:
> > On Thu, Feb 20, 2025 at 04:44:13PM +0100, Krzysztof Kozlowski wrote:
> >> Enable the CDSP on MPT8750 board and add firmware for the modem, however
> >> keep it as failed because modem crashes after booting for unknown
> >> reasons.
> > 
> > So the modem crashes on MTP, but does not on QRD?
> QRD was not tested - which mentioned in that patch - and I hope someone
> will test it and tell me :)

Then it might also be broken. I have the same situation on SAR2130P,
ADSP works, but CDSP crashes. Please separate modem to a separate series
and clearly mark that it is not supposed to work. Until it works on any
of the boards I don't think we should be merging corresponding driver
bits, which are known-broken.

-- 
With best wishes
Dmitry

Re: [PATCH v2 3/4] arm64: dts: qcom: sm8750-mtp: Enable CDSP and mention MPSS

Posted by Krzysztof Kozlowski 9 months, 3 weeks ago

On 21/02/2025 15:15, Dmitry Baryshkov wrote:
> On Fri, Feb 21, 2025 at 09:38:09AM +0100, Krzysztof Kozlowski wrote:
>> On 20/02/2025 17:19, Dmitry Baryshkov wrote:
>>> On Thu, Feb 20, 2025 at 04:44:13PM +0100, Krzysztof Kozlowski wrote:
>>>> Enable the CDSP on MPT8750 board and add firmware for the modem, however
>>>> keep it as failed because modem crashes after booting for unknown
>>>> reasons.
>>>
>>> So the modem crashes on MTP, but does not on QRD?
>> QRD was not tested - which mentioned in that patch - and I hope someone
>> will test it and tell me :)
> 
> Then it might also be broken. I have the same situation on SAR2130P,
> ADSP works, but CDSP crashes. Please separate modem to a separate series
> and clearly mark that it is not supposed to work. Until it works on any
> of the boards I don't think we should be merging corresponding driver
> bits, which are known-broken.
> 
OK

Best regards,
Krzysztof