io_uring/rsrc: remove unused constants

[PATCH] io_uring/rsrc: remove unused constants

Posted by Caleb Sander Mateos 10 months ago

IO_NODE_ALLOC_CACHE_MAX has been unused since commit fbbb8e991d86
("io_uring/rsrc: get rid of io_rsrc_node allocation cache") removed the
rsrc_node_cache.

IO_RSRC_TAG_TABLE_SHIFT and IO_RSRC_TAG_TABLE_MASK have been unused
since commit 7029acd8a950 ("io_uring/rsrc: get rid of per-ring
io_rsrc_node list") removed the separate tag table for registered nodes.

Signed-off-by: Caleb Sander Mateos <csander@purestorage.com>
---
 io_uring/rsrc.h | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/io_uring/rsrc.h b/io_uring/rsrc.h
index a6d883c62b22..0297daf02ac7 100644
--- a/io_uring/rsrc.h
+++ b/io_uring/rsrc.h
@@ -2,16 +2,10 @@
 #ifndef IOU_RSRC_H
 #define IOU_RSRC_H
 
 #include <linux/lockdep.h>
 
-#define IO_NODE_ALLOC_CACHE_MAX 32
-
-#define IO_RSRC_TAG_TABLE_SHIFT	(PAGE_SHIFT - 3)
-#define IO_RSRC_TAG_TABLE_MAX	(1U << IO_RSRC_TAG_TABLE_SHIFT)
-#define IO_RSRC_TAG_TABLE_MASK	(IO_RSRC_TAG_TABLE_MAX - 1)
-
 enum {
 	IORING_RSRC_FILE		= 0,
 	IORING_RSRC_BUFFER		= 1,
 };
 
-- 
2.45.2

Re: [PATCH] io_uring/rsrc: remove unused constants

Posted by Jens Axboe 10 months ago

On Tue, 18 Feb 2025 20:34:43 -0700, Caleb Sander Mateos wrote:
> IO_NODE_ALLOC_CACHE_MAX has been unused since commit fbbb8e991d86
> ("io_uring/rsrc: get rid of io_rsrc_node allocation cache") removed the
> rsrc_node_cache.
> 
> IO_RSRC_TAG_TABLE_SHIFT and IO_RSRC_TAG_TABLE_MASK have been unused
> since commit 7029acd8a950 ("io_uring/rsrc: get rid of per-ring
> io_rsrc_node list") removed the separate tag table for registered nodes.
> 
> [...]

Applied, thanks!

[1/1] io_uring/rsrc: remove unused constants
      commit: fb3331f53e3cb1f1505f918f4f33bb0a3a231e4f

Best regards,
-- 
Jens Axboe

RE: [PATCH] io_uring/rsrc: remove unused constants

Posted by lizetao 10 months ago

Hi,

> -----Original Message-----
> From: Caleb Sander Mateos <csander@purestorage.com>
> Sent: Wednesday, February 19, 2025 11:35 AM
> To: Jens Axboe <axboe@kernel.dk>; Pavel Begunkov <asml.silence@gmail.com>
> Cc: Caleb Sander Mateos <csander@purestorage.com>; io-
> uring@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: [PATCH] io_uring/rsrc: remove unused constants
> 
> IO_NODE_ALLOC_CACHE_MAX has been unused since commit fbbb8e991d86
> ("io_uring/rsrc: get rid of io_rsrc_node allocation cache") removed the
> rsrc_node_cache.
> 
> IO_RSRC_TAG_TABLE_SHIFT and IO_RSRC_TAG_TABLE_MASK have been
> unused since commit 7029acd8a950 ("io_uring/rsrc: get rid of per-ring
> io_rsrc_node list") removed the separate tag table for registered nodes.
> 
> Signed-off-by: Caleb Sander Mateos <csander@purestorage.com>
> ---
>  io_uring/rsrc.h | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/io_uring/rsrc.h b/io_uring/rsrc.h index
> a6d883c62b22..0297daf02ac7 100644
> --- a/io_uring/rsrc.h
> +++ b/io_uring/rsrc.h
> @@ -2,16 +2,10 @@
>  #ifndef IOU_RSRC_H
>  #define IOU_RSRC_H
> 
>  #include <linux/lockdep.h>
> 
> -#define IO_NODE_ALLOC_CACHE_MAX 32
> -
> -#define IO_RSRC_TAG_TABLE_SHIFT	(PAGE_SHIFT - 3)
> -#define IO_RSRC_TAG_TABLE_MAX	(1U << IO_RSRC_TAG_TABLE_SHIFT)
> -#define IO_RSRC_TAG_TABLE_MASK	(IO_RSRC_TAG_TABLE_MAX - 1)
> -
>  enum {
>  	IORING_RSRC_FILE		= 0,
>  	IORING_RSRC_BUFFER		= 1,
>  };
> 
> --
> 2.45.2
> 

Reviewed-by: Li Zetao <lizetao1@huawei.com>

---
Li Zetao