[PATCH net-next 0/3] Converge on using secs_to_jiffies() part two

Easwar Hariharan posted 3 patches 10 months ago
There is a newer version of this series
net/ipv4/ipconfig.c          |  6 +++---
net/netfilter/xt_IDLETIMER.c | 12 ++++++------
net/smc/af_smc.c             |  3 +--
3 files changed, 10 insertions(+), 11 deletions(-)
[PATCH net-next 0/3] Converge on using secs_to_jiffies() part two
Posted by Easwar Hariharan 10 months ago
This is the second series (part 1*) that converts users of msecs_to_jiffies() that
either use the multiply pattern of either of:
- msecs_to_jiffies(N*1000) or
- msecs_to_jiffies(N*MSEC_PER_SEC)

where N is a constant or an expression, to avoid the multiplication.

The conversion is made with Coccinelle with the secs_to_jiffies() script
in scripts/coccinelle/misc. Attention is paid to what the best change
can be rather than restricting to what the tool provides.

The non-netdev patches that include the update to secs_to_jiffies.cocci to address
expressions are here: https://lore.kernel.org/all/20250203-converge-secs-to-jiffies-part-two-v2-0-d7058a01fd0e@linux.microsoft.com

This series is based on net-next.

Signed-off-by: Easwar Hariharan <eahariha@linux.microsoft.com>

* https://lore.kernel.org/all/20241212-netdev-converge-secs-to-jiffies-v4-0-6dac97a6d6ab@linux.microsoft.com/

---
Easwar Hariharan (3):
      net/smc: convert timeouts to secs_to_jiffies()
      netfilter: xt_IDLETIMER: convert timeouts to secs_to_jiffies()
      net: ipconfig: convert timeouts to secs_to_jiffies()

 net/ipv4/ipconfig.c          |  6 +++---
 net/netfilter/xt_IDLETIMER.c | 12 ++++++------
 net/smc/af_smc.c             |  3 +--
 3 files changed, 10 insertions(+), 11 deletions(-)
---
base-commit: de7a88b639d488607352a270ef2e052c4442b1b3
change-id: 20250128-netdev-secs-to-jiffies-part-2-8f0d2535096a

Best regards,
-- 
Easwar Hariharan <eahariha@linux.microsoft.com>
Re: [PATCH net-next 0/3] Converge on using secs_to_jiffies() part two
Posted by Jakub Kicinski 9 months, 4 weeks ago
On Wed, 19 Feb 2025 20:30:35 +0000 Easwar Hariharan wrote:
> The conversion is made with Coccinelle with the secs_to_jiffies() script
> in scripts/coccinelle/misc. Attention is paid to what the best change
> can be rather than restricting to what the tool provides.
> 
> The non-netdev patches that include the update to secs_to_jiffies.cocci to address
> expressions are here: https://lore.kernel.org/all/20250203-converge-secs-to-jiffies-part-two-v2-0-d7058a01fd0e@linux.microsoft.com

Can the secs_to_jiffies cocci check script finally run in report mode?

I think that needs to be fixed first, before we start "cleaning up"
existing code under net.
-- 
pw-bot: defer
Re: [PATCH net-next 0/3] Converge on using secs_to_jiffies() part two
Posted by Easwar Hariharan 9 months, 2 weeks ago
On 2/21/2025 4:21 PM, Jakub Kicinski wrote:
> On Wed, 19 Feb 2025 20:30:35 +0000 Easwar Hariharan wrote:
>> The conversion is made with Coccinelle with the secs_to_jiffies() script
>> in scripts/coccinelle/misc. Attention is paid to what the best change
>> can be rather than restricting to what the tool provides.
>>
>> The non-netdev patches that include the update to secs_to_jiffies.cocci to address
>> expressions are here: https://lore.kernel.org/all/20250203-converge-secs-to-jiffies-part-two-v2-0-d7058a01fd0e@linux.microsoft.com
> 
> Can the secs_to_jiffies cocci check script finally run in report mode?
> 
> I think that needs to be fixed first, before we start "cleaning up"
> existing code under net.

It does not, yet. I'm not ignoring this feedback, it's just taking a bit
of wall clock time between commercial commitments. :) 

Thanks,
Easwar (he/him)