[PATCH v3 3/5] dt-bindings: soc: samsung: exynos-pmu: add exynos7870-pmu compatible

Kaustabh Chakraborty posted 5 patches 10 months ago
[PATCH v3 3/5] dt-bindings: soc: samsung: exynos-pmu: add exynos7870-pmu compatible
Posted by Kaustabh Chakraborty 10 months ago
Document the compatible string for the Exynos7870 PMU. It's compatible
with the Exynos7 PMU design. It handles syscon reboot, syscon reboot mode,
as well as other system control registers (i.e registers for the USB PHY).

Signed-off-by: Kaustabh Chakraborty <kauschluss@disroot.org>
---
 Documentation/devicetree/bindings/soc/samsung/exynos-pmu.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/soc/samsung/exynos-pmu.yaml b/Documentation/devicetree/bindings/soc/samsung/exynos-pmu.yaml
index 8e6d051d8c97de0c843a91350a5cb9c332b2d6ce..3baee81df54981cb4c6502c1ddf5be3d5e3184c3 100644
--- a/Documentation/devicetree/bindings/soc/samsung/exynos-pmu.yaml
+++ b/Documentation/devicetree/bindings/soc/samsung/exynos-pmu.yaml
@@ -52,6 +52,7 @@ properties:
           - const: syscon
       - items:
           - enum:
+              - samsung,exynos7870-pmu
               - samsung,exynos7885-pmu
               - samsung,exynos8895-pmu
               - samsung,exynos9810-pmu

-- 
2.48.1
Re: [PATCH v3 3/5] dt-bindings: soc: samsung: exynos-pmu: add exynos7870-pmu compatible
Posted by Krzysztof Kozlowski 10 months ago
On Wed, Feb 19, 2025 at 12:20:30AM +0530, Kaustabh Chakraborty wrote:
> Document the compatible string for the Exynos7870 PMU. It's compatible
> with the Exynos7 PMU design. It handles syscon reboot, syscon reboot mode,
> as well as other system control registers (i.e registers for the USB PHY).
> 
> Signed-off-by: Kaustabh Chakraborty <kauschluss@disroot.org>
> ---
>  Documentation/devicetree/bindings/soc/samsung/exynos-pmu.yaml | 1 +
>  1 file changed, 1 insertion(+)

I don't understand why did you send SoC patch to clock. I asked to split
by subsystem.

Best regards,
Krzysztof
Re: [PATCH v3 3/5] dt-bindings: soc: samsung: exynos-pmu: add exynos7870-pmu compatible
Posted by Krzysztof Kozlowski 10 months ago
On 19/02/2025 09:09, Krzysztof Kozlowski wrote:
> On Wed, Feb 19, 2025 at 12:20:30AM +0530, Kaustabh Chakraborty wrote:
>> Document the compatible string for the Exynos7870 PMU. It's compatible
>> with the Exynos7 PMU design. It handles syscon reboot, syscon reboot mode,
>> as well as other system control registers (i.e registers for the USB PHY).
>>
>> Signed-off-by: Kaustabh Chakraborty <kauschluss@disroot.org>
>> ---
>>  Documentation/devicetree/bindings/soc/samsung/exynos-pmu.yaml | 1 +
>>  1 file changed, 1 insertion(+)
> 
> I don't understand why did you send SoC patch to clock. I asked to split
> by subsystem.

I guess because of clkout driver. I don't want to grow the clkout OF
device ID table with compatible entries, but I also have doubts that it
is compatible and that you actually tested it.

Best regards,
Krzysztof