[PATCH 15/16] drm/vkms: Allow to configure the default device creation

José Expósito posted 16 patches 10 months ago
There is a newer version of this series
[PATCH 15/16] drm/vkms: Allow to configure the default device creation
Posted by José Expósito 10 months ago
Add a new module param to allow to create or not the default VKMS
instance. Useful when combined with configfs to avoid having additional
VKMS instances.

Signed-off-by: José Expósito <jose.exposito89@gmail.com>
---
 drivers/gpu/drm/vkms/vkms_drv.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/gpu/drm/vkms/vkms_drv.c b/drivers/gpu/drm/vkms/vkms_drv.c
index 5bcfbcb6c0c5..b4ed19c97576 100644
--- a/drivers/gpu/drm/vkms/vkms_drv.c
+++ b/drivers/gpu/drm/vkms/vkms_drv.c
@@ -50,6 +50,10 @@ static bool enable_overlay;
 module_param_named(enable_overlay, enable_overlay, bool, 0444);
 MODULE_PARM_DESC(enable_overlay, "Enable/Disable overlay support");
 
+static bool create_default_dev = true;
+module_param_named(create_default_dev, create_default_dev, bool, 0444);
+MODULE_PARM_DESC(create_default_dev, "Create or not the default VKMS device");
+
 DEFINE_DRM_GEM_FOPS(vkms_driver_fops);
 
 static void vkms_atomic_commit_tail(struct drm_atomic_state *old_state)
@@ -219,6 +223,9 @@ static int __init vkms_init(void)
 	if (ret)
 		return ret;
 
+	if (!create_default_dev)
+		return 0;
+
 	config = vkms_config_default_create(enable_cursor, enable_writeback, enable_overlay);
 	if (IS_ERR(config))
 		return PTR_ERR(config);
-- 
2.48.1

Re: [PATCH 15/16] drm/vkms: Allow to configure the default device creation
Posted by Louis Chauvet 9 months, 3 weeks ago
On 18/02/25 - 18:08, José Expósito wrote:
> Add a new module param to allow to create or not the default VKMS
> instance. Useful when combined with configfs to avoid having additional
> VKMS instances.
> 
> Signed-off-by: José Expósito <jose.exposito89@gmail.com>

Reviewed-by: Louis Chauvet <louis.chauvet@bootlin.com>

> ---
>  drivers/gpu/drm/vkms/vkms_drv.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/gpu/drm/vkms/vkms_drv.c b/drivers/gpu/drm/vkms/vkms_drv.c
> index 5bcfbcb6c0c5..b4ed19c97576 100644
> --- a/drivers/gpu/drm/vkms/vkms_drv.c
> +++ b/drivers/gpu/drm/vkms/vkms_drv.c
> @@ -50,6 +50,10 @@ static bool enable_overlay;
>  module_param_named(enable_overlay, enable_overlay, bool, 0444);
>  MODULE_PARM_DESC(enable_overlay, "Enable/Disable overlay support");
>  
> +static bool create_default_dev = true;
> +module_param_named(create_default_dev, create_default_dev, bool, 0444);
> +MODULE_PARM_DESC(create_default_dev, "Create or not the default VKMS device");
> +
>  DEFINE_DRM_GEM_FOPS(vkms_driver_fops);
>  
>  static void vkms_atomic_commit_tail(struct drm_atomic_state *old_state)
> @@ -219,6 +223,9 @@ static int __init vkms_init(void)
>  	if (ret)
>  		return ret;
>  
> +	if (!create_default_dev)
> +		return 0;
> +
>  	config = vkms_config_default_create(enable_cursor, enable_writeback, enable_overlay);
>  	if (IS_ERR(config))
>  		return PTR_ERR(config);
> -- 
> 2.48.1
>