On 2/18/2025 3:37 AM, Mario Limonciello wrote:
> From: Mario Limonciello <mario.limonciello@amd.com>
>
> The cpudata variable is only needed in the scope of the for loop. Move it
> there.
>
> Reviewed-by: Gautham R. Shenoy <gautham.shenoy@amd.com>
> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
> ---
> drivers/cpufreq/amd-pstate-ut.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cpufreq/amd-pstate-ut.c b/drivers/cpufreq/amd-pstate-ut.c
> index 3a541780f374f..6b04b5b54b3b5 100644
> --- a/drivers/cpufreq/amd-pstate-ut.c
> +++ b/drivers/cpufreq/amd-pstate-ut.c
> @@ -186,10 +186,10 @@ static int amd_pstate_ut_check_perf(u32 index)
> static int amd_pstate_ut_check_freq(u32 index)
> {
> int cpu = 0;
> - struct amd_cpudata *cpudata = NULL;
>
> for_each_online_cpu(cpu) {
> struct cpufreq_policy *policy __free(put_cpufreq_policy) = NULL;
> + struct amd_cpudata *cpudata;
I think we can do the same in "amd_pstate_ut_check_perf" as well,
With that taken care of,
Reviewed-by: Dhananjay Ugwekar <dhananjay.ugwekar@amd.com>
Thanks,
Dhananjay
>
> policy = cpufreq_cpu_get(cpu);
> if (!policy)