[v8] Add support for ADIS16550

[RESEND PATCH v8 0/6] Add support for ADIS16550

Posted by Robert Budai 9 months, 4 weeks ago

The ADIS16550 is a complete inertial system that includes a triaxis gyroscope
and a triaxis accelerometer. Each inertial sensor in the ADIS16550 combines
industry leading MEMS only technology with signal conditioning that optimizes
dynamic performance. The factory calibration characterizes each sensor for
sensitivity, bias, and alignment. As a result, each sensor has its own dynamic
compensation formulas that provide accurate sensor measurements.

Robert Budai (6):
  iio: imu: adis: Add custom ops struct
  iio: imu: adis: Add reset to custom ops
  iio: imu: adis: Add DIAG_STAT register
  dt-bindings: iio: Add adis16550 bindings
  iio: imu: adis16550: add adis16550 support
  docs: iio: add documentation for adis16550 driver

 .../bindings/iio/imu/adi,adis16550.yaml       |   74 ++
 Documentation/iio/adis16550.rst               |  376 ++++++
 Documentation/iio/index.rst                   |    1 +
 MAINTAINERS                                   |   10 +
 drivers/iio/imu/Kconfig                       |   13 +
 drivers/iio/imu/Makefile                      |    1 +
 drivers/iio/imu/adis.c                        |   35 +-
 drivers/iio/imu/adis16550.c                   | 1149 +++++++++++++++++
 include/linux/iio/imu/adis.h                  |   34 +-
 9 files changed, 1680 insertions(+), 13 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/iio/imu/adi,adis16550.yaml
 create mode 100644 Documentation/iio/adis16550.rst
 create mode 100644 drivers/iio/imu/adis16550.c

-- 
2.34.1

Re: [RESEND PATCH v8 0/6] Add support for ADIS16550

Posted by Jonathan Cameron 9 months, 4 weeks ago

On Mon, 17 Feb 2025 12:57:44 +0200
Robert Budai <robert.budai@analog.com> wrote:

> The ADIS16550 is a complete inertial system that includes a triaxis gyroscope
> and a triaxis accelerometer. Each inertial sensor in the ADIS16550 combines
> industry leading MEMS only technology with signal conditioning that optimizes
> dynamic performance. The factory calibration characterizes each sensor for
> sensitivity, bias, and alignment. As a result, each sensor has its own dynamic
> compensation formulas that provide accurate sensor measurements.
> 
Hi Robert,

The cover letter of any RESEND should always start with why you are doing so.
If this was for the tiny fixup you mentioned it should have been v9 and
not have been sent for a few days at least.  If everything else is fine
I don't mind making that sort of fixup whilst applying anyway!

Jonathan


> Robert Budai (6):
>   iio: imu: adis: Add custom ops struct
>   iio: imu: adis: Add reset to custom ops
>   iio: imu: adis: Add DIAG_STAT register
>   dt-bindings: iio: Add adis16550 bindings
>   iio: imu: adis16550: add adis16550 support
>   docs: iio: add documentation for adis16550 driver
> 
>  .../bindings/iio/imu/adi,adis16550.yaml       |   74 ++
>  Documentation/iio/adis16550.rst               |  376 ++++++
>  Documentation/iio/index.rst                   |    1 +
>  MAINTAINERS                                   |   10 +
>  drivers/iio/imu/Kconfig                       |   13 +
>  drivers/iio/imu/Makefile                      |    1 +
>  drivers/iio/imu/adis.c                        |   35 +-
>  drivers/iio/imu/adis16550.c                   | 1149 +++++++++++++++++
>  include/linux/iio/imu/adis.h                  |   34 +-
>  9 files changed, 1680 insertions(+), 13 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/iio/imu/adi,adis16550.yaml
>  create mode 100644 Documentation/iio/adis16550.rst
>  create mode 100644 drivers/iio/imu/adis16550.c
>

Re: [RESEND PATCH v8 0/6] Add support for ADIS16550

Posted by Jonathan Cameron 9 months, 3 weeks ago

On Mon, 17 Feb 2025 14:33:54 +0000
Jonathan Cameron <jic23@kernel.org> wrote:

> On Mon, 17 Feb 2025 12:57:44 +0200
> Robert Budai <robert.budai@analog.com> wrote:
> 
> > The ADIS16550 is a complete inertial system that includes a triaxis gyroscope
> > and a triaxis accelerometer. Each inertial sensor in the ADIS16550 combines
> > industry leading MEMS only technology with signal conditioning that optimizes
> > dynamic performance. The factory calibration characterizes each sensor for
> > sensitivity, bias, and alignment. As a result, each sensor has its own dynamic
> > compensation formulas that provide accurate sensor measurements.
> >   
> Hi Robert,
> 
> The cover letter of any RESEND should always start with why you are doing so.
> If this was for the tiny fixup you mentioned it should have been v9 and
> not have been sent for a few days at least.  If everything else is fine
> I don't mind making that sort of fixup whilst applying anyway!

With the tweaks to patch 5 and co-developed tags added as mentioned
in reply to that commit applied to the togreg branch of iio.git which
is initially pushed out as testing.

Jonathan

> 
> Jonathan
> 
> 
> > Robert Budai (6):
> >   iio: imu: adis: Add custom ops struct
> >   iio: imu: adis: Add reset to custom ops
> >   iio: imu: adis: Add DIAG_STAT register
> >   dt-bindings: iio: Add adis16550 bindings
> >   iio: imu: adis16550: add adis16550 support
> >   docs: iio: add documentation for adis16550 driver
> > 
> >  .../bindings/iio/imu/adi,adis16550.yaml       |   74 ++
> >  Documentation/iio/adis16550.rst               |  376 ++++++
> >  Documentation/iio/index.rst                   |    1 +
> >  MAINTAINERS                                   |   10 +
> >  drivers/iio/imu/Kconfig                       |   13 +
> >  drivers/iio/imu/Makefile                      |    1 +
> >  drivers/iio/imu/adis.c                        |   35 +-
> >  drivers/iio/imu/adis16550.c                   | 1149 +++++++++++++++++
> >  include/linux/iio/imu/adis.h                  |   34 +-
> >  9 files changed, 1680 insertions(+), 13 deletions(-)
> >  create mode 100644 Documentation/devicetree/bindings/iio/imu/adi,adis16550.yaml
> >  create mode 100644 Documentation/iio/adis16550.rst
> >  create mode 100644 drivers/iio/imu/adis16550.c
> >   
> 
>

Re: [RESEND PATCH v8 0/6] Add support for ADIS16550

Posted by Jonathan Cameron 9 months, 2 weeks ago

On Sat, 22 Feb 2025 12:40:30 +0000
Jonathan Cameron <jic23@kernel.org> wrote:

> On Mon, 17 Feb 2025 14:33:54 +0000
> Jonathan Cameron <jic23@kernel.org> wrote:
> 
> > On Mon, 17 Feb 2025 12:57:44 +0200
> > Robert Budai <robert.budai@analog.com> wrote:
> >   
> > > The ADIS16550 is a complete inertial system that includes a triaxis gyroscope
> > > and a triaxis accelerometer. Each inertial sensor in the ADIS16550 combines
> > > industry leading MEMS only technology with signal conditioning that optimizes
> > > dynamic performance. The factory calibration characterizes each sensor for
> > > sensitivity, bias, and alignment. As a result, each sensor has its own dynamic
> > > compensation formulas that provide accurate sensor measurements.
> > >     
> > Hi Robert,
> > 
> > The cover letter of any RESEND should always start with why you are doing so.
> > If this was for the tiny fixup you mentioned it should have been v9 and
> > not have been sent for a few days at least.  If everything else is fine
> > I don't mind making that sort of fixup whilst applying anyway!  
> 
> With the tweaks to patch 5 and co-developed tags added as mentioned
> in reply to that commit applied to the togreg branch of iio.git which
> is initially pushed out as testing.
> 
Another tweak:
0-day/ coccinelle reported:
55be950cfc6031 Robert Budai 2025-02-17  1024  	.self_test_mask = BIT(1),
55be950cfc6031 Robert Budai 2025-02-17  1025  	.self_test_reg = ADIS16550_REG_COMMAND,
55be950cfc6031 Robert Budai 2025-02-17  1026  	.cs_change_delay = 5,
55be950cfc6031 Robert Budai 2025-02-17  1027  	.unmasked_drdy = true,
55be950cfc6031 Robert Budai 2025-02-17  1028  	.status_error_msgs = adis16550_status_error_msgs,
55be950cfc6031 Robert Budai 2025-02-17 @1029  	.status_error_mask = BIT(ADIS16550_STATUS_CRC_CODE) |
55be950cfc6031 Robert Budai 2025-02-17  1030  			BIT(ADIS16550_STATUS_CRC_CONFIG) |
55be950cfc6031 Robert Budai 2025-02-17  1031  			BIT(ADIS16550_STATUS_FLASH_UPDATE) |
55be950cfc6031 Robert Budai 2025-02-17  1032  			BIT(ADIS16550_STATUS_INERIAL) |
55be950cfc6031 Robert Budai 2025-02-17  1033  			BIT(ADIS16550_STATUS_SENSOR) |
55be950cfc6031 Robert Budai 2025-02-17  1034  			BIT(ADIS16550_STATUS_TEMPERATURE) |
55be950cfc6031 Robert Budai 2025-02-17  1035  			BIT(ADIS16550_STATUS_SPI) |
55be950cfc6031 Robert Budai 2025-02-17  1036  			BIT(ADIS16550_STATUS_PROCESSING) |
55be950cfc6031 Robert Budai 2025-02-17  1037  			BIT(ADIS16550_STATUS_POWER) |
55be950cfc6031 Robert Budai 2025-02-17  1038  			BIT(ADIS16550_STATUS_BOOT) |
55be950cfc6031 Robert Budai 2025-02-17  1039  			BIT(ADIS16550_STATUS_WATCHDOG) |
55be950cfc6031 Robert Budai 2025-02-17  1040  			BIT(ADIS16550_STATUS_REGULATOR) |
55be950cfc6031 Robert Budai 2025-02-17  1041  			BIT(ADIS16550_STATUS_SENSOR_SUPPLY) |
55be950cfc6031 Robert Budai 2025-02-17  1042  			BIT(ADIS16550_STATUS_CPU_SUPPLY) |
55be950cfc6031 Robert Budai 2025-02-17  1043  			BIT(ADIS16550_STATUS_5V_SUPPLY) |
55be950cfc6031 Robert Budai 2025-02-17  1044  			BIT(ADIS16550_STATUS_CRC_CODE),

this is duplicate.  I dropped this one.

55be950cfc6031 Robert Budai 2025-02-17  1045  	.timeouts = &adis16550_timeouts,
55be950cfc6031 Robert Budai 2025-02-17  1046  };
55be950cfc6031 Robert Budai 2025-02-17  1047


> Jonathan
> 
> > 
> > Jonathan
> > 
> >   
> > > Robert Budai (6):
> > >   iio: imu: adis: Add custom ops struct
> > >   iio: imu: adis: Add reset to custom ops
> > >   iio: imu: adis: Add DIAG_STAT register
> > >   dt-bindings: iio: Add adis16550 bindings
> > >   iio: imu: adis16550: add adis16550 support
> > >   docs: iio: add documentation for adis16550 driver
> > > 
> > >  .../bindings/iio/imu/adi,adis16550.yaml       |   74 ++
> > >  Documentation/iio/adis16550.rst               |  376 ++++++
> > >  Documentation/iio/index.rst                   |    1 +
> > >  MAINTAINERS                                   |   10 +
> > >  drivers/iio/imu/Kconfig                       |   13 +
> > >  drivers/iio/imu/Makefile                      |    1 +
> > >  drivers/iio/imu/adis.c                        |   35 +-
> > >  drivers/iio/imu/adis16550.c                   | 1149 +++++++++++++++++
> > >  include/linux/iio/imu/adis.h                  |   34 +-
> > >  9 files changed, 1680 insertions(+), 13 deletions(-)
> > >  create mode 100644 Documentation/devicetree/bindings/iio/imu/adi,adis16550.yaml
> > >  create mode 100644 Documentation/iio/adis16550.rst
> > >  create mode 100644 drivers/iio/imu/adis16550.c
> > >     
> > 
> >   
> 
>