[RFC PATCH v2 0/3] platform/x86: acer-wmi: Add fan control support

Armin Wolf posted 3 patches 10 months ago
There is a newer version of this series
drivers/platform/x86/acer-wmi.c | 298 +++++++++++++++++++++++++++++---
1 file changed, 273 insertions(+), 25 deletions(-)
[RFC PATCH v2 0/3] platform/x86: acer-wmi: Add fan control support
Posted by Armin Wolf 10 months ago
This experimental patch series aims to add fan control support to the
acer-wmi driver. The patches are compile-tested only and need to be
tested on real hardware to verify that they actually work.

I CCed two users who requested support for this feature. I would be
very happy if both of you could test those patches and report back.

I am ready to help you both with compiling a custom linux kernel for
testing this series.

Changes since v2:
- remove duplicate include and replace hwmon_pwm_mode with
  hwmon_pwm_enable in second patch

Armin Wolf (3):
  platform/x86: acer-wmi: Fix setting of fan behavior
  platform/x86: acer-wmi: Add fan control support
  platform/x86: acer-wmi: Enable fan control for PH16-72 and PT14-51

 drivers/platform/x86/acer-wmi.c | 298 +++++++++++++++++++++++++++++---
 1 file changed, 273 insertions(+), 25 deletions(-)

--
2.39.5
Re: [RFC PATCH v2 0/3] platform/x86: acer-wmi: Add fan control support
Posted by Armin Wolf 9 months, 2 weeks ago
Am 15.02.25 um 18:45 schrieb Armin Wolf:

> This experimental patch series aims to add fan control support to the
> acer-wmi driver. The patches are compile-tested only and need to be
> tested on real hardware to verify that they actually work.
>
> I CCed two users who requested support for this feature. I would be
> very happy if both of you could test those patches and report back.
>
> I am ready to help you both with compiling a custom linux kernel for
> testing this series.

Any updates from the two people with Acer hardware?

Thanks,
Armin Wolf

> Changes since v2:
> - remove duplicate include and replace hwmon_pwm_mode with
>    hwmon_pwm_enable in second patch
>
> Armin Wolf (3):
>    platform/x86: acer-wmi: Fix setting of fan behavior
>    platform/x86: acer-wmi: Add fan control support
>    platform/x86: acer-wmi: Enable fan control for PH16-72 and PT14-51
>
>   drivers/platform/x86/acer-wmi.c | 298 +++++++++++++++++++++++++++++---
>   1 file changed, 273 insertions(+), 25 deletions(-)
>
> --
> 2.39.5
>
>
Re: [RFC PATCH v2 0/3] platform/x86: acer-wmi: Add fan control support
Posted by Fa-Iz Faadhillah Ibrahim 4 months ago
> > This experimental patch series aims to add fan control support to the > acer-wmi driver. The patches are compile-tested only and need to be 
> > tested on real hardware to verify that they actually work. > > I 
> CCed two users who requested support for this feature. I would be > 
> very happy if both of you could test those patches and report back. > 
> > I am ready to help you both with compiling a custom linux kernel for 
> > testing this series.
> Any updates from the two people with Acer hardware?
>
> Thanks,
> Armin Wolf

Hello, I've tried your patch on my Predator Helios Neo 16 (PHN16-72)
using quirks from PH16-72 and it looks like fan control works just fine.
On other note, can you please add PHN16-72 to the quirk table?
if you need anything to test please do notify.

Thanks,
Fa-Iz Faadhillah Ibrahim

>
> > Changes since v2: > - remove duplicate include and replace hwmon_pwm_mode with > 
> hwmon_pwm_enable in second patch > > Armin Wolf (3): > platform/x86: 
> acer-wmi: Fix setting of fan behavior > platform/x86: acer-wmi: Add 
> fan control support > platform/x86: acer-wmi: Enable fan control for 
> PH16-72 and PT14-51 > > drivers/platform/x86/acer-wmi.c | 298 
> +++++++++++++++++++++++++++++--- > 1 file changed, 273 insertions(+), 
> 25 deletions(-) > > -- > 2.39.5 > >
> ------------------------------------------------------------------------
Re: [RFC PATCH v2 0/3] platform/x86: acer-wmi: Add fan control support
Posted by Armin Wolf 3 months, 4 weeks ago
Am 15.08.25 um 08:17 schrieb Fa-Iz Faadhillah Ibrahim:

>> > This experimental patch series aims to add fan control support to 
>> the > acer-wmi driver. The patches are compile-tested only and need 
>> to be > tested on real hardware to verify that they actually work. > 
>> > I CCed two users who requested support for this feature. I would be 
>> > very happy if both of you could test those patches and report back. 
>> > > I am ready to help you both with compiling a custom linux kernel 
>> for > testing this series.
>> Any updates from the two people with Acer hardware?
>>
>> Thanks,
>> Armin Wolf
>
> Hello, I've tried your patch on my Predator Helios Neo 16 (PHN16-72)
> using quirks from PH16-72 and it looks like fan control works just fine.
> On other note, can you please add PHN16-72 to the quirk table?
> if you need anything to test please do notify.
>
> Thanks,
> Fa-Iz Faadhillah Ibrahim
>
Hi,

sorry for taking a bit long to respond, i am currently on vacation. Nice to know that the experimental patches work :).
Can you send me the output of "acpidump" on your machine?

Thanks,
Armin Wolf

>>
>> > Changes since v2: > - remove duplicate include and replace 
>> hwmon_pwm_mode with > hwmon_pwm_enable in second patch > > Armin Wolf 
>> (3): > platform/x86: acer-wmi: Fix setting of fan behavior > 
>> platform/x86: acer-wmi: Add fan control support > platform/x86: 
>> acer-wmi: Enable fan control for PH16-72 and PT14-51 > > 
>> drivers/platform/x86/acer-wmi.c | 298 
>> +++++++++++++++++++++++++++++--- > 1 file changed, 273 insertions(+), 
>> 25 deletions(-) > > -- > 2.39.5 > >
>> ------------------------------------------------------------------------
>
>
Re: [RFC PATCH v2 0/3] platform/x86: acer-wmi: Add fan control support
Posted by Rayan Margham 9 months, 2 weeks ago
I’m so sorry I’ve been in a mental health unit for the past month, are you still working on the driver I would love to test anything you provide me now

Bestest regards
Rayan Margham 

> On 5 Mar 2025, at 00:24, Armin Wolf <W_Armin@gmx.de> wrote:
> 
> Am 15.02.25 um 18:45 schrieb Armin Wolf:
> 
>> This experimental patch series aims to add fan control support to the
>> acer-wmi driver. The patches are compile-tested only and need to be
>> tested on real hardware to verify that they actually work.
>> 
>> I CCed two users who requested support for this feature. I would be
>> very happy if both of you could test those patches and report back.
>> 
>> I am ready to help you both with compiling a custom linux kernel for
>> testing this series.
> 
> Any updates from the two people with Acer hardware?
> 
> Thanks,
> Armin Wolf
> 
>> Changes since v2:
>> - remove duplicate include and replace hwmon_pwm_mode with
>>   hwmon_pwm_enable in second patch
>> 
>> Armin Wolf (3):
>>   platform/x86: acer-wmi: Fix setting of fan behavior
>>   platform/x86: acer-wmi: Add fan control support
>>   platform/x86: acer-wmi: Enable fan control for PH16-72 and PT14-51
>> 
>>  drivers/platform/x86/acer-wmi.c | 298 +++++++++++++++++++++++++++++---
>>  1 file changed, 273 insertions(+), 25 deletions(-)
>> 
>> --
>> 2.39.5
>> 
>> 
Re: [RFC PATCH v2 0/3] platform/x86: acer-wmi: Add fan control support
Posted by Armin Wolf 9 months, 1 week ago
Am 09.03.25 um 13:51 schrieb Rayan Margham:

> I’m so sorry I’ve been in a mental health unit for the past month, are you still working on the driver I would love to test anything you provide me now
>
> Bestest regards
> Rayan Margham

Oh my, i wish you all the best for recovery.

Can you compile the current -rc kernel with this patch series applied? If no then i can give you a .deb package containing the kernel and the
modified acer-wmi driver.

Thanks,
Armin Wolf

>> On 5 Mar 2025, at 00:24, Armin Wolf <W_Armin@gmx.de> wrote:
>>
>> Am 15.02.25 um 18:45 schrieb Armin Wolf:
>>
>>> This experimental patch series aims to add fan control support to the
>>> acer-wmi driver. The patches are compile-tested only and need to be
>>> tested on real hardware to verify that they actually work.
>>>
>>> I CCed two users who requested support for this feature. I would be
>>> very happy if both of you could test those patches and report back.
>>>
>>> I am ready to help you both with compiling a custom linux kernel for
>>> testing this series.
>> Any updates from the two people with Acer hardware?
>>
>> Thanks,
>> Armin Wolf
>>
>>> Changes since v2:
>>> - remove duplicate include and replace hwmon_pwm_mode with
>>>    hwmon_pwm_enable in second patch
>>>
>>> Armin Wolf (3):
>>>    platform/x86: acer-wmi: Fix setting of fan behavior
>>>    platform/x86: acer-wmi: Add fan control support
>>>    platform/x86: acer-wmi: Enable fan control for PH16-72 and PT14-51
>>>
>>>   drivers/platform/x86/acer-wmi.c | 298 +++++++++++++++++++++++++++++---
>>>   1 file changed, 273 insertions(+), 25 deletions(-)
>>>
>>> --
>>> 2.39.5
>>>
>>>
Re: [RFC PATCH v2 0/3] platform/x86: acer-wmi: Add fan control support
Posted by Rayan Margham 9 months, 1 week ago
Could i have the deb package, I can try to install it.

On Tue, Mar 11, 2025 at 9:53 PM Armin Wolf <W_Armin@gmx.de> wrote:
>
> Am 09.03.25 um 13:51 schrieb Rayan Margham:
>
> > I’m so sorry I’ve been in a mental health unit for the past month, are you still working on the driver I would love to test anything you provide me now
> >
> > Bestest regards
> > Rayan Margham
>
> Oh my, i wish you all the best for recovery.
>
> Can you compile the current -rc kernel with this patch series applied? If no then i can give you a .deb package containing the kernel and the
> modified acer-wmi driver.
>
> Thanks,
> Armin Wolf
>
> >> On 5 Mar 2025, at 00:24, Armin Wolf <W_Armin@gmx.de> wrote:
> >>
> >> Am 15.02.25 um 18:45 schrieb Armin Wolf:
> >>
> >>> This experimental patch series aims to add fan control support to the
> >>> acer-wmi driver. The patches are compile-tested only and need to be
> >>> tested on real hardware to verify that they actually work.
> >>>
> >>> I CCed two users who requested support for this feature. I would be
> >>> very happy if both of you could test those patches and report back.
> >>>
> >>> I am ready to help you both with compiling a custom linux kernel for
> >>> testing this series.
> >> Any updates from the two people with Acer hardware?
> >>
> >> Thanks,
> >> Armin Wolf
> >>
> >>> Changes since v2:
> >>> - remove duplicate include and replace hwmon_pwm_mode with
> >>>    hwmon_pwm_enable in second patch
> >>>
> >>> Armin Wolf (3):
> >>>    platform/x86: acer-wmi: Fix setting of fan behavior
> >>>    platform/x86: acer-wmi: Add fan control support
> >>>    platform/x86: acer-wmi: Enable fan control for PH16-72 and PT14-51
> >>>
> >>>   drivers/platform/x86/acer-wmi.c | 298 +++++++++++++++++++++++++++++---
> >>>   1 file changed, 273 insertions(+), 25 deletions(-)
> >>>
> >>> --
> >>> 2.39.5
> >>>
> >>>
Re: [RFC PATCH v2 0/3] platform/x86: acer-wmi: Add fan control support
Posted by Armin Wolf 9 months, 1 week ago
Am 13.03.25 um 19:21 schrieb Rayan Margham:

> Could i have the deb package, I can try to install it.

Alright, the .deb files for both the kernel image and the kernel headers are available here:

	https://nextcloud.thetwins.xyz/s/oatc9DaW5XtiP9E

Thanks,
Armin Wolf

> On Tue, Mar 11, 2025 at 9:53 PM Armin Wolf <W_Armin@gmx.de> wrote:
>> Am 09.03.25 um 13:51 schrieb Rayan Margham:
>>
>>> I’m so sorry I’ve been in a mental health unit for the past month, are you still working on the driver I would love to test anything you provide me now
>>>
>>> Bestest regards
>>> Rayan Margham
>> Oh my, i wish you all the best for recovery.
>>
>> Can you compile the current -rc kernel with this patch series applied? If no then i can give you a .deb package containing the kernel and the
>> modified acer-wmi driver.
>>
>> Thanks,
>> Armin Wolf
>>
>>>> On 5 Mar 2025, at 00:24, Armin Wolf <W_Armin@gmx.de> wrote:
>>>>
>>>> Am 15.02.25 um 18:45 schrieb Armin Wolf:
>>>>
>>>>> This experimental patch series aims to add fan control support to the
>>>>> acer-wmi driver. The patches are compile-tested only and need to be
>>>>> tested on real hardware to verify that they actually work.
>>>>>
>>>>> I CCed two users who requested support for this feature. I would be
>>>>> very happy if both of you could test those patches and report back.
>>>>>
>>>>> I am ready to help you both with compiling a custom linux kernel for
>>>>> testing this series.
>>>> Any updates from the two people with Acer hardware?
>>>>
>>>> Thanks,
>>>> Armin Wolf
>>>>
>>>>> Changes since v2:
>>>>> - remove duplicate include and replace hwmon_pwm_mode with
>>>>>     hwmon_pwm_enable in second patch
>>>>>
>>>>> Armin Wolf (3):
>>>>>     platform/x86: acer-wmi: Fix setting of fan behavior
>>>>>     platform/x86: acer-wmi: Add fan control support
>>>>>     platform/x86: acer-wmi: Enable fan control for PH16-72 and PT14-51
>>>>>
>>>>>    drivers/platform/x86/acer-wmi.c | 298 +++++++++++++++++++++++++++++---
>>>>>    1 file changed, 273 insertions(+), 25 deletions(-)
>>>>>
>>>>> --
>>>>> 2.39.5
>>>>>
>>>>>