[v2] staging: gpib: remove unused variables

[PATCH v2 0/5] staging: gpib: remove unused variables

Gaston Gonzalez posted 5 patches 10 months, 1 week ago

Diff against v1
Download series mbox

drivers/staging/gpib/cb7210/cb7210.c        | 2 --
drivers/staging/gpib/eastwood/fluke_gpib.c  | 2 --
drivers/staging/gpib/ines/ines_gpib.c       | 2 --
drivers/staging/gpib/ni_usb/ni_usb_gpib.c   | 3 +--
drivers/staging/gpib/tnt4882/tnt4882_gpib.c | 3 +--
5 files changed, 2 insertions(+), 10 deletions(-)

Expand all Fold all

[PATCH v2 0/5] staging: gpib: remove unused variables

Posted by Gaston Gonzalez 10 months, 1 week ago

Remove some unused variables found compiling with W=1.

v1 -> v2:

Address Kees Bakker review:

- Keep the post increment expression (i++) in patch 3.
- Keep the call to nec7210_update_status_nolock() in patch 4.

Gaston Gonzalez (5):
  staging: gpib: cb7210: remove unused variable
  staging: gpib: eastwood: remove unused variable
  staging: gpib: ni_usb: remove unused variable
  staging: gpib: tnt4882: remove unused variable
  staging: gpib: ines: remove unused variable

 drivers/staging/gpib/cb7210/cb7210.c        | 2 --
 drivers/staging/gpib/eastwood/fluke_gpib.c  | 2 --
 drivers/staging/gpib/ines/ines_gpib.c       | 2 --
 drivers/staging/gpib/ni_usb/ni_usb_gpib.c   | 3 +--
 drivers/staging/gpib/tnt4882/tnt4882_gpib.c | 3 +--
 5 files changed, 2 insertions(+), 10 deletions(-)

-- 
2.48.1

Re: [PATCH v2 0/5] staging: gpib: remove unused variables

Posted by Dan Carpenter 10 months ago

On Fri, Feb 14, 2025 at 04:54:38PM -0300, Gaston Gonzalez wrote:
> Remove some unused variables found compiling with W=1.
> 
> v1 -> v2:
> 
> Address Kees Bakker review:

This looks good to me now.  Thanks Kees for finding the bugs in
v1.

Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org>

regards,
dan carpenter