The GPIB drivers printed a lot of spurious console messages. This
was linked to the level of code maturity, often using console
messages for debug.

This patch set cleans up the console messaging in the spirit of Greg's
recommendation: "When drivers are successful, they should be quiet"

All pr_info's have been removed except for one which is in the module
init of the common core driver indicating that the GPIB subsystem is
initialized.

All dev_info's have been removed or changed to dev_dbg except for the
attach and probe messages in the agilent and ni usb drivers. This is
to facilitate the creation of config and udev scripts to ensure that a
particular usb device is systematically attached to the same gpib
device file.

All custom debug and tty logging has been removed or replaced with
dev_dbg.

Error messages where the user can figure out what went wrong with
errno have also been removed, particularly timeouts and interrupts
during reads and writes which can occur quite frequently uneccessarily
cluttering up the console log.

The patches are 1 per driver.

Patch  1: agilent_82350b
Patch  2: agilent_82357a
Patch  3: cb7210
Patch  4: cec_gpib
Patch  5: common core
Patch  6: fluke
Patch  7: fmh fgpa
Patch  8: gpio bitbang
Patch  9: hp82335
Patch 10: hp82341
Patch 11: ines
Patch 12: lpvo
Patch 13: nec7210
Patch 14: ni_usb
Patch 15: pc2
Patch 16  tms9914
Patch 17: tnt4882

Dave Penkler (17):
  staging: gpib: agilent pci console messaging cleanup
  staging: gpib: agilent usb console messaging cleanup
  staging: gpib: cb7210 console messaging cleanup
  staging: gpib: cec_gpib console messaging cleanup
  staging: gpib: common core console messaging cleanup
  staging: gpib: fluke console messaging cleanup
  staging: gpib: fmh console messaging cleanup
  staging: gpib: gpio bitbang console messaging cleanup
  staging: gpib: hp82335 console messaging cleanup
  staging: gpib: hp82341 console messaging cleanup
  staging: gpib: ines console messaging cleanup
  staging: gpib: lpvo console messaging cleanup
  staging: gpib: nec7210 console messaging cleanup
  staging: gpib: ni_usb console messaging cleanup
  staging: gpib: pc2 console messaging cleanup
  staging: gpib: tms9914 console messaging cleanup
  staging: gpib: tnt4882 console messaging cleanup

 .../gpib/agilent_82350b/agilent_82350b.c      | 118 ++---
 .../gpib/agilent_82350b/agilent_82350b.h      |   3 -
 .../gpib/agilent_82357a/agilent_82357a.c      | 359 ++++++---------
 drivers/staging/gpib/cb7210/cb7210.c          | 133 +++---
 drivers/staging/gpib/cec/cec_gpib.c           |  32 +-
 drivers/staging/gpib/common/gpib_os.c         | 127 ++----
 drivers/staging/gpib/common/iblib.c           | 109 ++---
 drivers/staging/gpib/eastwood/fluke_gpib.c    |  90 ++--
 drivers/staging/gpib/fmh_gpib/fmh_gpib.c      | 140 +++---
 drivers/staging/gpib/gpio/gpib_bitbang.c      |  56 +--
 drivers/staging/gpib/hp_82335/hp82335.c       |  19 +-
 drivers/staging/gpib/hp_82341/hp_82341.c      |  70 ++-
 drivers/staging/gpib/ines/ines_gpib.c         | 101 ++---
 .../gpib/lpvo_usb_gpib/lpvo_usb_gpib.c        | 255 ++++-------
 drivers/staging/gpib/nec7210/nec7210.c        |  69 +--
 drivers/staging/gpib/ni_usb/ni_usb_gpib.c     | 425 ++++++++----------
 drivers/staging/gpib/pc2/pc2_gpib.c           |  51 ++-
 drivers/staging/gpib/tms9914/tms9914.c        |  33 +-
 drivers/staging/gpib/tnt4882/mite.c           |  17 -
 drivers/staging/gpib/tnt4882/tnt4882_gpib.c   | 186 +++-----
 20 files changed, 912 insertions(+), 1481 deletions(-)

-- 
2.48.1

On Fri, Feb 14, 2025 at 12:46:51PM +0100, Dave Penkler wrote:
> The GPIB drivers printed a lot of spurious console messages. This
> was linked to the level of code maturity, often using console
> messages for debug.
> 
> This patch set cleans up the console messaging in the spirit of Greg's
> recommendation: "When drivers are successful, they should be quiet"
> 
> All pr_info's have been removed except for one which is in the module
> init of the common core driver indicating that the GPIB subsystem is
> initialized.
> 
> All dev_info's have been removed or changed to dev_dbg except for the
> attach and probe messages in the agilent and ni usb drivers. This is
> to facilitate the creation of config and udev scripts to ensure that a
> particular usb device is systematically attached to the same gpib
> device file.
> 
> All custom debug and tty logging has been removed or replaced with
> dev_dbg.
> 
> Error messages where the user can figure out what went wrong with
> errno have also been removed, particularly timeouts and interrupts
> during reads and writes which can occur quite frequently uneccessarily
> cluttering up the console log.
> 
> The patches are 1 per driver.

All but 4 of these applied, can you rebase and resend the remaining
ones?

thanks,

greg k-h

On Wed, Feb 19, 2025 at 04:48:39PM +0100, Greg KH wrote:
> On Fri, Feb 14, 2025 at 12:46:51PM +0100, Dave Penkler wrote:
> > The GPIB drivers printed a lot of spurious console messages. This
> > was linked to the level of code maturity, often using console
> > messages for debug.
> > 
> > This patch set cleans up the console messaging in the spirit of Greg's
> > recommendation: "When drivers are successful, they should be quiet"
> > 
> > All pr_info's have been removed except for one which is in the module
> > init of the common core driver indicating that the GPIB subsystem is
> > initialized.
> > 
> > All dev_info's have been removed or changed to dev_dbg except for the
> > attach and probe messages in the agilent and ni usb drivers. This is
> > to facilitate the creation of config and udev scripts to ensure that a
> > particular usb device is systematically attached to the same gpib
> > device file.
> > 
> > All custom debug and tty logging has been removed or replaced with
> > dev_dbg.
> > 
> > Error messages where the user can figure out what went wrong with
> > errno have also been removed, particularly timeouts and interrupts
> > during reads and writes which can occur quite frequently uneccessarily
> > cluttering up the console log.
> > 
> > The patches are 1 per driver.
> 
> All but 4 of these applied, can you rebase and resend the remaining
> ones?
> 
> thanks,
> 
> greg k-h
Sure, thanks.
(Could only find 3 that were not applied, will send those)
-dave

On Thu, Feb 20, 2025 at 09:55:28AM +0100, Dave Penkler wrote:
> On Wed, Feb 19, 2025 at 04:48:39PM +0100, Greg KH wrote:
> > On Fri, Feb 14, 2025 at 12:46:51PM +0100, Dave Penkler wrote:
> > > The GPIB drivers printed a lot of spurious console messages. This
> > > was linked to the level of code maturity, often using console
> > > messages for debug.
> > > 
> > > This patch set cleans up the console messaging in the spirit of Greg's
> > > recommendation: "When drivers are successful, they should be quiet"
> > > 
> > > All pr_info's have been removed except for one which is in the module
> > > init of the common core driver indicating that the GPIB subsystem is
> > > initialized.
> > > 
> > > All dev_info's have been removed or changed to dev_dbg except for the
> > > attach and probe messages in the agilent and ni usb drivers. This is
> > > to facilitate the creation of config and udev scripts to ensure that a
> > > particular usb device is systematically attached to the same gpib
> > > device file.
> > > 
> > > All custom debug and tty logging has been removed or replaced with
> > > dev_dbg.
> > > 
> > > Error messages where the user can figure out what went wrong with
> > > errno have also been removed, particularly timeouts and interrupts
> > > during reads and writes which can occur quite frequently uneccessarily
> > > cluttering up the console log.
> > > 
> > > The patches are 1 per driver.
> > 
> > All but 4 of these applied, can you rebase and resend the remaining
> > ones?
> > 
> > thanks,
> > 
> > greg k-h
> Sure, thanks.
> (Could only find 3 that were not applied, will send those)

Sorry, might have been three, my fault, it was a lot of me typing 'git
am --skip'  :)

thanks,

greg k-h