[PATCH v1] ALSA: hda/tas2781: Fix index issue in tas2781 hda SPI driver

Baojun Xu posted 1 patch 10 months, 1 week ago
sound/pci/hda/tas2781_spi_fwlib.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
[PATCH v1] ALSA: hda/tas2781: Fix index issue in tas2781 hda SPI driver
Posted by Baojun Xu 10 months, 1 week ago
Correct wrong mask for device index.

Signed-off-by: Baojun Xu <baojun.xu@ti.com>
---
 sound/pci/hda/tas2781_spi_fwlib.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/sound/pci/hda/tas2781_spi_fwlib.c b/sound/pci/hda/tas2781_spi_fwlib.c
index 0e2acbc3c900..131d9a77d140 100644
--- a/sound/pci/hda/tas2781_spi_fwlib.c
+++ b/sound/pci/hda/tas2781_spi_fwlib.c
@@ -2,7 +2,7 @@
 //
 // TAS2781 HDA SPI driver
 //
-// Copyright 2024 Texas Instruments, Inc.
+// Copyright 2024-2025 Texas Instruments, Inc.
 //
 // Author: Baojun Xu <baojun.xu@ti.com>
 
@@ -771,19 +771,19 @@ static int tasdevice_process_block(void *context, unsigned char *data,
 	switch (subblk_typ) {
 	case TASDEVICE_CMD_SING_W:
 		subblk_offset = tasdevice_single_byte_wr(tas_priv,
-			dev_idx & 0x4f, data, sublocksize);
+			dev_idx & 0x3f, data, sublocksize);
 		break;
 	case TASDEVICE_CMD_BURST:
 		subblk_offset = tasdevice_burst_wr(tas_priv,
-			dev_idx & 0x4f, data, sublocksize);
+			dev_idx & 0x3f, data, sublocksize);
 		break;
 	case TASDEVICE_CMD_DELAY:
 		subblk_offset = tasdevice_delay(tas_priv,
-			dev_idx & 0x4f, data, sublocksize);
+			dev_idx & 0x3f, data, sublocksize);
 		break;
 	case TASDEVICE_CMD_FIELD_W:
 		subblk_offset = tasdevice_field_wr(tas_priv,
-			dev_idx & 0x4f, data, sublocksize);
+			dev_idx & 0x3f, data, sublocksize);
 		break;
 	default:
 		subblk_offset = 2;
-- 
2.34.1
Re: [PATCH v1] ALSA: hda/tas2781: Fix index issue in tas2781 hda SPI driver
Posted by Takashi Iwai 10 months, 1 week ago
On Fri, 14 Feb 2025 02:30:21 +0100,
Baojun Xu wrote:
> 
> Correct wrong mask for device index.
> 
> Signed-off-by: Baojun Xu <baojun.xu@ti.com>

Applied now with Fixes tag to commit bb5f86ea50ff ("ALSA: hda/tas2781:
Add tas2781 hda SPI driver").

Please put the proper Fix tag at the next time.


thanks,

Takashi