1. Patchew
  2. linux
  3. [PATCH v5 0/8] arm64: dts: Add Arm Morello support
  4. View patch

[PATCH v5 2/8] dt-bindings: arm: Add Morello fvp compatibility

Vincenzo Frascino posted 8 patches 10 months, 1 week ago
There is a newer version of this series
[PATCH v5 2/8] dt-bindings: arm: Add Morello fvp compatibility
Posted by Vincenzo Frascino 10 months, 1 week ago 
Add compatibility to Arm Morello Fixed Virtual Platform.

Signed-off-by: Vincenzo Frascino <vincenzo.frascino@arm.com>
---
 Documentation/devicetree/bindings/arm/arm,vexpress-juno.yaml | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/Documentation/devicetree/bindings/arm/arm,vexpress-juno.yaml b/Documentation/devicetree/bindings/arm/arm,vexpress-juno.yaml
index 40e7910756c8..e71e3e33c4be 100644
--- a/Documentation/devicetree/bindings/arm/arm,vexpress-juno.yaml
+++ b/Documentation/devicetree/bindings/arm/arm,vexpress-juno.yaml
@@ -122,6 +122,10 @@ properties:
         items:
           - const: arm,morello-sdp
           - const: arm,morello
+      - description: Arm Morello Fixed Virtual Platform
+        items:
+          - const: arm,morello-fvp
+          - const: arm,morello
 
   arm,vexpress,position:
     description: When daughterboards are stacked on one site, their position
-- 
2.43.0
Re: [PATCH v5 2/8] dt-bindings: arm: Add Morello fvp compatibility
Posted by Krzysztof Kozlowski 10 months, 1 week ago 
On Thu, Feb 13, 2025 at 06:03:03PM +0000, Vincenzo Frascino wrote:
> Add compatibility to Arm Morello Fixed Virtual Platform.
> 
> Signed-off-by: Vincenzo Frascino <vincenzo.frascino@arm.com>
> ---
>  Documentation/devicetree/bindings/arm/arm,vexpress-juno.yaml | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/arm,vexpress-juno.yaml b/Documentation/devicetree/bindings/arm/arm,vexpress-juno.yaml
> index 40e7910756c8..e71e3e33c4be 100644
> --- a/Documentation/devicetree/bindings/arm/arm,vexpress-juno.yaml
> +++ b/Documentation/devicetree/bindings/arm/arm,vexpress-juno.yaml
> @@ -122,6 +122,10 @@ properties:
>          items:
>            - const: arm,morello-sdp

That's just part of the enum here.

>            - const: arm,morello
> +      - description: Arm Morello Fixed Virtual Platform
> +        items:
> +          - const: arm,morello-fvp

Best regards,
Krzysztof
Re: [PATCH v5 2/8] dt-bindings: arm: Add Morello fvp compatibility
Posted by Vincenzo Frascino 10 months ago 

On 14/02/2025 08:12, Krzysztof Kozlowski wrote:
> On Thu, Feb 13, 2025 at 06:03:03PM +0000, Vincenzo Frascino wrote:
>> Add compatibility to Arm Morello Fixed Virtual Platform.
>>
>> Signed-off-by: Vincenzo Frascino <vincenzo.frascino@arm.com>
>> ---
>>  Documentation/devicetree/bindings/arm/arm,vexpress-juno.yaml | 4 ++++
>>  1 file changed, 4 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/arm,vexpress-juno.yaml b/Documentation/devicetree/bindings/arm/arm,vexpress-juno.yaml
>> index 40e7910756c8..e71e3e33c4be 100644
>> --- a/Documentation/devicetree/bindings/arm/arm,vexpress-juno.yaml
>> +++ b/Documentation/devicetree/bindings/arm/arm,vexpress-juno.yaml
>> @@ -122,6 +122,10 @@ properties:
>>          items:
>>            - const: arm,morello-sdp
> 
> That's just part of the enum here.
>

I am not sure on what you want me to do :)

--->8---

diff --git a/Documentation/devicetree/bindings/arm/arm,vexpress-juno.yaml
b/Documentation/devicetree/bindings/arm/arm,vexpress-juno.yaml
index 40e7910756c8..8de508b977b0 100644
--- a/Documentation/devicetree/bindings/arm/arm,vexpress-juno.yaml
+++ b/Documentation/devicetree/bindings/arm/arm,vexpress-juno.yaml
@@ -118,9 +118,11 @@ description: |+
         items:
           - const: arm,foundation-aarch64
           - const: arm,vexpress
-      - description: Arm Morello System Development Platform
+      - description: Arm Morello System Development/Fixed Virtual Platform
         items:
-          - const: arm,morello-sdp
+          - enum:
+	      - arm,morello-sdp
+	      - arm,morello-fvp
           - const: arm,morello

   arm,vexpress,position:
-- 
2.34.1

--->8---

Something like this?

>>            - const: arm,morello
>> +      - description: Arm Morello Fixed Virtual Platform
>> +        items:
>> +          - const: arm,morello-fvp
> 
> Best regards,
> Krzysztof
> 

-- 
Regards,
Vincenzo
Re: [PATCH v5 2/8] dt-bindings: arm: Add Morello fvp compatibility
Posted by Krzysztof Kozlowski 10 months ago 
On 18/02/2025 19:07, Vincenzo Frascino wrote:
> 
> 
> On 14/02/2025 08:12, Krzysztof Kozlowski wrote:
>> On Thu, Feb 13, 2025 at 06:03:03PM +0000, Vincenzo Frascino wrote:
>>> Add compatibility to Arm Morello Fixed Virtual Platform.
>>>
>>> Signed-off-by: Vincenzo Frascino <vincenzo.frascino@arm.com>
>>> ---
>>>  Documentation/devicetree/bindings/arm/arm,vexpress-juno.yaml | 4 ++++
>>>  1 file changed, 4 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/arm/arm,vexpress-juno.yaml b/Documentation/devicetree/bindings/arm/arm,vexpress-juno.yaml
>>> index 40e7910756c8..e71e3e33c4be 100644
>>> --- a/Documentation/devicetree/bindings/arm/arm,vexpress-juno.yaml
>>> +++ b/Documentation/devicetree/bindings/arm/arm,vexpress-juno.yaml
>>> @@ -122,6 +122,10 @@ properties:
>>>          items:
>>>            - const: arm,morello-sdp
>>
>> That's just part of the enum here.
>>
> 
> I am not sure on what you want me to do :)

Don't duplicate, combine pieces which look like enumeration into one
enum entry.

Best regards,
Krzysztof
Re: [PATCH v5 2/8] dt-bindings: arm: Add Morello fvp compatibility
Posted by Vincenzo Frascino 10 months ago 

On 19/02/2025 07:13, Krzysztof Kozlowski wrote:
> Don't duplicate, combine pieces which look like enumeration into one
> enum entry.

Is this what you mean exactly?

--->8---

diff --git a/Documentation/devicetree/bindings/arm/arm,vexpress-juno.yaml
b/Documentation/devicetree/bindings/arm/arm,vexpress-juno.yaml
index 40e7910756c8..8de508b977b0 100644
--- a/Documentation/devicetree/bindings/arm/arm,vexpress-juno.yaml
+++ b/Documentation/devicetree/bindings/arm/arm,vexpress-juno.yaml
@@ -118,9 +118,11 @@ description: |+
         items:
           - const: arm,foundation-aarch64
           - const: arm,vexpress
-      - description: Arm Morello System Development Platform
+      - description: Arm Morello System Development/Fixed Virtual Platform
         items:
-          - const: arm,morello-sdp
+          - enum:
+	      - arm,morello-sdp
+	      - arm,morello-fvp
           - const: arm,morello

   arm,vexpress,position:
-- 
2.34.1

--->8---

-- 
Regards,
Vincenzo
Re: [PATCH v5 2/8] dt-bindings: arm: Add Morello fvp compatibility
Posted by Krzysztof Kozlowski 10 months ago 
On 19/02/2025 12:30, Vincenzo Frascino wrote:
> 
> 
> On 19/02/2025 07:13, Krzysztof Kozlowski wrote:
>> Don't duplicate, combine pieces which look like enumeration into one
>> enum entry.
> 
> Is this what you mean exactly?

Yes.

description could be more generic "Arm Morello System platforms", but
it's fine in your diff as well.

Best regards,
Krzysztof

Patchew 2.1-devel-b67e4c2

© 2016 - 2025 Red Hat, Inc.