[PATCH] nvme/ioctl: add missing space in err message

Caleb Sander Mateos posted 1 patch 10 months, 1 week ago
There is a newer version of this series
drivers/nvme/host/ioctl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] nvme/ioctl: add missing space in err message
Posted by Caleb Sander Mateos 10 months, 1 week ago
nvme_validate_passthru_nsid() logs an err message whose format string is
split over 2 lines. There is a missing space between the two pieces,
resulting in log lines like "... does not match nsid (1)of namespace".
Add the missing space between ")" and "of".

Signed-off-by: Caleb Sander Mateos <csander@purestorage.com>
Fixes: e7d4b5493a2d ("nvme: factor out a nvme_validate_passthru_nsid helper")
---
 drivers/nvme/host/ioctl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/nvme/host/ioctl.c b/drivers/nvme/host/ioctl.c
index e8930146847a..406c1592dd7c 100644
--- a/drivers/nvme/host/ioctl.c
+++ b/drivers/nvme/host/ioctl.c
@@ -281,11 +281,11 @@ static int nvme_submit_io(struct nvme_ns *ns, struct nvme_user_io __user *uio)
 static bool nvme_validate_passthru_nsid(struct nvme_ctrl *ctrl,
 					struct nvme_ns *ns, __u32 nsid)
 {
 	if (ns && nsid != ns->head->ns_id) {
 		dev_err(ctrl->device,
-			"%s: nsid (%u) in cmd does not match nsid (%u)"
+			"%s: nsid (%u) in cmd does not match nsid (%u) "
 			"of namespace\n",
 			current->comm, nsid, ns->head->ns_id);
 		return false;
 	}
 
-- 
2.45.2
Re: [PATCH] nvme/ioctl: add missing space in err message
Posted by Christoph Hellwig 10 months, 1 week ago
On Wed, Feb 12, 2025 at 06:09:16PM -0700, Caleb Sander Mateos wrote:
> nvme_validate_passthru_nsid() logs an err message whose format string is
> split over 2 lines. There is a missing space between the two pieces,
> resulting in log lines like "... does not match nsid (1)of namespace".
> Add the missing space between ")" and "of".

You might as well consolidaste the string to a single line while you're
at it.  Otherwise this looks good.