[PATCH] mfd: lp3943: Drop #include <linux/pwm.h> from header

Uwe Kleine-König posted 1 patch 10 months, 1 week ago
include/linux/mfd/lp3943.h | 1 -
1 file changed, 1 deletion(-)
[PATCH] mfd: lp3943: Drop #include <linux/pwm.h> from header
Posted by Uwe Kleine-König 10 months, 1 week ago
The header doesn't make use of any symbols declared in <linux/pwm.h>.
There are tree files that #include <mfd/lp3943.h>. Two of them
(i.e. drivers/gpio/gpio-lp3943.c and drivers/mfd/lp3943.c) also don't
use any and the third (drivers/pwm/pwm-lp3943.c) has an explicit include
of <linux/pwm.h> itself.

So drop the unused include. The intended side effect is that
drivers/gpio/gpio-lp3943.c and drivers/mfd/lp3943.c stop importing the
"PWM" module namespace.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
---
 include/linux/mfd/lp3943.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/include/linux/mfd/lp3943.h b/include/linux/mfd/lp3943.h
index 020a339f96e8..402f01078fcc 100644
--- a/include/linux/mfd/lp3943.h
+++ b/include/linux/mfd/lp3943.h
@@ -11,7 +11,6 @@
 #define __MFD_LP3943_H__
 
 #include <linux/gpio.h>
-#include <linux/pwm.h>
 #include <linux/regmap.h>
 
 /* Registers */

base-commit: a64dcfb451e254085a7daee5fe51bf22959d52d3
-- 
2.47.1

Re: (subset) [PATCH] mfd: lp3943: Drop #include <linux/pwm.h> from header
Posted by Lee Jones 10 months ago
On Wed, 12 Feb 2025 18:04:03 +0100, Uwe Kleine-König wrote:
> The header doesn't make use of any symbols declared in <linux/pwm.h>.
> There are tree files that #include <mfd/lp3943.h>. Two of them
> (i.e. drivers/gpio/gpio-lp3943.c and drivers/mfd/lp3943.c) also don't
> use any and the third (drivers/pwm/pwm-lp3943.c) has an explicit include
> of <linux/pwm.h> itself.
> 
> So drop the unused include. The intended side effect is that
> drivers/gpio/gpio-lp3943.c and drivers/mfd/lp3943.c stop importing the
> "PWM" module namespace.
> 
> [...]

Applied, thanks!

[1/1] mfd: lp3943: Drop #include <linux/pwm.h> from header
      commit: 3a7db8a6dee5a2c1858678ddf2d7d38128a9caf3

--
Lee Jones [李琼斯]

Re: (subset) [PATCH] mfd: lp3943: Drop #include <linux/pwm.h> from header
Posted by Lee Jones 10 months ago
On Wed, 12 Feb 2025 18:04:03 +0100, Uwe Kleine-König wrote:
> The header doesn't make use of any symbols declared in <linux/pwm.h>.
> There are tree files that #include <mfd/lp3943.h>. Two of them
> (i.e. drivers/gpio/gpio-lp3943.c and drivers/mfd/lp3943.c) also don't
> use any and the third (drivers/pwm/pwm-lp3943.c) has an explicit include
> of <linux/pwm.h> itself.
> 
> So drop the unused include. The intended side effect is that
> drivers/gpio/gpio-lp3943.c and drivers/mfd/lp3943.c stop importing the
> "PWM" module namespace.
> 
> [...]

Applied, thanks!

[1/1] mfd: lp3943: Drop #include <linux/pwm.h> from header
      commit: 5a917e808b56319d977b3062331293136ee1c34c

--
Lee Jones [李琼斯]