hid: Kconfig: Add LEDS_CLASS_MULTICOLOR dependency to HID_LOGITECH

[PATCH] hid: Kconfig: Add LEDS_CLASS_MULTICOLOR dependency to HID_LOGITECH

Posted by Kate Hsuan 10 months, 1 week ago

The test bot found an issue with building hid-lg-g15.

All errors (new ones prefixed by >>):

   powerpc-linux-ld: drivers/hid/hid-lg-g15.o: in function `lg_g510_kbd_led_write':
>> drivers/hid/hid-lg-g15.c:241:(.text+0x768): undefined reference to `led_mc_calc_color_components'
   powerpc-linux-ld: drivers/hid/hid-lg-g15.o: in function `lg_g15_register_led':
>> drivers/hid/hid-lg-g15.c:686:(.text+0xa9c): undefined reference to `devm_led_classdev_multicolor_register_ext'

Since multicolor LED APIs manage the keyboard backlight settings of
hid-lg-g15, the LEDS_CLASS_MULTICOLOR dependency was added to
HID_LOGITECH.

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202502110032.VZ0J024X-lkp@intel.com/
Signed-off-by: Kate Hsuan <hpa@redhat.com>
---
 drivers/hid/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
index 4d2a89d65b65..d7a36c9e94c2 100644
--- a/drivers/hid/Kconfig
+++ b/drivers/hid/Kconfig
@@ -601,6 +601,7 @@ config HID_LOGITECH
 	tristate "Logitech devices"
 	depends on USB_HID
 	depends on LEDS_CLASS
+	depends on LEDS_CLASS_MULTICOLOR
 	default !EXPERT
 	help
 	Support for Logitech devices that are not fully compliant with HID standard.
-- 
2.48.1

Re: [PATCH] hid: Kconfig: Add LEDS_CLASS_MULTICOLOR dependency to HID_LOGITECH

Posted by Jiri Kosina 10 months, 1 week ago

On Tue, 11 Feb 2025, Kate Hsuan wrote:

> The test bot found an issue with building hid-lg-g15.
> 
> All errors (new ones prefixed by >>):
> 
>    powerpc-linux-ld: drivers/hid/hid-lg-g15.o: in function `lg_g510_kbd_led_write':
> >> drivers/hid/hid-lg-g15.c:241:(.text+0x768): undefined reference to `led_mc_calc_color_components'
>    powerpc-linux-ld: drivers/hid/hid-lg-g15.o: in function `lg_g15_register_led':
> >> drivers/hid/hid-lg-g15.c:686:(.text+0xa9c): undefined reference to `devm_led_classdev_multicolor_register_ext'
> 
> Since multicolor LED APIs manage the keyboard backlight settings of
> hid-lg-g15, the LEDS_CLASS_MULTICOLOR dependency was added to
> HID_LOGITECH.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202502110032.VZ0J024X-lkp@intel.com/
> Signed-off-by: Kate Hsuan <hpa@redhat.com>

I've added

	Fixes: a3a064146c50 ("HID: hid-lg-g15: Use standard multicolor LED API")

make the 'HID:' prefix in shortlog uppercase, and applied.

Thanks,

-- 
Jiri Kosina
SUSE Labs