[v1] Add components to support PQ in display path for MT8196

[PATCH 1/5] dt-bindings: display: mediatek: mdp-rsz: Add rules for MT8196

Posted by Sunny Shen 10 months, 1 week ago

Add MDP-RSZ hardware description for MediaTek MT8196 SoC

Signed-off-by: Sunny Shen <sunny.shen@mediatek.com>
---
 .../display/mediatek/mediatek,mdp-rsz.yaml    | 46 +++++++++++++++++++
 1 file changed, 46 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/mediatek/mediatek,mdp-rsz.yaml

diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,mdp-rsz.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,mdp-rsz.yaml
new file mode 100644
index 000000000000..6642b9aa651a
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,mdp-rsz.yaml
@@ -0,0 +1,46 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/display/mediatek/mediatek,mdp-rsz.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: MediaTek display multimedia data path resizer
+
+maintainers:
+  - Chun-Kuang Hu <chunkuang.hu@kernel.org>
+  - Philipp Zabel <p.zabel@pengutronix.de>
+
+description: |
+  MediaTek display multimedia data path resizer, namely MDP-RSZ,
+  can do scaling up/down to the picture.
+
+properties:
+  compatible:
+    const: mediatek,mt8196-disp-mdp-rsz
+
+  reg:
+    maxItems: 1
+
+  clocks:
+    items:
+      - description: MDP-RSZ Clock
+
+required:
+  - compatible
+  - reg
+  - clocks
+
+additionalProperties: false
+
+examples:
+  - |
+    soc {
+        #address-cells = <2>;
+        #size-cells = <2>;
+
+        disp_mdp_rsz0: disp-mdp-rsz0@321a0000 {
+            compatible = "mediatek,mt8196-disp-mdp-rsz";
+            reg = <0 0x321a0000 0 0x1000>;
+            clocks = <&dispsys_config_clk 101>;
+        };
+    };
-- 
2.34.1

Re: [PATCH 1/5] dt-bindings: display: mediatek: mdp-rsz: Add rules for MT8196

Posted by CK Hu (胡俊光) 10 months ago

On Tue, 2025-02-11 at 10:52 +0800, Sunny Shen wrote:
> Add MDP-RSZ hardware description for MediaTek MT8196 SoC
> 
> Signed-off-by: Sunny Shen <sunny.shen@mediatek.com>
> ---
>  .../display/mediatek/mediatek,mdp-rsz.yaml    | 46 +++++++++++++++++++
>  1 file changed, 46 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/display/mediatek/mediatek,mdp-rsz.yaml
> 
> diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,mdp-rsz.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,mdp-rsz.yaml
> new file mode 100644
> index 000000000000..6642b9aa651a
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,mdp-rsz.yaml
> @@ -0,0 +1,46 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: https://urldefense.com/v3/__http://devicetree.org/schemas/display/mediatek/mediatek,mdp-rsz.yaml*__;Iw!!CTRNKA9wMg0ARbw!jo9-Ezn5GR8wfDCMX72zrrpxlMEYb-5w52TYinNWsQlfpiPjw5R967JIU0-6WnI5fvIU7-v0IVaRALBlW4aL$ 
> +$schema: https://urldefense.com/v3/__http://devicetree.org/meta-schemas/core.yaml*__;Iw!!CTRNKA9wMg0ARbw!jo9-Ezn5GR8wfDCMX72zrrpxlMEYb-5w52TYinNWsQlfpiPjw5R967JIU0-6WnI5fvIU7-v0IVaRAIIMW8TJ$ 
> +
> +title: MediaTek display multimedia data path resizer
> +
> +maintainers:
> +  - Chun-Kuang Hu <chunkuang.hu@kernel.org>
> +  - Philipp Zabel <p.zabel@pengutronix.de>
> +
> +description: |
> +  MediaTek display multimedia data path resizer, namely MDP-RSZ,
> +  can do scaling up/down to the picture.
> +
> +properties:
> +  compatible:
> +    const: mediatek,mt8196-disp-mdp-rsz

Reference to other display mdp device compatible, use

mediatek,mt8196-mdp-rsz

Regards,
CK

> +
> +  reg:
> +    maxItems: 1
> +
> +  clocks:
> +    items:
> +      - description: MDP-RSZ Clock
> +
> +required:
> +  - compatible
> +  - reg
> +  - clocks
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    soc {
> +        #address-cells = <2>;
> +        #size-cells = <2>;
> +
> +        disp_mdp_rsz0: disp-mdp-rsz0@321a0000 {
> +            compatible = "mediatek,mt8196-disp-mdp-rsz";
> +            reg = <0 0x321a0000 0 0x1000>;
> +            clocks = <&dispsys_config_clk 101>;
> +        };
> +    };

Re: [PATCH 1/5] dt-bindings: display: mediatek: mdp-rsz: Add rules for MT8196

Posted by Sunny Shen (沈姍姍) 9 months, 3 weeks ago

On Mon, 2025-02-17 at 06:01 +0000, CK Hu (胡俊光) wrote:
> On Tue, 2025-02-11 at 10:52 +0800, Sunny Shen wrote:
> > Add MDP-RSZ hardware description for MediaTek MT8196 SoC
> > 
> > Signed-off-by: Sunny Shen <sunny.shen@mediatek.com>
> > ---
> >  .../display/mediatek/mediatek,mdp-rsz.yaml    | 46
> > +++++++++++++++++++
> >  1 file changed, 46 insertions(+)
> >  create mode 100644
> > Documentation/devicetree/bindings/display/mediatek/mediatek,mdp-
> > rsz.yaml
> > 
> > diff --git
> > a/Documentation/devicetree/bindings/display/mediatek/mediatek,mdp-
> > rsz.yaml
> > b/Documentation/devicetree/bindings/display/mediatek/mediatek,mdp-
> > rsz.yaml
> > new file mode 100644
> > index 000000000000..6642b9aa651a
> > --- /dev/null
> > +++
> > b/Documentation/devicetree/bindings/display/mediatek/mediatek,mdp-
> > rsz.yaml
> > @@ -0,0 +1,46 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id:
> > https://urldefense.com/v3/__http://devicetree.org/schemas/display/mediatek/mediatek,mdp-rsz.yaml*__;Iw!!CTRNKA9wMg0ARbw!jo9-Ezn5GR8wfDCMX72zrrpxlMEYb-5w52TYinNWsQlfpiPjw5R967JIU0-6WnI5fvIU7-v0IVaRALBlW4aL$
> >  
> > +$schema:
> > https://urldefense.com/v3/__http://devicetree.org/meta-schemas/core.yaml*__;Iw!!CTRNKA9wMg0ARbw!jo9-Ezn5GR8wfDCMX72zrrpxlMEYb-5w52TYinNWsQlfpiPjw5R967JIU0-6WnI5fvIU7-v0IVaRAIIMW8TJ$
> >  
> > +
> > +title: MediaTek display multimedia data path resizer
> > +
> > +maintainers:
> > +  - Chun-Kuang Hu <chunkuang.hu@kernel.org>
> > +  - Philipp Zabel <p.zabel@pengutronix.de>
> > +
> > +description: |
> > +  MediaTek display multimedia data path resizer, namely MDP-RSZ,
> > +  can do scaling up/down to the picture.
> > +
> > +properties:
> > +  compatible:
> > +    const: mediatek,mt8196-disp-mdp-rsz
> 
> Reference to other display mdp device compatible, use
> 
> mediatek,mt8196-mdp-rsz
> 
> Regards,
> CK

OK, will modify this


> 
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  clocks:
> > +    items:
> > +      - description: MDP-RSZ Clock
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +  - clocks
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > +  - |
> > +    soc {
> > +        #address-cells = <2>;
> > +        #size-cells = <2>;
> > +
> > +        disp_mdp_rsz0: disp-mdp-rsz0@321a0000 {
> > +            compatible = "mediatek,mt8196-disp-mdp-rsz";
> > +            reg = <0 0x321a0000 0 0x1000>;
> > +            clocks = <&dispsys_config_clk 101>;
> > +        };
> > +    };
>

Re: [PATCH 1/5] dt-bindings: display: mediatek: mdp-rsz: Add rules for MT8196

Posted by Conor Dooley 10 months, 1 week ago

On Tue, Feb 11, 2025 at 10:52:50AM +0800, Sunny Shen wrote:
> Add MDP-RSZ hardware description for MediaTek MT8196 SoC
> 
> Signed-off-by: Sunny Shen <sunny.shen@mediatek.com>
> ---
>  .../display/mediatek/mediatek,mdp-rsz.yaml    | 46 +++++++++++++++++++
>  1 file changed, 46 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/display/mediatek/mediatek,mdp-rsz.yaml
> 
> diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,mdp-rsz.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,mdp-rsz.yaml
> new file mode 100644
> index 000000000000..6642b9aa651a
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,mdp-rsz.yaml
> @@ -0,0 +1,46 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/mediatek/mediatek,mdp-rsz.yaml#

Filename matching compatible please

> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: MediaTek display multimedia data path resizer
> +
> +maintainers:
> +  - Chun-Kuang Hu <chunkuang.hu@kernel.org>
> +  - Philipp Zabel <p.zabel@pengutronix.de>
> +
> +description: |
> +  MediaTek display multimedia data path resizer, namely MDP-RSZ,
> +  can do scaling up/down to the picture.
> +
> +properties:
> +  compatible:
> +    const: mediatek,mt8196-disp-mdp-rsz
> +
> +  reg:
> +    maxItems: 1
> +
> +  clocks:
> +    items:
> +      - description: MDP-RSZ Clock

This can just be "maxItems: 1"

> +
> +required:
> +  - compatible
> +  - reg
> +  - clocks
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    soc {
> +        #address-cells = <2>;
> +        #size-cells = <2>;
> +
> +        disp_mdp_rsz0: disp-mdp-rsz0@321a0000 {

And "disp-mdp-rsz0" isn't anything close to a generic node name.

> +            compatible = "mediatek,mt8196-disp-mdp-rsz";
> +            reg = <0 0x321a0000 0 0x1000>;
> +            clocks = <&dispsys_config_clk 101>;

Surprised there are so few properties, no ports link or anything like
that?

> +        };
> +    };
> -- 
> 2.34.1
>

Re: [PATCH 1/5] dt-bindings: display: mediatek: mdp-rsz: Add rules for MT8196

Posted by Sunny Shen (沈姍姍) 9 months, 3 weeks ago

On Tue, 2025-02-11 at 17:54 +0000, Conor Dooley wrote:
> On Tue, Feb 11, 2025 at 10:52:50AM +0800, Sunny Shen wrote:
> > Add MDP-RSZ hardware description for MediaTek MT8196 SoC
> > 
> > Signed-off-by: Sunny Shen <sunny.shen@mediatek.com>
> > ---
> >  .../display/mediatek/mediatek,mdp-rsz.yaml    | 46
> > +++++++++++++++++++
> >  1 file changed, 46 insertions(+)
> >  create mode 100644
> > Documentation/devicetree/bindings/display/mediatek/mediatek,mdp-
> > rsz.yaml
> > 
> > diff --git
> > a/Documentation/devicetree/bindings/display/mediatek/mediatek,mdp-
> > rsz.yaml
> > b/Documentation/devicetree/bindings/display/mediatek/mediatek,mdp-
> > rsz.yaml
> > new file mode 100644
> > index 000000000000..6642b9aa651a
> > --- /dev/null
> > +++
> > b/Documentation/devicetree/bindings/display/mediatek/mediatek,mdp-
> > rsz.yaml
> > @@ -0,0 +1,46 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id:
> > http://devicetree.org/schemas/display/mediatek/mediatek,mdp-rsz.yaml#
> 
> Filename matching compatible please

Got it
will modify the compatible to "mediatek,mt8196-mdp-rsz"

> 
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: MediaTek display multimedia data path resizer
> > +
> > +maintainers:
> > +  - Chun-Kuang Hu <chunkuang.hu@kernel.org>
> > +  - Philipp Zabel <p.zabel@pengutronix.de>
> > +
> > +description: |
> > +  MediaTek display multimedia data path resizer, namely MDP-RSZ,
> > +  can do scaling up/down to the picture.
> > +
> > +properties:
> > +  compatible:
> > +    const: mediatek,mt8196-disp-mdp-rsz
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  clocks:
> > +    items:
> > +      - description: MDP-RSZ Clock
> 
> This can just be "maxItems: 1"

OK, will modify this

> 
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +  - clocks
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > +  - |
> > +    soc {
> > +        #address-cells = <2>;
> > +        #size-cells = <2>;
> > +
> > +        disp_mdp_rsz0: disp-mdp-rsz0@321a0000 {
> 
> And "disp-mdp-rsz0" isn't anything close to a generic node name.

Will modify "disp-mdp-rsz0@321a0000" to "mdp-rsz@321a0000"

> 
> > +            compatible = "mediatek,mt8196-disp-mdp-rsz";
> > +            reg = <0 0x321a0000 0 0x1000>;
> > +            clocks = <&dispsys_config_clk 101>;
> 
> Surprised there are so few properties, no ports link or anything like
> that?

Because the mt8196's path mux design, we use mdp-rsz as a bypass mode
hw.
So only set the basic properties.

> 
> > +        };
> > +    };
> > -- 
> > 2.34.1
> >

Re: [PATCH 1/5] dt-bindings: display: mediatek: mdp-rsz: Add rules for MT8196

Posted by Conor Dooley 9 months, 3 weeks ago

On Sun, Feb 23, 2025 at 05:49:45PM +0000, Sunny Shen (沈姍姍) wrote:
> On Tue, 2025-02-11 at 17:54 +0000, Conor Dooley wrote:
> > On Tue, Feb 11, 2025 at 10:52:50AM +0800, Sunny Shen wrote:
> > > Add MDP-RSZ hardware description for MediaTek MT8196 SoC

> > > +examples:
> > > +  - |
> > > +    soc {
> > > +        #address-cells = <2>;
> > > +        #size-cells = <2>;
> > > +
> > > +        disp_mdp_rsz0: disp-mdp-rsz0@321a0000 {
> > 
> > And "disp-mdp-rsz0" isn't anything close to a generic node name.
> 
> Will modify "disp-mdp-rsz0@321a0000" to "mdp-rsz@321a0000"

I don't think that's an improvement. Hint: full words would be a good
place to start

Re: [PATCH 1/5] dt-bindings: display: mediatek: mdp-rsz: Add rules for MT8196

Posted by Sunny Shen (沈姍姍) 9 months ago

On Mon, 2025-02-24 at 19:01 +0000, Conor Dooley wrote:
> On Sun, Feb 23, 2025 at 05:49:45PM +0000, Sunny Shen (沈姍姍) wrote:
> > On Tue, 2025-02-11 at 17:54 +0000, Conor Dooley wrote:
> > > On Tue, Feb 11, 2025 at 10:52:50AM +0800, Sunny Shen wrote:
> > > > Add MDP-RSZ hardware description for MediaTek MT8196 SoC
> 
> > > > +examples:
> > > > +  - |
> > > > +    soc {
> > > > +        #address-cells = <2>;
> > > > +        #size-cells = <2>;
> > > > +
> > > > +        disp_mdp_rsz0: disp-mdp-rsz0@321a0000 {
> > > 
> > > And "disp-mdp-rsz0" isn't anything close to a generic node name.
> > 
> > Will modify "disp-mdp-rsz0@321a0000" to "mdp-rsz@321a0000"
> 
> I don't think that's an improvement. Hint: full words would be a good
> place to start

 
Hi Conor,

About full words, 
Do you mean words like this? 
multimedia-display-path-resizer?
or mdp-resizer?

We found that "mdp-rsz" this kind of word is used at
https://github.com/torvalds/linux/blob/master/arch/arm64/boot/dts/mediatek/mt8183.dtsi

I'm not sure what will be better.
Can you provide more detailed suggestion about this naming?

Thank you


BR,
Sunny Shen

Re: [PATCH 1/5] dt-bindings: display: mediatek: mdp-rsz: Add rules for MT8196

Posted by Conor Dooley 9 months ago

On Tue, Mar 18, 2025 at 03:14:07AM +0000, Sunny Shen (沈姍姍) wrote:
> On Mon, 2025-02-24 at 19:01 +0000, Conor Dooley wrote:
> > On Sun, Feb 23, 2025 at 05:49:45PM +0000, Sunny Shen (沈姍姍) wrote:
> > > On Tue, 2025-02-11 at 17:54 +0000, Conor Dooley wrote:
> > > > On Tue, Feb 11, 2025 at 10:52:50AM +0800, Sunny Shen wrote:
> > > > > Add MDP-RSZ hardware description for MediaTek MT8196 SoC
> > 
> > > > > +examples:
> > > > > +  - |
> > > > > +    soc {
> > > > > +        #address-cells = <2>;
> > > > > +        #size-cells = <2>;
> > > > > +
> > > > > +        disp_mdp_rsz0: disp-mdp-rsz0@321a0000 {
> > > > 
> > > > And "disp-mdp-rsz0" isn't anything close to a generic node name.
> > > 
> > > Will modify "disp-mdp-rsz0@321a0000" to "mdp-rsz@321a0000"
> > 
> > I don't think that's an improvement. Hint: full words would be a good
> > place to start
> 
>  
> Hi Conor,
> 
> About full words, 
> Do you mean words like this? 
> multimedia-display-path-resizer?
> or mdp-resizer?

These are both improvements on what you've got right now.

> We found that "mdp-rsz" this kind of word is used at
> https://github.com/torvalds/linux/blob/master/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> 
> I'm not sure what will be better.
> Can you provide more detailed suggestion about this naming?

Re: [PATCH 1/5] dt-bindings: display: mediatek: mdp-rsz: Add rules for MT8196

Posted by Sunny Shen (沈姍姍) 9 months ago

On Wed, 2025-03-19 at 20:00 +0000, Conor Dooley wrote:
> On Tue, Mar 18, 2025 at 03:14:07AM +0000, Sunny Shen (沈姍姍) wrote:
> > On Mon, 2025-02-24 at 19:01 +0000, Conor Dooley wrote:
> > > On Sun, Feb 23, 2025 at 05:49:45PM +0000, Sunny Shen (沈姍姍) wrote:
> > > > On Tue, 2025-02-11 at 17:54 +0000, Conor Dooley wrote:
> > > > > On Tue, Feb 11, 2025 at 10:52:50AM +0800, Sunny Shen wrote:
> > > > > > Add MDP-RSZ hardware description for MediaTek MT8196 SoC
> > > 
> > > > > > +examples:
> > > > > > +  - |
> > > > > > +    soc {
> > > > > > +        #address-cells = <2>;
> > > > > > +        #size-cells = <2>;
> > > > > > +
> > > > > > +        disp_mdp_rsz0: disp-mdp-rsz0@321a0000 {
> > > > > 
> > > > > And "disp-mdp-rsz0" isn't anything close to a generic node
> > > > > name.
> > > > 
> > > > Will modify "disp-mdp-rsz0@321a0000" to "mdp-rsz@321a0000"
> > > 
> > > I don't think that's an improvement. Hint: full words would be a
> > > good
> > > place to start
> > 
> >  
> > Hi Conor,
> > 
> > About full words, 
> > Do you mean words like this? 
> > multimedia-display-path-resizer?
> > or mdp-resizer?
> 
> These are both improvements on what you've got right now.

Okay~
I'll use mdp-resizer for this


> 
> > We found that "mdp-rsz" this kind of word is used at
> > https://github.com/torvalds/linux/blob/master/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> > 
> > I'm not sure what will be better.
> > Can you provide more detailed suggestion about this naming?