This enables OTP support in the nvmem driver for rk3576.

I expect to pick the clock patch (patch1) and the arm64-dts patch (patch6)
myself, after the nvmem-driver and -binding patches have been applied
(patches 2-5).

But kept them together for people wanting to try this series.

changes in v2:
- fix register constant in clock definition (Diederik)
- add patch to set limits on variant-specific clock-names
- use correct limits for clocks + resets on rk3576 binding


RESEND, because I messed up my git-send-email which caused it to include
the list of patches 2 times, duplicating everything :-( .

Heiko Stuebner (6):
  clk: rockchip: rk3576: define clk_otp_phy_g
  nvmem: rockchip-otp: Move read-offset into variant-data
  dt-bindings: nvmem: rockchip,otp: add missing limits for clock-names
  dt-bindings: nvmem: rockchip,otp: Add compatible for RK3576
  nvmem: rockchip-otp: add rk3576 variant data
  arm64: dts: rockchip: add rk3576 otp node

 .../bindings/nvmem/rockchip,otp.yaml          | 25 ++++++++++++
 arch/arm64/boot/dts/rockchip/rk3576.dtsi      | 39 +++++++++++++++++++
 drivers/clk/rockchip/clk-rk3576.c             |  2 +
 drivers/nvmem/rockchip-otp.c                  | 17 +++++++-
 4 files changed, 81 insertions(+), 2 deletions(-)

-- 
2.47.2

On Monday, 10 February 2025 23:45:04 Central European Standard Time Heiko 
Stuebner wrote:
> This enables OTP support in the nvmem driver for rk3576.
> 
> I expect to pick the clock patch (patch1) and the arm64-dts patch (patch6)
> myself, after the nvmem-driver and -binding patches have been applied
> (patches 2-5).
> 
> But kept them together for people wanting to try this series.
> 
> changes in v2:
> - fix register constant in clock definition (Diederik)
> - add patch to set limits on variant-specific clock-names
> - use correct limits for clocks + resets on rk3576 binding
> 
> 
> RESEND, because I messed up my git-send-email which caused it to include
> the list of patches 2 times, duplicating everything :-( .
> 
> Heiko Stuebner (6):
>   clk: rockchip: rk3576: define clk_otp_phy_g
>   nvmem: rockchip-otp: Move read-offset into variant-data
>   dt-bindings: nvmem: rockchip,otp: add missing limits for clock-names
>   dt-bindings: nvmem: rockchip,otp: Add compatible for RK3576
>   nvmem: rockchip-otp: add rk3576 variant data
>   arm64: dts: rockchip: add rk3576 otp node
> 
>  .../bindings/nvmem/rockchip,otp.yaml          | 25 ++++++++++++
>  arch/arm64/boot/dts/rockchip/rk3576.dtsi      | 39 +++++++++++++++++++
>  drivers/clk/rockchip/clk-rk3576.c             |  2 +
>  drivers/nvmem/rockchip-otp.c                  | 17 +++++++-
>  4 files changed, 81 insertions(+), 2 deletions(-)

Hi Heiko,

for the entire series:

Tested-by: Nicolas Frattaroli <nicolas.frattaroli@collabora.com>

OTPs show up on my Sige5 RK3576 board and read fine. Also compared the OTP 
nodes to downstream and the values look consistent with that. The OTPs aren't 
documented in the TRM I have, so unfortunately I can't cross-reference that.

NB: patchwork's "Series" download for this series somehow lacks patch 2/6, 
which tripped me up at first. Not sure if that's a problem with patchwork or 
with how you sent the series out, but I thought I'd let others know who run 
into this.

Regards,
Nicolas Frattaroli

Am Mittwoch, 12. Februar 2025, 13:44:15 MEZ schrieb Nicolas Frattaroli:
> On Monday, 10 February 2025 23:45:04 Central European Standard Time Heiko 
> Stuebner wrote:
> > This enables OTP support in the nvmem driver for rk3576.
> > 
> > I expect to pick the clock patch (patch1) and the arm64-dts patch (patch6)
> > myself, after the nvmem-driver and -binding patches have been applied
> > (patches 2-5).
> > 
> > But kept them together for people wanting to try this series.
> > 
> > changes in v2:
> > - fix register constant in clock definition (Diederik)
> > - add patch to set limits on variant-specific clock-names
> > - use correct limits for clocks + resets on rk3576 binding
> > 
> > 
> > RESEND, because I messed up my git-send-email which caused it to include
> > the list of patches 2 times, duplicating everything :-( .
> > 
> > Heiko Stuebner (6):
> >   clk: rockchip: rk3576: define clk_otp_phy_g
> >   nvmem: rockchip-otp: Move read-offset into variant-data
> >   dt-bindings: nvmem: rockchip,otp: add missing limits for clock-names
> >   dt-bindings: nvmem: rockchip,otp: Add compatible for RK3576
> >   nvmem: rockchip-otp: add rk3576 variant data
> >   arm64: dts: rockchip: add rk3576 otp node
> > 
> >  .../bindings/nvmem/rockchip,otp.yaml          | 25 ++++++++++++
> >  arch/arm64/boot/dts/rockchip/rk3576.dtsi      | 39 +++++++++++++++++++
> >  drivers/clk/rockchip/clk-rk3576.c             |  2 +
> >  drivers/nvmem/rockchip-otp.c                  | 17 +++++++-
> >  4 files changed, 81 insertions(+), 2 deletions(-)
> 
> Hi Heiko,
> 
> for the entire series:
> 
> Tested-by: Nicolas Frattaroli <nicolas.frattaroli@collabora.com>
> 
> OTPs show up on my Sige5 RK3576 board and read fine. Also compared the OTP 
> nodes to downstream and the values look consistent with that. The OTPs aren't 
> documented in the TRM I have, so unfortunately I can't cross-reference that.

thanks a lot for the testing :-)

> NB: patchwork's "Series" download for this series somehow lacks patch 2/6, 
> which tripped me up at first. Not sure if that's a problem with patchwork or 
> with how you sent the series out, but I thought I'd let others know who run 
> into this.

It looks like patchwork had a bigger hickup with my series.
Looking at the cover-letter in the Rockchip area of patchwork, it is
missing _all_ patches attached to it [0].

At least on the mainling list, everything seems to have arrived ok [1],
so would assume that's a patchwork thing.


[0] https://patchwork.kernel.org/project/linux-rockchip/cover/20250210224510.1194963-1-heiko@sntech.de/
[1] https://lore.kernel.org/all/20250210224510.1194963-1-heiko@sntech.de/

On Mon, 10 Feb 2025 23:45:04 +0100, Heiko Stuebner wrote:
> This enables OTP support in the nvmem driver for rk3576.
> 
> I expect to pick the clock patch (patch1) and the arm64-dts patch (patch6)
> myself, after the nvmem-driver and -binding patches have been applied
> (patches 2-5).
> 
> But kept them together for people wanting to try this series.
> 
> [...]

Applied, thanks!

[1/6] clk: rockchip: rk3576: define clk_otp_phy_g
      commit: 3e081aa132bbefe31ac95dd6dfc8d787ffa83d0b
[2/6] nvmem: rockchip-otp: Move read-offset into variant-data
      commit: 024e21343f3cbcde0343473fcaf094d2c19cc7bf
[3/6] dt-bindings: nvmem: rockchip,otp: add missing limits for clock-names
      commit: a1bf00100d06ad69286154a63e548ae6f6ce8539
[4/6] dt-bindings: nvmem: rockchip,otp: Add compatible for RK3576
      commit: 8c94337ebbfb840944574f82df0cbe35930d8df8
[5/6] nvmem: rockchip-otp: add rk3576 variant data
      commit: c5ebefe4e20d9fd99ae49cbfd1c18632cf338fa5

Best regards,
-- 
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>

Hi,

Am Montag, 17. Februar 2025, 10:53:16 MEZ schrieb Srinivas Kandagatla:
> 
> On Mon, 10 Feb 2025 23:45:04 +0100, Heiko Stuebner wrote:
> > This enables OTP support in the nvmem driver for rk3576.
> > 
> > I expect to pick the clock patch (patch1) and the arm64-dts patch (patch6)
> > myself, after the nvmem-driver and -binding patches have been applied
> > (patches 2-5).
> > 
> > But kept them together for people wanting to try this series.
> > 
> > [...]
> 
> Applied, thanks!
> 
> [1/6] clk: rockchip: rk3576: define clk_otp_phy_g
>       commit: 3e081aa132bbefe31ac95dd6dfc8d787ffa83d0b

the applied message says you picked the clock patch, but it's not in your
tree - probably because you realized that it's a clock patch? :-)

So just to make sure it doesn't land in two trees, I should probably pick
up the patch for the Rockchip clock driver, right?


Thanks a lot
Heiko


> [2/6] nvmem: rockchip-otp: Move read-offset into variant-data
>       commit: 024e21343f3cbcde0343473fcaf094d2c19cc7bf
> [3/6] dt-bindings: nvmem: rockchip,otp: add missing limits for clock-names
>       commit: a1bf00100d06ad69286154a63e548ae6f6ce8539
> [4/6] dt-bindings: nvmem: rockchip,otp: Add compatible for RK3576
>       commit: 8c94337ebbfb840944574f82df0cbe35930d8df8
> [5/6] nvmem: rockchip-otp: add rk3576 variant data
>       commit: c5ebefe4e20d9fd99ae49cbfd1c18632cf338fa5
> 
> Best regards,
>

On Mon, 10 Feb 2025 23:45:04 +0100, Heiko Stuebner wrote:
> This enables OTP support in the nvmem driver for rk3576.
> 
> I expect to pick the clock patch (patch1) and the arm64-dts patch (patch6)
> myself, after the nvmem-driver and -binding patches have been applied
> (patches 2-5).
> 
> But kept them together for people wanting to try this series.
> 
> [...]

Applied, thanks!

[6/6] arm64: dts: rockchip: add rk3576 otp node

Best regards,
-- 
Heiko Stuebner <heiko@sntech.de>

On Mon, 10 Feb 2025 23:45:04 +0100, Heiko Stuebner wrote:
> This enables OTP support in the nvmem driver for rk3576.
> 
> I expect to pick the clock patch (patch1) and the arm64-dts patch (patch6)
> myself, after the nvmem-driver and -binding patches have been applied
> (patches 2-5).
> 
> But kept them together for people wanting to try this series.
> 
> [...]

Applied, thanks!

[1/6] clk: rockchip: rk3576: define clk_otp_phy_g
      commit: d934a93bbcccd551c142206b8129903d18126261

While the original nvmem applied message [0] listed the clock patch,
it was in fact not applied there - probable for being a clock patch.

So I've done that now, hopefully as fix for 6.15 to make the
nvmem work in this timeframe.


[0] https://lore.kernel.org/linux-arm-kernel/173978599692.25901.15315285566342669137.b4-ty@linaro.org/

Best regards,
-- 
Heiko Stuebner <heiko@sntech.de>