[v4] Fix and extend cpu.stat

[PATCH v4 0/2] Fix and extend cpu.stat

Posted by Abel Wu 10 months, 1 week ago

Patch 1: fixes an issue that forceidle time can be inconsistant with
other cputimes.
Patch 2: extend run_delay accounting to cgroup to show how severely
a cgroup is stalled.

v4:
 - Fixed a Kconfig dependency issue. (0day robot)
v3:
 - Dropped the cleanup patch. (Tejun)
 - Modified 2nd patch's commit log.
v2:
 - Fixed internal function naming. (Michal Koutny)

Abel Wu (2):
  cgroup/rstat: Fix forceidle time in cpu.stat
  cgroup/rstat: Add run_delay accounting for cgroups

 include/linux/cgroup-defs.h |  3 +++
 include/linux/kernel_stat.h |  7 +++++
 kernel/cgroup/rstat.c       | 54 ++++++++++++++++++++++++++-----------
 kernel/sched/cputime.c      | 10 +++++++
 kernel/sched/stats.h        |  3 +++
 5 files changed, 61 insertions(+), 16 deletions(-)

-- 
2.37.3

Re: [PATCH v4 0/2] Fix and extend cpu.stat

Posted by Michal Koutný 9 months, 3 weeks ago

On Sun, Feb 09, 2025 at 02:13:10PM +0800, Abel Wu <wuyun.abel@bytedance.com> wrote:
> v4:
>  - Fixed a Kconfig dependency issue. (0day robot)
> v3:
>  - Dropped the cleanup patch. (Tejun)
>  - Modified 2nd patch's commit log.

But the modification isn't the usage examples that Johannes asked about?

Also as I'm unsure about some plain PSI values (posted to v2). Maybe
it'd be good if you could accompany the Σrun_delay with some examples
showing what different values tell about workload.

Thanks,
Michal

Re: [PATCH v4 0/2] Fix and extend cpu.stat

Posted by Abel Wu 9 months, 3 weeks ago

On 2/21/25 11:41 PM, Michal Koutný wrote:
> On Sun, Feb 09, 2025 at 02:13:10PM +0800, Abel Wu <wuyun.abel@bytedance.com> wrote:
>> v4:
>>   - Fixed a Kconfig dependency issue. (0day robot)
>> v3:
>>   - Dropped the cleanup patch. (Tejun)
>>   - Modified 2nd patch's commit log.
> 
> But the modification isn't the usage examples that Johannes asked about?
> 
> Also as I'm unsure about some plain PSI values (posted to v2). Maybe
> it'd be good if you could accompany the Σrun_delay with some examples
> showing what different values tell about workload.

Hi Michal, sorry for replying so late!

I am going to drop this patch for now, and will restart once found any
solid case. Thanks for your (& Tejun's & Johannes's) sightful and helpful
comments!

Best Regards,
	Abel