[PATCH] dt-bindings: serial: Allow fsl,ns16550 with broken FIFOs

J. Neuschäfer via B4 Relay posted 1 patch 12 months ago
Documentation/devicetree/bindings/serial/8250.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] dt-bindings: serial: Allow fsl,ns16550 with broken FIFOs
Posted by J. Neuschäfer via B4 Relay 12 months ago
From: "J. Neuschäfer" <j.ne@posteo.net>

While testing on a Freescale MPC8314E board, I noticed that changing
the UART compatible string from ns16550 to ns16550a breaks the output,
suggesting that the FIFOs don't work correctly. To accommodate this
fact, move the definition of fsl,ns16550 to the section of 8250.yaml
that allows broken FIFOs.

Signed-off-by: J. Neuschäfer <j.ne@posteo.net>
---
 Documentation/devicetree/bindings/serial/8250.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/serial/8250.yaml b/Documentation/devicetree/bindings/serial/8250.yaml
index 0bde2379e864749a20a2e1c962103bf8f5299e42..dc0d52920575ff851a24e56b808e50ee3a14743b 100644
--- a/Documentation/devicetree/bindings/serial/8250.yaml
+++ b/Documentation/devicetree/bindings/serial/8250.yaml
@@ -77,7 +77,6 @@ properties:
               - altr,16550-FIFO64
               - altr,16550-FIFO128
               - fsl,16550-FIFO64
-              - fsl,ns16550
               - andestech,uart16550
               - nxp,lpc1850-uart
               - opencores,uart16550-rtlsvn105
@@ -86,6 +85,7 @@ properties:
       - items:
           - enum:
               - ns16750
+              - fsl,ns16550
               - cavium,octeon-3860-uart
               - xlnx,xps-uart16550-2.00.b
               - ralink,rt2880-uart

---
base-commit: b142aa50047767e0ab2739102e913fff8207cae1
change-id: 20250209-uartfifo-57ba68a86d5a

Best regards,
-- 
J. Neuschäfer <j.ne@posteo.net>


Re: [PATCH] dt-bindings: serial: Allow fsl,ns16550 with broken FIFOs
Posted by Conor Dooley 12 months ago
On Sun, Feb 09, 2025 at 11:13:40PM +0100, J. Neuschäfer via B4 Relay wrote:
> From: "J. Neuschäfer" <j.ne@posteo.net>
> 
> While testing on a Freescale MPC8314E board, I noticed that changing
> the UART compatible string from ns16550 to ns16550a breaks the output,
> suggesting that the FIFOs don't work correctly. To accommodate this
> fact, move the definition of fsl,ns16550 to the section of 8250.yaml
> that allows broken FIFOs.
> 
> Signed-off-by: J. Neuschäfer <j.ne@posteo.net>

Acked-by: Conor Dooley <conor.dooley@microchip.com>