[PATCH] PM / devfreq: Fix a typo in trans_stat

pleasurefish@126.com posted 1 patch 12 months ago
drivers/devfreq/devfreq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] PM / devfreq: Fix a typo in trans_stat
Posted by pleasurefish@126.com 12 months ago
From: pls <pleasurefish@126.com>

Fixes: 4920ee6dcfaf ("PM / devfreq: Convert to use sysfs_emit_at() API")
Signed-off-by: pls <pleasurefish@126.com>
---
 drivers/devfreq/devfreq.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
index 98657d3b9435..a0223c60f4eb 100644
--- a/drivers/devfreq/devfreq.c
+++ b/drivers/devfreq/devfreq.c
@@ -1743,7 +1743,7 @@ static ssize_t trans_stat_show(struct device *dev,
 	for (i = 0; i < max_state; i++) {
 		if (len >= PAGE_SIZE - 1)
 			break;
-		if (df->freq_table[2] == df->previous_freq)
+		if (df->freq_table[i] == df->previous_freq)
 			len += sysfs_emit_at(buf, len, "*");
 		else
 			len += sysfs_emit_at(buf, len, " ");
-- 
2.39.5
Re: [PATCH] PM / devfreq: Fix a typo in trans_stat
Posted by Chanwoo Choi 9 months ago
Hi,

Looks good to me for this patch.

But, you need to use your name instead of 'pls' on following
Signed-off-by and author information.
I would like you to update your name on this patch and then better to
add the some patch description

- Signed-off-by: pls <pleasurefish@126.com>

Thanks,

On Sat, Feb 8, 2025 at 11:29 AM <pleasurefish@126.com> wrote:
>
> From: pls <pleasurefish@126.com>
>
> Fixes: 4920ee6dcfaf ("PM / devfreq: Convert to use sysfs_emit_at() API")
> Signed-off-by: pls <pleasurefish@126.com>
> ---
>  drivers/devfreq/devfreq.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
> index 98657d3b9435..a0223c60f4eb 100644
> --- a/drivers/devfreq/devfreq.c
> +++ b/drivers/devfreq/devfreq.c
> @@ -1743,7 +1743,7 @@ static ssize_t trans_stat_show(struct device *dev,
>         for (i = 0; i < max_state; i++) {
>                 if (len >= PAGE_SIZE - 1)
>                         break;
> -               if (df->freq_table[2] == df->previous_freq)
> +               if (df->freq_table[i] == df->previous_freq)
>                         len += sysfs_emit_at(buf, len, "*");
>                 else
>                         len += sysfs_emit_at(buf, len, " ");
> --
> 2.39.5
>
>


-- 
Best Regards,
Chanwoo Choi
Samsung Electronics