The variable secretmem_enable is initialized with 1, which is an integer.
It would be more appropriate to use true for better readability and
consistency with the bool type.

Signed-off-by: Liu Ye <liuye@kylinos.cn>
---
 mm/secretmem.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/secretmem.c b/mm/secretmem.c
index 1b0a214ee558..2f9442d6633d 100644
--- a/mm/secretmem.c
+++ b/mm/secretmem.c
@@ -35,7 +35,7 @@
 #define SECRETMEM_MODE_MASK	(0x0)
 #define SECRETMEM_FLAGS_MASK	SECRETMEM_MODE_MASK
 
-static bool secretmem_enable __ro_after_init = 1;
+static bool secretmem_enable __ro_after_init = true;
 module_param_named(enable, secretmem_enable, bool, 0400);
 MODULE_PARM_DESC(secretmem_enable,
 		 "Enable secretmem and memfd_secret(2) system call");
-- 
2.25.1

On 07/02/25 1:12 pm, Liu Ye wrote:
> The variable secretmem_enable is initialized with 1, which is an integer.
> It would be more appropriate to use true for better readability and

At the cost of messing up the git log. Please don't send trivial 
cosmetic changes.

> consistency with the bool type.
> 
> Signed-off-by: Liu Ye <liuye@kylinos.cn>
> ---
>   mm/secretmem.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/secretmem.c b/mm/secretmem.c
> index 1b0a214ee558..2f9442d6633d 100644
> --- a/mm/secretmem.c
> +++ b/mm/secretmem.c
> @@ -35,7 +35,7 @@
>   #define SECRETMEM_MODE_MASK	(0x0)
>   #define SECRETMEM_FLAGS_MASK	SECRETMEM_MODE_MASK
>   
> -static bool secretmem_enable __ro_after_init = 1;
> +static bool secretmem_enable __ro_after_init = true;
>   module_param_named(enable, secretmem_enable, bool, 0400);
>   MODULE_PARM_DESC(secretmem_enable,
>   		 "Enable secretmem and memfd_secret(2) system call");