Document devicetree bindings for Andes I2C controller.
Signed-off-by: Ben Zong-You Xie <ben717@andestech.com>
---
.../bindings/i2c/andestech,i2c-atciic100.yaml | 40 +++++++++++++++++++
MAINTAINERS | 5 +++
2 files changed, 45 insertions(+)
create mode 100644 Documentation/devicetree/bindings/i2c/andestech,i2c-atciic100.yaml
diff --git a/Documentation/devicetree/bindings/i2c/andestech,i2c-atciic100.yaml b/Documentation/devicetree/bindings/i2c/andestech,i2c-atciic100.yaml
new file mode 100644
index 000000000000..cf96a9186176
--- /dev/null
+++ b/Documentation/devicetree/bindings/i2c/andestech,i2c-atciic100.yaml
@@ -0,0 +1,40 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/pwm/andestech,atciic100.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Andes I2C Controller
+
+maintainers:
+ - Ben Zong-You Xie <ben717@andestech.com>
+
+allOf:
+ - $ref: /schemas/i2c/i2c-controller.yaml#
+
+properties:
+ compatible:
+ const: andestech,atciic100
+
+ reg:
+ maxItems: 1
+
+ interrupts:
+ maxItems: 1
+
+required:
+ - compatible
+ - reg
+ - interrupts
+
+unevaluatedProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/interrupt-controller/irq.h>
+
+ i2c@f0a00000 {
+ compatible = "andestech,atciic100";
+ reg = <0xf0a00000 0x1000>;
+ interrupts = <6 IRQ_TYPE_LEVEL_HIGH>;
+ };
diff --git a/MAINTAINERS b/MAINTAINERS
index 896a307fa065..544251a03c7d 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1635,6 +1635,11 @@ S: Supported
F: drivers/clk/analogbits/*
F: include/linux/clk/analogbits*
+ANDES TECHNOLOGY I2C DRIVER
+M: Ben Zong-You Xie <ben717@andestech.com>
+S: Supported
+F: Documentation/devicetree/bindings/i2c/andestech,atciic100.yaml
+
ANDROID DRIVERS
M: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
M: Arve Hjønnevåg <arve@android.com>
--
2.34.1
On Fri, Feb 07, 2025 at 10:19:22AM +0800, Ben Zong-You Xie wrote: > Document devicetree bindings for Andes I2C controller. Explain what is the hardware... Here is Andes I2C > > Signed-off-by: Ben Zong-You Xie <ben717@andestech.com> > --- > .../bindings/i2c/andestech,i2c-atciic100.yaml | 40 +++++++++++++++++++ > MAINTAINERS | 5 +++ > 2 files changed, 45 insertions(+) > create mode 100644 Documentation/devicetree/bindings/i2c/andestech,i2c-atciic100.yaml > > diff --git a/Documentation/devicetree/bindings/i2c/andestech,i2c-atciic100.yaml b/Documentation/devicetree/bindings/i2c/andestech,i2c-atciic100.yaml > new file mode 100644 > index 000000000000..cf96a9186176 > --- /dev/null > +++ b/Documentation/devicetree/bindings/i2c/andestech,i2c-atciic100.yaml > @@ -0,0 +1,40 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/pwm/andestech,atciic100.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Andes I2C Controller Here as well > + > +maintainers: > + - Ben Zong-You Xie <ben717@andestech.com> > + > +allOf: > + - $ref: /schemas/i2c/i2c-controller.yaml# > + > +properties: > + compatible: > + const: andestech,atciic100 But here atciic100. This is all confusing. What is the SoC? What is the name of this device? Best regards, Krzysztof
On Sun, Feb 09, 2025 at 01:29:58PM +0100, Krzysztof Kozlowski wrote:
> On Fri, Feb 07, 2025 at 10:19:22AM +0800, Ben Zong-You Xie wrote:
> > Document devicetree bindings for Andes I2C controller.
>
> Explain what is the hardware... Here is Andes I2C
>
> >
> > Signed-off-by: Ben Zong-You Xie <ben717@andestech.com>
> > ---
> > .../bindings/i2c/andestech,i2c-atciic100.yaml | 40 +++++++++++++++++++
> > MAINTAINERS | 5 +++
> > 2 files changed, 45 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/i2c/andestech,i2c-atciic100.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/i2c/andestech,i2c-atciic100.yaml b/Documentation/devicetree/bindings/i2c/andestech,i2c-atciic100.yaml
> > new file mode 100644
> > index 000000000000..cf96a9186176
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/i2c/andestech,i2c-atciic100.yaml
> > @@ -0,0 +1,40 @@
> > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/pwm/andestech,atciic100.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Andes I2C Controller
>
> Here as well
>
> > +
> > +maintainers:
> > + - Ben Zong-You Xie <ben717@andestech.com>
> > +
> > +allOf:
> > + - $ref: /schemas/i2c/i2c-controller.yaml#
> > +
> > +properties:
> > + compatible:
> > + const: andestech,atciic100
>
> But here atciic100. This is all confusing. What is the SoC? What is the
> name of this device?
Hi Krzysztof,
Sorry for the confusion. atciic100 is the name for the I2C IP block, and it
is integrated on QiLai SoC. That's why I added a new compatible
"andestech,qilai-i2c" in v2.
For AE350 platform, I know it has not been upstreamed yet, but it was
discussed and acknowledged in a separate SPI series [1], which is why I
included it as a fallback. Can I keep this? If not, I will drop it
and update the compatibles in v3 as follows:
properties:
compatible:
const: andestech,qilai-i2c
[1] https://lore.kernel.org/linux-spi/20251210-repeated-perjurer-99219893524a@spud/
Thanks,
Ben
On 22/01/2026 12:18, Ben Zong-You Xie wrote: > On Sun, Feb 09, 2025 at 01:29:58PM +0100, Krzysztof Kozlowski wrote: >> On Fri, Feb 07, 2025 at 10:19:22AM +0800, Ben Zong-You Xie wrote: >>> Document devicetree bindings for Andes I2C controller. >> >> Explain what is the hardware... Here is Andes I2C >> >>> >>> Signed-off-by: Ben Zong-You Xie <ben717@andestech.com> >>> --- >>> .../bindings/i2c/andestech,i2c-atciic100.yaml | 40 +++++++++++++++++++ >>> MAINTAINERS | 5 +++ >>> 2 files changed, 45 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/i2c/andestech,i2c-atciic100.yaml >>> >>> diff --git a/Documentation/devicetree/bindings/i2c/andestech,i2c-atciic100.yaml b/Documentation/devicetree/bindings/i2c/andestech,i2c-atciic100.yaml >>> new file mode 100644 >>> index 000000000000..cf96a9186176 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/i2c/andestech,i2c-atciic100.yaml >>> @@ -0,0 +1,40 @@ >>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) >>> +%YAML 1.2 >>> +--- >>> +$id: http://devicetree.org/schemas/pwm/andestech,atciic100.yaml# >>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>> + >>> +title: Andes I2C Controller >> >> Here as well >> >>> + >>> +maintainers: >>> + - Ben Zong-You Xie <ben717@andestech.com> >>> + >>> +allOf: >>> + - $ref: /schemas/i2c/i2c-controller.yaml# >>> + >>> +properties: >>> + compatible: >>> + const: andestech,atciic100 >> >> But here atciic100. This is all confusing. What is the SoC? What is the >> name of this device? > > Hi Krzysztof, > > Sorry for the confusion. atciic100 is the name for the I2C IP block, and it > is integrated on QiLai SoC. That's why I added a new compatible > "andestech,qilai-i2c" in v2. So atciic100 is not an SoC... but then why there is I2C and SPI variant? Is this some serial engine? Because if it is, you probably miss here much more bindings for complete hardware description. Plus, if this is IP block, how can it be used alone? We forbid that sort of compatibles long time ago. Anyway you have entire commit msg to explain that. > > For AE350 platform, I know it has not been upstreamed yet, but it was > discussed and acknowledged in a separate SPI series [1], which is why I I see ae350-spi there, not atciic100. > included it as a fallback. Can I keep this? If not, I will drop it > and update the compatibles in v3 as follows: Nothing was explained in the commit msg, so with all this being confusing that's the review you got. You literally wrote one half baked sentence being copy of subject, so like nothing relevant and should be treated as almost empty commit msg. How do you expect us to understand anything from that if you write NOTHING in the commit msg (except copying subject)? Best regards, Krzysztof
On Thu, Jan 22, 2026 at 12:27:00PM +0100, Krzysztof Kozlowski wrote: > [EXTERNAL MAIL] > > On 22/01/2026 12:18, Ben Zong-You Xie wrote: > > On Sun, Feb 09, 2025 at 01:29:58PM +0100, Krzysztof Kozlowski wrote: > >> On Fri, Feb 07, 2025 at 10:19:22AM +0800, Ben Zong-You Xie wrote: > >>> Document devicetree bindings for Andes I2C controller. > >> > >> Explain what is the hardware... Here is Andes I2C > >> > >>> > >>> Signed-off-by: Ben Zong-You Xie <ben717@andestech.com> > >>> --- > >>> .../bindings/i2c/andestech,i2c-atciic100.yaml | 40 +++++++++++++++++++ > >>> MAINTAINERS | 5 +++ > >>> 2 files changed, 45 insertions(+) > >>> create mode 100644 Documentation/devicetree/bindings/i2c/andestech,i2c-atciic100.yaml > >>> > >>> diff --git a/Documentation/devicetree/bindings/i2c/andestech,i2c-atciic100.yaml b/Documentation/devicetree/bindings/i2c/andestech,i2c-atciic100.yaml > >>> new file mode 100644 > >>> index 000000000000..cf96a9186176 > >>> --- /dev/null > >>> +++ b/Documentation/devicetree/bindings/i2c/andestech,i2c-atciic100.yaml > >>> @@ -0,0 +1,40 @@ > >>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > >>> +%YAML 1.2 > >>> +--- > >>> +$id: http://devicetree.org/schemas/pwm/andestech,atciic100.yaml# > >>> +$schema: http://devicetree.org/meta-schemas/core.yaml# > >>> + > >>> +title: Andes I2C Controller > >> > >> Here as well > >> > >>> + > >>> +maintainers: > >>> + - Ben Zong-You Xie <ben717@andestech.com> > >>> + > >>> +allOf: > >>> + - $ref: /schemas/i2c/i2c-controller.yaml# > >>> + > >>> +properties: > >>> + compatible: > >>> + const: andestech,atciic100 > >> > >> But here atciic100. This is all confusing. What is the SoC? What is the > >> name of this device? > > > > Hi Krzysztof, > > > > Sorry for the confusion. atciic100 is the name for the I2C IP block, and it > > is integrated on QiLai SoC. That's why I added a new compatible > > "andestech,qilai-i2c" in v2. > > So atciic100 is not an SoC... but then why there is I2C and SPI variant? > Is this some serial engine? Because if it is, you probably miss here > much more bindings for complete hardware description. > There is no variant for atciic100. It's a dedicated I2C controller IP. > Plus, if this is IP block, how can it be used alone? We forbid that sort > of compatibles long time ago. > I made the mistake you mentioned above in v1. But after your review, I know the compatibles in the bindings should be <soc/platform>-<device>. Thus, I have removed "andestech,atciic100" in v2, and have used "andestech,qilai-i2c" and "andestech,ae350-i2c" instead. Also, I have removed all the occurrences of atciic100 in v2 to avoid the confusion. v2: https://lore.kernel.org/linux-i2c/20260122-atciic100-v2-0-7559136d07cf@andestech.com/ > Anyway you have entire commit msg to explain that. > > > > > For AE350 platform, I know it has not been upstreamed yet, but it was > > discussed and acknowledged in a separate SPI series [1], which is why I > > I see ae350-spi there, not atciic100. > The reason I mentioned the SPI series is I want to add "ae350-i2c" in this binding, like "ae350-spi" in the SPI series. Again, could I keep the compatible "ae350-i2c" as the fallback compatible in this binding? If not, there will be only one compatible "andestech,qilai-i2c" in the next version. > > included it as a fallback. Can I keep this? If not, I will drop it > > and update the compatibles in v3 as follows: > > Nothing was explained in the commit msg, so with all this being > confusing that's the review you got. You literally wrote one half baked > sentence being copy of subject, so like nothing relevant and should be > treated as almost empty commit msg. > > How do you expect us to understand anything from that if you write > NOTHING in the commit msg (except copying subject)? > I apologize for the lack of detail, and thank you for your patience. Thanks, Ben
On Fri, 07 Feb 2025 10:19:22 +0800, Ben Zong-You Xie wrote: > Document devicetree bindings for Andes I2C controller. > > Signed-off-by: Ben Zong-You Xie <ben717@andestech.com> > --- > .../bindings/i2c/andestech,i2c-atciic100.yaml | 40 +++++++++++++++++++ > MAINTAINERS | 5 +++ > 2 files changed, 45 insertions(+) > create mode 100644 Documentation/devicetree/bindings/i2c/andestech,i2c-atciic100.yaml > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/i2c/andestech,i2c-atciic100.yaml: $id: Cannot determine base path from $id, relative path/filename doesn't match actual path or filename $id: http://devicetree.org/schemas/pwm/andestech,atciic100.yaml file: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/i2c/andestech,i2c-atciic100.yaml doc reference errors (make refcheckdocs): Warning: MAINTAINERS references a file that doesn't exist: Documentation/devicetree/bindings/i2c/andestech,atciic100.yaml MAINTAINERS: Documentation/devicetree/bindings/i2c/andestech,atciic100.yaml See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250207021923.2912373-2-ben717@andestech.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On Thu, Feb 06, 2025 at 09:23:44PM -0600, Rob Herring (Arm) wrote: > [EXTERNAL MAIL] > > On Fri, 07 Feb 2025 10:19:22 +0800, Ben Zong-You Xie wrote: > > Document devicetree bindings for Andes I2C controller. > > > > Signed-off-by: Ben Zong-You Xie <ben717@andestech.com> > > --- > > .../bindings/i2c/andestech,i2c-atciic100.yaml | 40 +++++++++++++++++++ > > MAINTAINERS | 5 +++ > > 2 files changed, 45 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/i2c/andestech,i2c-atciic100.yaml > > > > My bot found errors running 'make dt_binding_check' on your patch: > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/i2c/andestech,i2c-atciic100.yaml: $id: Cannot determine base path from $id, relative path/filename doesn't match actual path or filename > $id: http://devicetree.org/schemas/pwm/andestech,atciic100.yaml > file: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/i2c/andestech,i2c-atciic100.yaml > > doc reference errors (make refcheckdocs): > Warning: MAINTAINERS references a file that doesn't exist: Documentation/devicetree/bindings/i2c/andestech,atciic100.yaml > MAINTAINERS: Documentation/devicetree/bindings/i2c/andestech,atciic100.yaml > > See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250207021923.2912373-2-ben717@andestech.com > > The base for the series is generally the latest rc1. A different dependency > should be noted in *this* patch. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit after running the above command yourself. Note > that DT_SCHEMA_FILES can be set to your schema file to speed up checking > your schema. However, it must be unset to test all examples with your schema. > Hi Rob, Thanks for your reminder. I found there are some errors in the YAML file and MAINTAINERS file for my patch. I will fix them and check with 'make dt_binding_check' before sending new patches. Best regards, Ben
© 2016 - 2026 Red Hat, Inc.