[v1] rust: macros: fix `make rusttest` build on macOS

[PATCH 0/2] rust: macros: fix `make rusttest` build on macOS

Posted by Tamir Duberstein 1 year ago

Signed-off-by: Tamir Duberstein <tamird@gmail.com>
---
Tamir Duberstein (2):
      rust: macros: improve panic messages
      rust: macros: fix `make rusttest` build on macOS

 rust/macros/module.rs | 23 ++++++++++++-----------
 1 file changed, 12 insertions(+), 11 deletions(-)
---
base-commit: beeb78d46249cab8b2b8359a2ce8fa5376b5ad2d
change-id: 20250207-macros-section-f7cddc7bbdea

Best regards,
-- 
Tamir Duberstein <tamird@gmail.com>

Re: [PATCH 0/2] rust: macros: fix `make rusttest` build on macOS

Posted by Greg KH 1 year ago

On Fri, Feb 07, 2025 at 12:21:51PM -0500, Tamir Duberstein wrote:
> Signed-off-by: Tamir Duberstein <tamird@gmail.com>
> ---
> Tamir Duberstein (2):
>       rust: macros: improve panic messages
>       rust: macros: fix `make rusttest` build on macOS

Very minor nit, patch 0/X does not need a signed-off-by, and if you find
that you don't need any text for patch 0/X, there's no need to send a
patch 0/X at all!

Hopet this helps for future submissions.

thanks,

greg k-h

Re: [PATCH 0/2] rust: macros: fix `make rusttest` build on macOS

Posted by Tamir Duberstein 1 year ago

On Sat, Feb 8, 2025 at 3:17 AM Greg KH <gregkh@linuxfoundation.org> wrote:
>
> On Fri, Feb 07, 2025 at 12:21:51PM -0500, Tamir Duberstein wrote:
> > Signed-off-by: Tamir Duberstein <tamird@gmail.com>
> > ---
> > Tamir Duberstein (2):
> >       rust: macros: improve panic messages
> >       rust: macros: fix `make rusttest` build on macOS
>
> Very minor nit, patch 0/X does not need a signed-off-by, and if you find
> that you don't need any text for patch 0/X, there's no need to send a
> patch 0/X at all!
>
> Hopet this helps for future submissions.
>
> thanks,
>
> greg k-h

Thanks Greg. This was me holding b4 wrong :(
Tamir