[PATCH 6.13 000/623] 6.13.2-rc1 review

Theodore Grey posted 623 patches 10 months, 1 week ago
Only 0 patches received!
[PATCH 6.13 000/623] 6.13.2-rc1 review
Posted by Theodore Grey 10 months, 1 week ago
Regressions on the arm64, builds failed with gcc-8 on Linux stable-rc 6.13.2-rc1
But the gcc-13 and clang builds pass.

This was also reported on Linus tree a few weeks back [1] and also seen on
the stable-rc 6.12.13-rc1.

Build regression: arm64, gcc-8 phy-fsl-samsung-hdmi.c __compiletime_assert_537

Good: v6.13 (v6.13-26-g65a3016a79e2)
Bad:  6.13.2-rc1 (v6.13-652-g32cbb2e169ed)

Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>

* arm64:
   build:
    * gcc-8-defconfig
    * gcc-8-defconfig-40bc7ee5
    * gcc-8-lkftconfig-hardening

## Build log
In function 'fsl_samsung_hdmi_phy_configure_pll_lock_det.isra.10',
    inlined from 'fsl_samsung_hdmi_phy_configure' at
drivers/phy/freescale/phy-fsl-samsung-hdmi.c:466:2:
include/linux/compiler_types.h:542:38: error: call to
'__compiletime_assert_537' declared with attribute error: FIELD_PREP:
value too large for the field
  _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
                                      ^
include/linux/compiler_types.h:523:4: note: in definition of macro
'__compiletime_assert'
    prefix ## suffix();    \
    ^~~~~~
include/linux/compiler_types.h:542:2: note: in expansion of macro
'_compiletime_assert'
  _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
  ^~~~~~~~~~~~~~~~~~~
include/linux/build_bug.h:39:37: note: in expansion of macro
'compiletime_assert'
 #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg)
                                     ^~~~~~~~~~~~~~~~~~
include/linux/bitfield.h:68:3: note: in expansion of macro 'BUILD_BUG_ON_MSG'
   BUILD_BUG_ON_MSG(__builtin_constant_p(_val) ?  \
   ^~~~~~~~~~~~~~~~
include/linux/bitfield.h:115:3: note: in expansion of macro '__BF_FIELD_CHECK'
   __BF_FIELD_CHECK(_mask, 0ULL, _val, "FIELD_PREP: "); \
   ^~~~~~~~~~~~~~~~
drivers/phy/freescale/phy-fsl-samsung-hdmi.c:344:9: note: in expansion
of macro 'FIELD_PREP'
  writeb(FIELD_PREP(REG12_CK_DIV_MASK, div), phy->regs + PHY_REG(12));
         ^~~~~~~~~~
make[6]: *** [scripts/Makefile.build:196:
drivers/phy/freescale/phy-fsl-samsung-hdmi.o] Error 1

## Source
* kernel version: 6.13.2-rc1
* git tree: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
* git sha: 32cbb2e169ed556d3d60e8ea56a138cef824a28a
* git describe: v6.13-652-g32cbb2e169ed
* project details: https://qa-reports.linaro.org/lkft/linux-stable-rc-linux-6.13.y/build/v6.13-652-g32cbb2e169ed

## Build
* build log: https://qa-reports.linaro.org/lkft/linux-stable-rc-linux-6.13.y/build/v6.13-652-g32cbb2e169ed/testrun/27199349/suite/build/test/gcc-8-defconfig/log
* build history: https://qa-reports.linaro.org/lkft/linux-stable-rc-linux-6.13.y/build/v6.13-652-g32cbb2e169ed/testrun/27199349/suite/build/test/gcc-8-defconfig/history/
* test details: https://qa-reports.linaro.org/lkft/linux-stable-rc-linux-6.13.y/build/v6.13-652-g32cbb2e169ed/testrun/27199349/suite/build/test/gcc-8-defconfig/
* kernel config: https://storage.tuxsuite.com/public/linaro/lkft/builds/2scp7tWHD0J3Iyj4KIMuqDUMKSF/config
* architectures: arm64
* toolchain version: gcc-8

## Steps to reproduce
- tuxmake --runtime podman --target-arch arm64 --toolchain gcc-8 --kconfig defconfig

Links:
 [1] https://lore.kernel.org/all/CA+G9fYsHGrgZsEEVvP0XMcAhLyCYnrCPgZJ1puT6cfQBCGUB9g@mail.gmail.com/

--
Linaro LKFT
https://lkft.linaro.org
Re: [PATCH 6.13 000/623] 6.13.2-rc1 review
Posted by Greg KH 10 months, 1 week ago
On Thu, Feb 06, 2025 at 12:37:21PM +0100, Theodore Grey wrote:
> Regressions on the arm64, builds failed with gcc-8 on Linux stable-rc 6.13.2-rc1
> But the gcc-13 and clang builds pass.
> 
> This was also reported on Linus tree a few weeks back [1] and also seen on
> the stable-rc 6.12.13-rc1.
> 
> Build regression: arm64, gcc-8 phy-fsl-samsung-hdmi.c __compiletime_assert_537
> 
> Good: v6.13 (v6.13-26-g65a3016a79e2)
> Bad:  6.13.2-rc1 (v6.13-652-g32cbb2e169ed)
> 
> Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
> 
> * arm64:
>    build:
>     * gcc-8-defconfig
>     * gcc-8-defconfig-40bc7ee5
>     * gcc-8-lkftconfig-hardening
> 
> ## Build log
> In function 'fsl_samsung_hdmi_phy_configure_pll_lock_det.isra.10',
>     inlined from 'fsl_samsung_hdmi_phy_configure' at
> drivers/phy/freescale/phy-fsl-samsung-hdmi.c:466:2:
> include/linux/compiler_types.h:542:38: error: call to
> '__compiletime_assert_537' declared with attribute error: FIELD_PREP:
> value too large for the field
>   _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
>                                       ^
> include/linux/compiler_types.h:523:4: note: in definition of macro
> '__compiletime_assert'
>     prefix ## suffix();    \
>     ^~~~~~
> include/linux/compiler_types.h:542:2: note: in expansion of macro
> '_compiletime_assert'
>   _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
>   ^~~~~~~~~~~~~~~~~~~
> include/linux/build_bug.h:39:37: note: in expansion of macro
> 'compiletime_assert'
>  #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg)
>                                      ^~~~~~~~~~~~~~~~~~
> include/linux/bitfield.h:68:3: note: in expansion of macro 'BUILD_BUG_ON_MSG'
>    BUILD_BUG_ON_MSG(__builtin_constant_p(_val) ?  \
>    ^~~~~~~~~~~~~~~~
> include/linux/bitfield.h:115:3: note: in expansion of macro '__BF_FIELD_CHECK'
>    __BF_FIELD_CHECK(_mask, 0ULL, _val, "FIELD_PREP: "); \
>    ^~~~~~~~~~~~~~~~
> drivers/phy/freescale/phy-fsl-samsung-hdmi.c:344:9: note: in expansion
> of macro 'FIELD_PREP'
>   writeb(FIELD_PREP(REG12_CK_DIV_MASK, div), phy->regs + PHY_REG(12));
>          ^~~~~~~~~~
> make[6]: *** [scripts/Makefile.build:196:
> drivers/phy/freescale/phy-fsl-samsung-hdmi.o] Error 1

Offending commit now dropped from 6.13.y and 6.12.y, thanks.

greg k-h