1. Patchew
  2. linux
  3. [PATCH v3 0/8] Introduce debugfs support in IOMMU
  4. View patch

[PATCH v3 3/8] iommu/amd: Add debugfs support to dump IOMMU Capability registers

Dheeraj Kumar Srivastava posted 8 patches 10 months, 2 weeks ago
There is a newer version of this series
[PATCH v3 3/8] iommu/amd: Add debugfs support to dump IOMMU Capability registers
Posted by Dheeraj Kumar Srivastava 10 months, 2 weeks ago 
IOMMU Capability registers defines capabilities of IOMMU and information
needed for initialising MMIO registers and device table. This is useful
to dump these registers for debugging IOMMU related issues.

e.g.To get capability registers value for iommu<x>
  # echo "0x10" > /sys/kernel/debug/iommu/amd/iommu00/capability
  # cat /sys/kernel/debug/iommu/amd/iommu00/capability

Signed-off-by: Dheeraj Kumar Srivastava <dheerajkumar.srivastava@amd.com>
---
 drivers/iommu/amd/debugfs.c | 47 +++++++++++++++++++++++++++++++++++++
 1 file changed, 47 insertions(+)

diff --git a/drivers/iommu/amd/debugfs.c b/drivers/iommu/amd/debugfs.c
index b16b62ae7111..dc5fdc905754 100644
--- a/drivers/iommu/amd/debugfs.c
+++ b/drivers/iommu/amd/debugfs.c
@@ -18,6 +18,7 @@ static struct dentry *amd_iommu_debugfs;
 #define	OFS_IN_SZ	8
 
 static int mmio_offset = -1;
+static int cap_offset = -1;
 
 static ssize_t iommu_mmio_write(struct file *filp, const char __user *ubuf,
 				size_t cnt, loff_t *ppos)
@@ -58,6 +59,50 @@ static int iommu_mmio_show(struct seq_file *m, void *unused)
 }
 DEFINE_SHOW_STORE_ATTRIBUTE(iommu_mmio);
 
+static ssize_t iommu_capability_write(struct file *filp, const char __user *ubuf,
+				      size_t cnt, loff_t *ppos)
+{
+	int ret;
+
+	if (cnt > OFS_IN_SZ)
+		return -EINVAL;
+
+	ret = kstrtou32_from_user(ubuf, cnt, 0, &cap_offset);
+	if (ret)
+		return ret;
+
+	/* Capability register at offset 0x14 is the last IOMMU capability register. */
+	if (cap_offset > 0x14) {
+		cap_offset = -1;
+		return -EINVAL;
+	}
+
+	return cnt;
+}
+
+static int iommu_capability_show(struct seq_file *m, void *unused)
+{
+	struct amd_iommu *iommu = m->private;
+	u32 value;
+	int err;
+
+	if (cap_offset < 0) {
+		seq_puts(m, "Please provide capability register's offset\n");
+		return 0;
+	}
+
+	err = pci_read_config_dword(iommu->dev, iommu->cap_ptr + cap_offset, &value);
+	if (err) {
+		seq_printf(m, "Not able to read capability register at 0x%x\n", cap_offset);
+		return 0;
+	}
+
+	seq_printf(m, "Offset:0x%x Value:0x%08x\n", cap_offset, value);
+
+	return 0;
+}
+DEFINE_SHOW_STORE_ATTRIBUTE(iommu_capability);
+
 void amd_iommu_debugfs_setup(void)
 {
 	struct amd_iommu *iommu;
@@ -71,5 +116,7 @@ void amd_iommu_debugfs_setup(void)
 
 		debugfs_create_file("mmio", 0644, iommu->debugfs, iommu,
 				    &iommu_mmio_fops);
+		debugfs_create_file("capability", 0644, iommu->debugfs, iommu,
+				    &iommu_capability_fops);
 	}
 }
-- 
2.25.1
Re: [PATCH v3 3/8] iommu/amd: Add debugfs support to dump IOMMU Capability registers
Posted by Vasant Hegde 9 months, 1 week ago 
Dheeraj,


On 2/6/2025 11:29 AM, Dheeraj Kumar Srivastava wrote:
> IOMMU Capability registers defines capabilities of IOMMU and information
> needed for initialising MMIO registers and device table. This is useful
> to dump these registers for debugging IOMMU related issues.
> 
> e.g.To get capability registers value for iommu<x>
>   # echo "0x10" > /sys/kernel/debug/iommu/amd/iommu00/capability
>   # cat /sys/kernel/debug/iommu/amd/iommu00/capability
> 
> Signed-off-by: Dheeraj Kumar Srivastava <dheerajkumar.srivastava@amd.com>
> ---
>  drivers/iommu/amd/debugfs.c | 47 +++++++++++++++++++++++++++++++++++++
>  1 file changed, 47 insertions(+)
> 
> diff --git a/drivers/iommu/amd/debugfs.c b/drivers/iommu/amd/debugfs.c
> index b16b62ae7111..dc5fdc905754 100644
> --- a/drivers/iommu/amd/debugfs.c
> +++ b/drivers/iommu/amd/debugfs.c
> @@ -18,6 +18,7 @@ static struct dentry *amd_iommu_debugfs;
>  #define	OFS_IN_SZ	8
>  
>  static int mmio_offset = -1;
> +static int cap_offset = -1;
>  
>  static ssize_t iommu_mmio_write(struct file *filp, const char __user *ubuf,
>  				size_t cnt, loff_t *ppos)
> @@ -58,6 +59,50 @@ static int iommu_mmio_show(struct seq_file *m, void *unused)
>  }
>  DEFINE_SHOW_STORE_ATTRIBUTE(iommu_mmio);
>  
> +static ssize_t iommu_capability_write(struct file *filp, const char __user *ubuf,
> +				      size_t cnt, loff_t *ppos)
> +{
> +	int ret;
> +
> +	if (cnt > OFS_IN_SZ)
> +		return -EINVAL;
> +
> +	ret = kstrtou32_from_user(ubuf, cnt, 0, &cap_offset);
> +	if (ret)
> +		return ret;
> +
> +	/* Capability register at offset 0x14 is the last IOMMU capability register. */
> +	if (cap_offset > 0x14) {
> +		cap_offset = -1;
> +		return -EINVAL;
> +	}
> +
> +	return cnt;
> +}
> +
> +static int iommu_capability_show(struct seq_file *m, void *unused)
> +{
> +	struct amd_iommu *iommu = m->private;
> +	u32 value;
> +	int err;
> +
> +	if (cap_offset < 0) {
> +		seq_puts(m, "Please provide capability register's offset\n");

May be you can add last offset details... so that it becomes easy to find out
the offset range.

-Vasant
Re: [PATCH v3 3/8] iommu/amd: Add debugfs support to dump IOMMU Capability registers
Posted by Dheeraj Kumar Srivastava 9 months ago 
Hi Vasant,

On 3/13/2025 4:02 PM, Vasant Hegde wrote:
> Dheeraj,
> 
> 
> On 2/6/2025 11:29 AM, Dheeraj Kumar Srivastava wrote:
>> IOMMU Capability registers defines capabilities of IOMMU and information
>> needed for initialising MMIO registers and device table. This is useful
>> to dump these registers for debugging IOMMU related issues.
>>
>> e.g.To get capability registers value for iommu<x>
>>    # echo "0x10" > /sys/kernel/debug/iommu/amd/iommu00/capability
>>    # cat /sys/kernel/debug/iommu/amd/iommu00/capability
>>
>> Signed-off-by: Dheeraj Kumar Srivastava <dheerajkumar.srivastava@amd.com>
>> ---
>>   drivers/iommu/amd/debugfs.c | 47 +++++++++++++++++++++++++++++++++++++
>>   1 file changed, 47 insertions(+)
>>
>> diff --git a/drivers/iommu/amd/debugfs.c b/drivers/iommu/amd/debugfs.c
>> index b16b62ae7111..dc5fdc905754 100644
>> --- a/drivers/iommu/amd/debugfs.c
>> +++ b/drivers/iommu/amd/debugfs.c
>> @@ -18,6 +18,7 @@ static struct dentry *amd_iommu_debugfs;
>>   #define	OFS_IN_SZ	8
>>   
>>   static int mmio_offset = -1;
>> +static int cap_offset = -1;
>>   
>>   static ssize_t iommu_mmio_write(struct file *filp, const char __user *ubuf,
>>   				size_t cnt, loff_t *ppos)
>> @@ -58,6 +59,50 @@ static int iommu_mmio_show(struct seq_file *m, void *unused)
>>   }
>>   DEFINE_SHOW_STORE_ATTRIBUTE(iommu_mmio);
>>   
>> +static ssize_t iommu_capability_write(struct file *filp, const char __user *ubuf,
>> +				      size_t cnt, loff_t *ppos)
>> +{
>> +	int ret;
>> +
>> +	if (cnt > OFS_IN_SZ)
>> +		return -EINVAL;
>> +
>> +	ret = kstrtou32_from_user(ubuf, cnt, 0, &cap_offset);
>> +	if (ret)
>> +		return ret;
>> +
>> +	/* Capability register at offset 0x14 is the last IOMMU capability register. */
>> +	if (cap_offset > 0x14) {
>> +		cap_offset = -1;
>> +		return -EINVAL;
>> +	}
>> +
>> +	return cnt;
>> +}
>> +
>> +static int iommu_capability_show(struct seq_file *m, void *unused)
>> +{
>> +	struct amd_iommu *iommu = m->private;
>> +	u32 value;
>> +	int err;
>> +
>> +	if (cap_offset < 0) {
>> +		seq_puts(m, "Please provide capability register's offset\n");
> 
> May be you can add last offset details... so that it becomes easy to find out
> the offset range.

Sure.

Thanks
Dheeraj

> 
> -Vasant
> 
>

Patchew 2.1-devel-b67e4c2

© 2016 - 2025 Red Hat, Inc.