Add SDCA DisCo parsing support

[PATCH 00/10] Add SDCA DisCo parsing support

Posted by Charles Keepax 10 months, 1 week ago

The MIPI SoundWire Device Class for Audio (SDCA) specification defines
most details of the hardware in ACPI using the MIPI Discovery and
Configuration (DisCo) specification. This patch chain adds support for
parsing most of this information into the kernel such that future work
can make use of it to construct CODEC devices and soundcards.

The most notable outstanding work here, is parsing the separate
properties for the Control Numbers (roughly equivalent to channels)
within an individual Control. The separate Control Numbers are
supported but currently only the scheme were a single default etc. is
supplied for all.  This should not be super hard to add in the future
but isn't currently required by any of the hardware I am working to
support.

Thanks,
Charles

Charles Keepax (8):
  ASoC: SDCA: Minor formatting and naming tweaks
  ASoC: SDCA: Add support for Entity 0
  ASoC: SDCA: Add SDCA Control parsing
  ASoC: SDCA: Add parsing for Control range structures
  ASoC: SDCA: Add Channel Cluster parsing
  ASoC: SDCA: Add support for IT/OT Entity properties
  ASoC: SDCA: Add support for clock Entity properties
  ASoC: SDCA: Add support for PDE Entity properties

Pierre-Louis Bossart (2):
  ASoC: SDCA: Add code to parse Function information
  ASoC: SDCA: Parse initialization write table

 include/sound/sdca.h            |   22 +-
 include/sound/sdca_function.h   | 1089 +++++++++++++++++++++++-
 sound/soc/sdca/sdca_device.c    |    3 +-
 sound/soc/sdca/sdca_functions.c | 1407 ++++++++++++++++++++++++++++++-
 4 files changed, 2480 insertions(+), 41 deletions(-)

-- 
2.39.5

Re: [PATCH 00/10] Add SDCA DisCo parsing support

Posted by Mark Brown 10 months ago

On Wed, 05 Feb 2025 11:37:51 +0000, Charles Keepax wrote:
> The MIPI SoundWire Device Class for Audio (SDCA) specification defines
> most details of the hardware in ACPI using the MIPI Discovery and
> Configuration (DisCo) specification. This patch chain adds support for
> parsing most of this information into the kernel such that future work
> can make use of it to construct CODEC devices and soundcards.
> 
> The most notable outstanding work here, is parsing the separate
> properties for the Control Numbers (roughly equivalent to channels)
> within an individual Control. The separate Control Numbers are
> supported but currently only the scheme were a single default etc. is
> supplied for all.  This should not be super hard to add in the future
> but isn't currently required by any of the hardware I am working to
> support.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[01/10] ASoC: SDCA: Minor formatting and naming tweaks
        commit: 629dd55cf77bd3a8f80049150d3c05fef6d3b468
[02/10] ASoC: SDCA: Add code to parse Function information
        commit: 996bf834d0b61cb5a1389356c1ed7db1230139d7
[03/10] ASoC: SDCA: Parse initialization write table
        commit: 19f6748abbab8523a7b32a5e371e39d4d8d4aba5
[04/10] ASoC: SDCA: Add support for Entity 0
        commit: 9ee6d50ae4b0fe14ed70a5265a05874d41e10848
[05/10] ASoC: SDCA: Add SDCA Control parsing
        commit: 42b144cb6a2d87385fa0b124c975d6cf1e3ec630
[06/10] ASoC: SDCA: Add parsing for Control range structures
        commit: 64fb5af1d1bbcf1b808e9bb092b22fa1b691ae63
[07/10] ASoC: SDCA: Add Channel Cluster parsing
        commit: f87c2a275033120e15213f3d65234d98e726c4b7
[08/10] ASoC: SDCA: Add support for IT/OT Entity properties
        commit: 5c93b20f6de4478e1fbcfb38eb46738bca74180e
[09/10] ASoC: SDCA: Add support for clock Entity properties
        commit: e80b8e5c53c30df1cba45258d10b04872b7eea67
[10/10] ASoC: SDCA: Add support for PDE Entity properties
        commit: 9da195880f167ab7c2d595388decf783c9920121

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

Re: [PATCH 00/10] Add SDCA DisCo parsing support

Posted by Pierre-Louis Bossart 10 months, 1 week ago

On 2/5/25 05:37, Charles Keepax wrote:
> The MIPI SoundWire Device Class for Audio (SDCA) specification defines
> most details of the hardware in ACPI using the MIPI Discovery and
> Configuration (DisCo) specification. This patch chain adds support for
> parsing most of this information into the kernel such that future work
> can make use of it to construct CODEC devices and soundcards.
> 
> The most notable outstanding work here, is parsing the separate
> properties for the Control Numbers (roughly equivalent to channels)
> within an individual Control. The separate Control Numbers are
> supported but currently only the scheme were a single default etc. is
> supplied for all.  This should not be super hard to add in the future
> but isn't currently required by any of the hardware I am working to
> support.
> 
> Thanks,
> Charles
> 
> Charles Keepax (8):
>   ASoC: SDCA: Minor formatting and naming tweaks
>   ASoC: SDCA: Add support for Entity 0
>   ASoC: SDCA: Add SDCA Control parsing
>   ASoC: SDCA: Add parsing for Control range structures
>   ASoC: SDCA: Add Channel Cluster parsing
>   ASoC: SDCA: Add support for IT/OT Entity properties
>   ASoC: SDCA: Add support for clock Entity properties
>   ASoC: SDCA: Add support for PDE Entity properties
> 
> Pierre-Louis Bossart (2):
>   ASoC: SDCA: Add code to parse Function information
>   ASoC: SDCA: Parse initialization write table

Thanks Charles for extending my initial draft, LGTM.

Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.dev>

For the record all the definitions in this patchset are extracted from the SDCA public version available at https://www.mipi.org/mipi-sdca-v1-0-download

> 
>  include/sound/sdca.h            |   22 +-
>  include/sound/sdca_function.h   | 1089 +++++++++++++++++++++++-
>  sound/soc/sdca/sdca_device.c    |    3 +-
>  sound/soc/sdca/sdca_functions.c | 1407 ++++++++++++++++++++++++++++++-
>  4 files changed, 2480 insertions(+), 41 deletions(-)
>