IBS on Zen5:
- introduced Load Latency filtering capability.
- shows DTLB and page size information differently from prior generations.

Incorporate these changes into IBS kernel driver as well as perf tool.
Also include a perf unit-test to test IBS sample period constraints.

Patches are prepared on peterz/queue/perf/core (cffa473a06d2).

v2: https://lore.kernel.org/r/20241218121437.1717-1-ravi.bangoria@amd.com

v2->v3:
 - The patch series to fix IBS sample period computation [1] is picked up
   by Peter except the last patch which added unit test in perf tool.
   Include it in this series instead of sending it independently.
 - No changes otherwise.

[1]: https://lore.kernel.org/r/20250115054438.1021-1-ravi.bangoria@amd.com

Ravi Bangoria (7):
  perf/amd/ibs: Add support for OP Load Latency Filtering
  perf/amd/ibs: Update DTLB/PageSize decode logic
  perf amd ibs: Sync arch/x86/include/asm/amd-ibs.h header with the
    kernel
  perf amd ibs: Add Load Latency bits in raw dump
  perf amd ibs: Incorporate Zen5 DTLB and PageSize information
  perf mem/c2c amd: Add ldlat support
  perf test amd ibs: Add sample period unit test

 arch/x86/events/amd/ibs.c                  | 116 ++-
 arch/x86/include/asm/amd-ibs.h             |   3 +-
 arch/x86/include/asm/perf_event.h          |   4 +
 tools/arch/x86/include/asm/amd-ibs.h       |   3 +-
 tools/perf/Documentation/perf-amd-ibs.txt  |   9 +
 tools/perf/Documentation/perf-c2c.txt      |  10 +-
 tools/perf/Documentation/perf-mem.txt      |  12 +-
 tools/perf/arch/x86/include/arch-tests.h   |   1 +
 tools/perf/arch/x86/tests/Build            |   1 +
 tools/perf/arch/x86/tests/amd-ibs-period.c | 951 +++++++++++++++++++++
 tools/perf/arch/x86/tests/arch-tests.c     |   2 +
 tools/perf/arch/x86/util/mem-events.c      |   6 +
 tools/perf/arch/x86/util/mem-events.h      |   1 +
 tools/perf/arch/x86/util/pmu.c             |  20 +-
 tools/perf/tests/shell/test_data_symbol.sh |  29 +-
 tools/perf/util/amd-sample-raw.c           |  77 +-
 tools/perf/util/pmu.c                      |  11 +
 tools/perf/util/pmu.h                      |   2 +
 18 files changed, 1224 insertions(+), 34 deletions(-)
 create mode 100644 tools/perf/arch/x86/tests/amd-ibs-period.c

-- 
2.43.0

On 05-Feb-25 11:35 AM, Ravi Bangoria wrote:
> IBS on Zen5:
> - introduced Load Latency filtering capability.
> - shows DTLB and page size information differently from prior generations.
> 
> Incorporate these changes into IBS kernel driver as well as perf tool.
> Also include a perf unit-test to test IBS sample period constraints.
> 
> Patches are prepared on peterz/queue/perf/core (cffa473a06d2).

Ingo, Peter, gentle ping!

Thanks,
Ravi

On Mon, Feb 17, 2025 at 02:00:14PM +0530, Ravi Bangoria wrote:
> On 05-Feb-25 11:35 AM, Ravi Bangoria wrote:
> > IBS on Zen5:
> > - introduced Load Latency filtering capability.
> > - shows DTLB and page size information differently from prior generations.
> > 
> > Incorporate these changes into IBS kernel driver as well as perf tool.
> > Also include a perf unit-test to test IBS sample period constraints.
> > 
> > Patches are prepared on peterz/queue/perf/core (cffa473a06d2).
> 
> Ingo, Peter, gentle ping!

First 3 patches are in queue/perf/core, assuming the robots be happy,
I'll push it into tip/perf/core.


Thanks!

On 17-Feb-25 7:54 PM, Peter Zijlstra wrote:
> On Mon, Feb 17, 2025 at 02:00:14PM +0530, Ravi Bangoria wrote:
>> On 05-Feb-25 11:35 AM, Ravi Bangoria wrote:
>>> IBS on Zen5:
>>> - introduced Load Latency filtering capability.
>>> - shows DTLB and page size information differently from prior generations.
>>>
>>> Incorporate these changes into IBS kernel driver as well as perf tool.
>>> Also include a perf unit-test to test IBS sample period constraints.
>>>
>>> Patches are prepared on peterz/queue/perf/core (cffa473a06d2).
>>
>> Ingo, Peter, gentle ping!
> 
> First 3 patches are in queue/perf/core, assuming the robots be happy,
> I'll push it into tip/perf/core.

Thanks Peter!

Arnaldo, Namhyung,

Patch 4-7 applies cleanly on perf-tools-next/perf-tools-next (commit
20600b8aab73). However, perf tool build will break without patch 3.
Wondering if you can pick patch 4-7 without patch 3?

Thanks,
Ravi