[PATCH v4 1/6] dt-bindings: socfpga-dwmac: fix typo

Steffen Trumtrar posted 6 patches 10 months, 2 weeks ago
[PATCH v4 1/6] dt-bindings: socfpga-dwmac: fix typo
Posted by Steffen Trumtrar 10 months, 2 weeks ago
The phandle to the SGMII converter must be called
"altr,gmii-to-sgmii-converter".

This is how the phandle is called in the example and the driver. As
there are no upstream users of this binding anyway, this shouldn't
break anything.

Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
---
 Documentation/devicetree/bindings/net/socfpga-dwmac.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/net/socfpga-dwmac.txt b/Documentation/devicetree/bindings/net/socfpga-dwmac.txt
index 612a8e8abc88774619f4fd4e9205a3dd32226a9b..67784463f6f5a3ba7d2e10810810ab2d51715842 100644
--- a/Documentation/devicetree/bindings/net/socfpga-dwmac.txt
+++ b/Documentation/devicetree/bindings/net/socfpga-dwmac.txt
@@ -24,7 +24,7 @@ Optional properties:
 altr,emac-splitter: Should be the phandle to the emac splitter soft IP node if
 		DWMAC controller is connected emac splitter.
 phy-mode: The phy mode the ethernet operates in
-altr,sgmii-to-sgmii-converter: phandle to the TSE SGMII converter
+altr,gmii-to-sgmii-converter: phandle to the TSE SGMII converter
 
 This device node has additional phandle dependency, the sgmii converter:
 

-- 
2.46.0
Re: [PATCH v4 1/6] dt-bindings: socfpga-dwmac: fix typo
Posted by Krzysztof Kozlowski 10 months, 1 week ago
On Wed, Feb 05, 2025 at 04:32:22PM +0100, Steffen Trumtrar wrote:
> The phandle to the SGMII converter must be called
> "altr,gmii-to-sgmii-converter".
> 
> This is how the phandle is called in the example and the driver. As
> there are no upstream users of this binding anyway, this shouldn't
> break anything.
> 
> Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
> ---
>  Documentation/devicetree/bindings/net/socfpga-dwmac.txt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/net/socfpga-dwmac.txt b/Documentation/devicetree/bindings/net/socfpga-dwmac.txt
> index 612a8e8abc88774619f4fd4e9205a3dd32226a9b..67784463f6f5a3ba7d2e10810810ab2d51715842 100644
> --- a/Documentation/devicetree/bindings/net/socfpga-dwmac.txt
> +++ b/Documentation/devicetree/bindings/net/socfpga-dwmac.txt
> @@ -24,7 +24,7 @@ Optional properties:
>  altr,emac-splitter: Should be the phandle to the emac splitter soft IP node if
>  		DWMAC controller is connected emac splitter.
>  phy-mode: The phy mode the ethernet operates in
> -altr,sgmii-to-sgmii-converter: phandle to the TSE SGMII converter
> +altr,gmii-to-sgmii-converter: phandle to the TSE SGMII converter

You remove it in the next patch, so just squash it and mention any
changes done during conversion. This is noop otherwise.

Best regards,
Krzysztof