From: Dimitri Fedrau <dimitri.fedrau@liebherr.com>
Add property tx-amplitude-100base-tx-percent in the device tree bindings
for configuring the tx amplitude of 100BASE-TX PHYs. Modifying it can be
necessary to compensate losses on the PCB and connector, so the voltages
measured on the RJ45 pins are conforming.
Signed-off-by: Dimitri Fedrau <dimitri.fedrau@liebherr.com>
---
Documentation/devicetree/bindings/net/ethernet-phy.yaml | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/Documentation/devicetree/bindings/net/ethernet-phy.yaml b/Documentation/devicetree/bindings/net/ethernet-phy.yaml
index 2c71454ae8e362e7032e44712949e12da6826070..04f42961035f273990fdf4368ad1352397fc3774 100644
--- a/Documentation/devicetree/bindings/net/ethernet-phy.yaml
+++ b/Documentation/devicetree/bindings/net/ethernet-phy.yaml
@@ -232,6 +232,13 @@ properties:
PHY's that have configurable TX internal delays. If this property is
present then the PHY applies the TX delay.
+ tx-amplitude-100base-tx-percent:
+ description: |
+ Transmit amplitude gain applied for 100BASE-TX. When omitted, the PHYs
+ default will be left as is.
+ $ref: /schemas/types.yaml#/definitions/uint32
+ default: 100
+
leds:
type: object
--
2.39.5On Tue, Feb 04, 2025 at 02:09:15PM +0100, Dimitri Fedrau wrote: > Add property tx-amplitude-100base-tx-percent in the device tree bindings > for configuring the tx amplitude of 100BASE-TX PHYs. Modifying it can be > necessary to compensate losses on the PCB and connector, so the voltages > measured on the RJ45 pins are conforming. > > Signed-off-by: Dimitri Fedrau <dimitri.fedrau@liebherr.com> > --- > Documentation/devicetree/bindings/net/ethernet-phy.yaml | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/ethernet-phy.yaml b/Documentation/devicetree/bindings/net/ethernet-phy.yaml > index 2c71454ae8e362e7032e44712949e12da6826070..04f42961035f273990fdf4368ad1352397fc3774 100644 > --- a/Documentation/devicetree/bindings/net/ethernet-phy.yaml > +++ b/Documentation/devicetree/bindings/net/ethernet-phy.yaml > @@ -232,6 +232,13 @@ properties: > PHY's that have configurable TX internal delays. If this property is > present then the PHY applies the TX delay. > > + tx-amplitude-100base-tx-percent: > + description: | Don't need '|' if no formatting to preserve. > + Transmit amplitude gain applied for 100BASE-TX. When omitted, the PHYs > + default will be left as is. > + $ref: /schemas/types.yaml#/definitions/uint32 > + default: 100 > + > leds: > type: object > > > -- > 2.39.5 >
Am Tue, Feb 04, 2025 at 09:34:09AM -0600 schrieb Rob Herring: > On Tue, Feb 04, 2025 at 02:09:15PM +0100, Dimitri Fedrau wrote: > > Add property tx-amplitude-100base-tx-percent in the device tree bindings > > for configuring the tx amplitude of 100BASE-TX PHYs. Modifying it can be > > necessary to compensate losses on the PCB and connector, so the voltages > > measured on the RJ45 pins are conforming. > > > > Signed-off-by: Dimitri Fedrau <dimitri.fedrau@liebherr.com> > > --- > > Documentation/devicetree/bindings/net/ethernet-phy.yaml | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/net/ethernet-phy.yaml b/Documentation/devicetree/bindings/net/ethernet-phy.yaml > > index 2c71454ae8e362e7032e44712949e12da6826070..04f42961035f273990fdf4368ad1352397fc3774 100644 > > --- a/Documentation/devicetree/bindings/net/ethernet-phy.yaml > > +++ b/Documentation/devicetree/bindings/net/ethernet-phy.yaml > > @@ -232,6 +232,13 @@ properties: > > PHY's that have configurable TX internal delays. If this property is > > present then the PHY applies the TX delay. > > > > + tx-amplitude-100base-tx-percent: > > + description: | > > Don't need '|' if no formatting to preserve. > Wasn't sure about the '|', because some properties use it(rx-internal-delay-ps or tx-internal-delay-ps) others not. Is it wrong there ? I don't see any reason to preserve formatting there. Anyway will remove the '|' as you proposed. Thanks for explaining, didn't know. Best regards, Dimitri Fedrau [...]
On Tue, 04 Feb 2025 14:09:15 +0100, Dimitri Fedrau wrote:
> Add property tx-amplitude-100base-tx-percent in the device tree bindings
> for configuring the tx amplitude of 100BASE-TX PHYs. Modifying it can be
> necessary to compensate losses on the PCB and connector, so the voltages
> measured on the RJ45 pins are conforming.
>
> Signed-off-by: Dimitri Fedrau <dimitri.fedrau@liebherr.com>
> ---
> Documentation/devicetree/bindings/net/ethernet-phy.yaml | 7 +++++++
> 1 file changed, 7 insertions(+)
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/ethernet-phy.yaml: properties:tx-amplitude-100base-tx-percent: '$ref' should not be valid under {'const': '$ref'}
hint: Standard unit suffix properties don't need a type $ref
from schema $id: http://devicetree.org/meta-schemas/core.yaml#
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250204-dp83822-tx-swing-v3-1-9798e96500d9@liebherr.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
Am Tue, Feb 04, 2025 at 08:28:09AM -0600 schrieb Rob Herring (Arm):
>
> On Tue, 04 Feb 2025 14:09:15 +0100, Dimitri Fedrau wrote:
> > Add property tx-amplitude-100base-tx-percent in the device tree bindings
> > for configuring the tx amplitude of 100BASE-TX PHYs. Modifying it can be
> > necessary to compensate losses on the PCB and connector, so the voltages
> > measured on the RJ45 pins are conforming.
> >
> > Signed-off-by: Dimitri Fedrau <dimitri.fedrau@liebherr.com>
> > ---
> > Documentation/devicetree/bindings/net/ethernet-phy.yaml | 7 +++++++
> > 1 file changed, 7 insertions(+)
> >
>
> My bot found errors running 'make dt_binding_check' on your patch:
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/ethernet-phy.yaml: properties:tx-amplitude-100base-tx-percent: '$ref' should not be valid under {'const': '$ref'}
> hint: Standard unit suffix properties don't need a type $ref
> from schema $id: http://devicetree.org/meta-schemas/core.yaml#
>
> doc reference errors (make refcheckdocs):
>
> See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250204-dp83822-tx-swing-v3-1-9798e96500d9@liebherr.com
>
> The base for the series is generally the latest rc1. A different dependency
> should be noted in *this* patch.
>
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
>
> pip3 install dtschema --upgrade
>
> Please check and re-submit after running the above command yourself. Note
> that DT_SCHEMA_FILES can be set to your schema file to speed up checking
> your schema. However, it must be unset to test all examples with your schema.
>
Thanks, missed to check. Will fix it.
Best regards,
Dimitri Fedrau
© 2016 - 2025 Red Hat, Inc.