[PATCH] dt-bindings: mtd: arasan,nand-controller: Ensure all properties are defined

Rob Herring (Arm) posted 1 patch 1 year ago
.../devicetree/bindings/mtd/arasan,nand-controller.yaml         | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] dt-bindings: mtd: arasan,nand-controller: Ensure all properties are defined
Posted by Rob Herring (Arm) 1 year ago
Device specific schemas should not allow undefined properties which is
what 'unevaluatedProperties: true' allows. Fix this constraint.

Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
 .../devicetree/bindings/mtd/arasan,nand-controller.yaml         | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/mtd/arasan,nand-controller.yaml b/Documentation/devicetree/bindings/mtd/arasan,nand-controller.yaml
index 15b63bbb82a2..b90d3b48c2f2 100644
--- a/Documentation/devicetree/bindings/mtd/arasan,nand-controller.yaml
+++ b/Documentation/devicetree/bindings/mtd/arasan,nand-controller.yaml
@@ -42,7 +42,7 @@ required:
   - clock-names
   - interrupts
 
-unevaluatedProperties: true
+unevaluatedProperties: false
 
 examples:
   - |
-- 
2.47.2
Re: [PATCH] dt-bindings: mtd: arasan,nand-controller: Ensure all properties are defined
Posted by Miquel Raynal 1 year ago
On Mon, 03 Feb 2025 15:30:41 -0600, Rob Herring (Arm) wrote:
> Device specific schemas should not allow undefined properties which is
> what 'unevaluatedProperties: true' allows. Fix this constraint.
> 
> 

Applied to nand/next, thanks!

[1/1] dt-bindings: mtd: arasan,nand-controller: Ensure all properties are defined
      commit: 499a4b16a4869a901a9bc601bc1e0b8f60151e93

Patche(s) should be available on mtd/linux.git and will be
part of the next PR (provided that no robot complains by then).

Kind regards,
Miquèl

Re: [PATCH] dt-bindings: mtd: arasan,nand-controller: Ensure all properties are defined
Posted by Conor Dooley 1 year ago
On Mon, Feb 03, 2025 at 03:30:41PM -0600, Rob Herring (Arm) wrote:
> Device specific schemas should not allow undefined properties which is
> what 'unevaluatedProperties: true' allows. Fix this constraint.
> 
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>

Acked-by: Conor Dooley <conor.dooley@microchip.com>
Re: [PATCH] dt-bindings: mtd: arasan,nand-controller: Ensure all properties are defined
Posted by Michal Simek 1 year ago

On 2/3/25 22:30, Rob Herring (Arm) wrote:
> Device specific schemas should not allow undefined properties which is
> what 'unevaluatedProperties: true' allows. Fix this constraint.
> 
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
> ---
>   .../devicetree/bindings/mtd/arasan,nand-controller.yaml         | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/mtd/arasan,nand-controller.yaml b/Documentation/devicetree/bindings/mtd/arasan,nand-controller.yaml
> index 15b63bbb82a2..b90d3b48c2f2 100644
> --- a/Documentation/devicetree/bindings/mtd/arasan,nand-controller.yaml
> +++ b/Documentation/devicetree/bindings/mtd/arasan,nand-controller.yaml
> @@ -42,7 +42,7 @@ required:
>     - clock-names
>     - interrupts
>   
> -unevaluatedProperties: true
> +unevaluatedProperties: false
>   
>   examples:
>     - |

Good thing to do. And we should extend binding to cover other properties which 
are missing in description.
Pretty much remove arasan,has-mdma from DTs and describe power-domains and 
num-cs in binding.

Acked-by: Michal Simek <michal.simek@amd.com>

Thanks,
Michal