[v3] Add support for Priva E-Measuringbox board

[PATCH v3 0/4] Add support for Priva E-Measuringbox board

Posted by Oleksij Rempel 10 months, 2 weeks ago

This patch series introduces support for the Priva E-Measuringbox board
based on the ST STM32MP133 SoC. The set includes all the necessary
changes for device tree bindings, vendor prefixes, thermal support, and
board-specific devicetree to pass devicetree validation and checkpatch
tests.

changes v2:
- drop: dt-bindings: net: Add TI DP83TD510 10BaseT1L PHY

Oleksij Rempel (2):
  dt-bindings: vendor-prefixes: Add prefix for Priva
  dt-bindings: arm: stm32: Add Priva E-Measuringbox board

Roan van Dijk (2):
  arm: dts: stm32: Add thermal support for STM32MP131
  arm: dts: stm32: Add Priva E-Measuringbox devicetree

 .../devicetree/bindings/arm/stm32/stm32.yaml  |   6 +
 .../devicetree/bindings/vendor-prefixes.yaml  |   2 +
 arch/arm/boot/dts/st/Makefile                 |   1 +
 arch/arm/boot/dts/st/stm32mp131.dtsi          |  35 ++
 arch/arm/boot/dts/st/stm32mp133c-prihmb.dts   | 496 ++++++++++++++++++
 5 files changed, 540 insertions(+)
 create mode 100644 arch/arm/boot/dts/st/stm32mp133c-prihmb.dts

--
2.39.5

Re: [PATCH v3 0/4] Add support for Priva E-Measuringbox board

Posted by Alexandre TORGUE 9 months, 3 weeks ago

Hi

On 2/3/25 09:58, Oleksij Rempel wrote:
> This patch series introduces support for the Priva E-Measuringbox board
> based on the ST STM32MP133 SoC. The set includes all the necessary
> changes for device tree bindings, vendor prefixes, thermal support, and
> board-specific devicetree to pass devicetree validation and checkpatch
> tests.
> 
> changes v2:
> - drop: dt-bindings: net: Add TI DP83TD510 10BaseT1L PHY
> 
> Oleksij Rempel (2):
>    dt-bindings: vendor-prefixes: Add prefix for Priva
>    dt-bindings: arm: stm32: Add Priva E-Measuringbox board
> 
> Roan van Dijk (2):
>    arm: dts: stm32: Add thermal support for STM32MP131
>    arm: dts: stm32: Add Priva E-Measuringbox devicetree
> 
>   .../devicetree/bindings/arm/stm32/stm32.yaml  |   6 +
>   .../devicetree/bindings/vendor-prefixes.yaml  |   2 +
>   arch/arm/boot/dts/st/Makefile                 |   1 +
>   arch/arm/boot/dts/st/stm32mp131.dtsi          |  35 ++
>   arch/arm/boot/dts/st/stm32mp133c-prihmb.dts   | 496 ++++++++++++++++++
>   5 files changed, 540 insertions(+)
>   create mode 100644 arch/arm/boot/dts/st/stm32mp133c-prihmb.dts
> 
> --
> 2.39.5
> 

Series applied on stm32-next.

Cheers
Alex

Re: [PATCH v3 0/4] Add support for Priva E-Measuringbox board

Posted by Rob Herring (Arm) 10 months, 2 weeks ago

On Mon, 03 Feb 2025 09:58:16 +0100, Oleksij Rempel wrote:
> This patch series introduces support for the Priva E-Measuringbox board
> based on the ST STM32MP133 SoC. The set includes all the necessary
> changes for device tree bindings, vendor prefixes, thermal support, and
> board-specific devicetree to pass devicetree validation and checkpatch
> tests.
> 
> changes v2:
> - drop: dt-bindings: net: Add TI DP83TD510 10BaseT1L PHY
> 
> Oleksij Rempel (2):
>   dt-bindings: vendor-prefixes: Add prefix for Priva
>   dt-bindings: arm: stm32: Add Priva E-Measuringbox board
> 
> Roan van Dijk (2):
>   arm: dts: stm32: Add thermal support for STM32MP131
>   arm: dts: stm32: Add Priva E-Measuringbox devicetree
> 
>  .../devicetree/bindings/arm/stm32/stm32.yaml  |   6 +
>  .../devicetree/bindings/vendor-prefixes.yaml  |   2 +
>  arch/arm/boot/dts/st/Makefile                 |   1 +
>  arch/arm/boot/dts/st/stm32mp131.dtsi          |  35 ++
>  arch/arm/boot/dts/st/stm32mp133c-prihmb.dts   | 496 ++++++++++++++++++
>  5 files changed, 540 insertions(+)
>  create mode 100644 arch/arm/boot/dts/st/stm32mp133c-prihmb.dts
> 
> --
> 2.39.5
> 
> 
> 


My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade


New warnings running 'make CHECK_DTBS=y for arch/arm/boot/dts/st/' for 20250203085820.609176-1-o.rempel@pengutronix.de:

arch/arm/boot/dts/st/stm32mp133c-prihmb.dtb: adc@48004000: adc@0:interrupts: 0 was expected
	from schema $id: http://devicetree.org/schemas/iio/adc/st,stm32-adc.yaml#
arch/arm/boot/dts/st/stm32mp133c-prihmb.dtb: adc@48003000: adc@0:interrupts: 0 was expected
	from schema $id: http://devicetree.org/schemas/iio/adc/st,stm32-adc.yaml#

Re: [PATCH v3 0/4] Add support for Priva E-Measuringbox board

Posted by Oleksij Rempel 10 months, 2 weeks ago

Hi Alexandre,

On Mon, Feb 03, 2025 at 09:37:06AM -0600, Rob Herring (Arm) wrote:
> 
> On Mon, 03 Feb 2025 09:58:16 +0100, Oleksij Rempel wrote:
> > This patch series introduces support for the Priva E-Measuringbox board
> > based on the ST STM32MP133 SoC. The set includes all the necessary
> > changes for device tree bindings, vendor prefixes, thermal support, and
> > board-specific devicetree to pass devicetree validation and checkpatch
> > tests.
> > 

...

> arch/arm/boot/dts/st/stm32mp133c-prihmb.dtb: adc@48004000: adc@0:interrupts: 0 was expected
> 	from schema $id: http://devicetree.org/schemas/iio/adc/st,stm32-adc.yaml#
> arch/arm/boot/dts/st/stm32mp133c-prihmb.dtb: adc@48003000: adc@0:interrupts: 0 was expected
> 	from schema $id: http://devicetree.org/schemas/iio/adc/st,stm32-adc.yaml#
> 

Can I please get your attention here. The reported issue is not related
to this patch set. adc@0:interrupts are set in the dtsi file.

Kind regards,
Oleksij
-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

Re: [PATCH v3 0/4] Add support for Priva E-Measuringbox board

Posted by Alexandre TORGUE 10 months, 2 weeks ago

Hi Oleksij

On 2/5/25 10:17, Oleksij Rempel wrote:
> Hi Alexandre,
> 
> On Mon, Feb 03, 2025 at 09:37:06AM -0600, Rob Herring (Arm) wrote:
>>
>> On Mon, 03 Feb 2025 09:58:16 +0100, Oleksij Rempel wrote:
>>> This patch series introduces support for the Priva E-Measuringbox board
>>> based on the ST STM32MP133 SoC. The set includes all the necessary
>>> changes for device tree bindings, vendor prefixes, thermal support, and
>>> board-specific devicetree to pass devicetree validation and checkpatch
>>> tests.
>>>
> 
> ...
> 
>> arch/arm/boot/dts/st/stm32mp133c-prihmb.dtb: adc@48004000: adc@0:interrupts: 0 was expected
>> 	from schema $id: http://devicetree.org/schemas/iio/adc/st,stm32-adc.yaml#
>> arch/arm/boot/dts/st/stm32mp133c-prihmb.dtb: adc@48003000: adc@0:interrupts: 0 was expected
>> 	from schema $id: http://devicetree.org/schemas/iio/adc/st,stm32-adc.yaml#
>
> 
> Can I please get your attention here. The reported issue is not related
> to this patch set. adc@0:interrupts are set in the dtsi file.

Yes I saw this issue too when I tried to merge your series. I'm 
discussing with STM32 ADC driver owner to fix the issue (either in stm32 
adc yaml or maybe in schema).

Anyway we also have the issue for STM32MP135F-DK board so I'll merge 
your series as it doesn't introduce the issue.

regards
Alex




> Kind regards,
> Oleksij

Re: [PATCH v3 0/4] Add support for Priva E-Measuringbox board

Posted by Oleksij Rempel 9 months, 3 weeks ago

Hi Alexandre,

Just wanted to check if there’s anything needed from my side for this
patch. Let me know if further input is required.

Best Regards,
Oleksij

On Wed, Feb 05, 2025 at 05:02:19PM +0100, Alexandre TORGUE wrote:
> Hi Oleksij
> 
> On 2/5/25 10:17, Oleksij Rempel wrote:
> > Hi Alexandre,
> > 
> > On Mon, Feb 03, 2025 at 09:37:06AM -0600, Rob Herring (Arm) wrote:
> > > 
> > > On Mon, 03 Feb 2025 09:58:16 +0100, Oleksij Rempel wrote:
> > > > This patch series introduces support for the Priva E-Measuringbox board
> > > > based on the ST STM32MP133 SoC. The set includes all the necessary
> > > > changes for device tree bindings, vendor prefixes, thermal support, and
> > > > board-specific devicetree to pass devicetree validation and checkpatch
> > > > tests.
> > > > 
> > 
> > ...
> > 
> > > arch/arm/boot/dts/st/stm32mp133c-prihmb.dtb: adc@48004000: adc@0:interrupts: 0 was expected
> > > 	from schema $id: http://devicetree.org/schemas/iio/adc/st,stm32-adc.yaml#
> > > arch/arm/boot/dts/st/stm32mp133c-prihmb.dtb: adc@48003000: adc@0:interrupts: 0 was expected
> > > 	from schema $id: http://devicetree.org/schemas/iio/adc/st,stm32-adc.yaml#
> > 
> > 
> > Can I please get your attention here. The reported issue is not related
> > to this patch set. adc@0:interrupts are set in the dtsi file.
> 
> Yes I saw this issue too when I tried to merge your series. I'm discussing
> with STM32 ADC driver owner to fix the issue (either in stm32 adc yaml or
> maybe in schema).
> 
> Anyway we also have the issue for STM32MP135F-DK board so I'll merge your
> series as it doesn't introduce the issue.
> 
> regards
> Alex
> 
> 
> 
> 
> > Kind regards,
> > Oleksij
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |