[PATCH v5] riscv: Add runtime constant support

Charlie Jenkins posted 1 patch 1 year ago
There is a newer version of this series
arch/riscv/include/asm/runtime-const.h | 199 +++++++++++++++++++++++++++++++++
arch/riscv/kernel/vmlinux.lds.S        |   3 +
2 files changed, 202 insertions(+)
[PATCH v5] riscv: Add runtime constant support
Posted by Charlie Jenkins 1 year ago
Implement the runtime constant infrastructure for riscv. Use this
infrastructure to generate constants to be used by the d_hash()
function.

This is the riscv variant of commit 94a2bc0f611c ("arm64: add 'runtime
constant' support") and commit e3c92e81711d ("runtime constants: add
x86 architecture support").

Signed-off-by: Charlie Jenkins <charlie@rivosinc.com>
---
Ard brought this to my attention in this patch [1].

[1] https://lore.kernel.org/lkml/CAMj1kXE4DJnwFejNWQu784GvyJO=aGNrzuLjSxiowX_e7nW8QA@mail.gmail.com/
---
Changes in v5:
- Split instructions into 16-bit parcels to avoid alignment (Emil)
- Link to v4: https://lore.kernel.org/r/20250130-runtime_const_riscv-v4-1-2d36c41b7b9c@rivosinc.com

Changes in v4:
- Add newlines after riscv32 assembler directives
- Align instructions along 32-bit boundary (Emil)
- Link to v3: https://lore.kernel.org/r/20250128-runtime_const_riscv-v3-1-11922989e2d3@rivosinc.com

Changes in v3:
- Leverage "pack" instruction for runtime_const_ptr() to reduce hot path
  by 3 instructions if Zbkb is supported. Suggested by Pasha Bouzarjomehri (pasha@rivosinc.com)
- Link to v2: https://lore.kernel.org/r/20250127-runtime_const_riscv-v2-1-95ae7cf97a39@rivosinc.com

Changes in v2:
- Treat instructions as __le32 and do proper conversions (Ben)
- Link to v1: https://lore.kernel.org/r/20250127-runtime_const_riscv-v1-1-795b023ea20b@rivosinc.com
---
 arch/riscv/include/asm/runtime-const.h | 199 +++++++++++++++++++++++++++++++++
 arch/riscv/kernel/vmlinux.lds.S        |   3 +
 2 files changed, 202 insertions(+)

diff --git a/arch/riscv/include/asm/runtime-const.h b/arch/riscv/include/asm/runtime-const.h
new file mode 100644
index 0000000000000000000000000000000000000000..bbfa8c512c602e49a34f4e1b1174c77c0478ca44
--- /dev/null
+++ b/arch/riscv/include/asm/runtime-const.h
@@ -0,0 +1,199 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+#ifndef _ASM_RISCV_RUNTIME_CONST_H
+#define _ASM_RISCV_RUNTIME_CONST_H
+
+#include <asm/alternative.h>
+#include <asm/cacheflush.h>
+#include <asm/text-patching.h>
+#include <linux/uaccess.h>
+
+#ifdef CONFIG_32BIT
+#define runtime_const_ptr(sym)					\
+({								\
+	typeof(sym) __ret;					\
+	asm_inline(".option push\n\t"				\
+		".option norvc\n\t"				\
+		"1:\t"						\
+		"lui	%[__ret],0x89abd\n\t"			\
+		"addi	%[__ret],%[__ret],-0x211\n\t"		\
+		".option pop\n\t"				\
+		".pushsection runtime_ptr_" #sym ",\"a\"\n\t"	\
+		".long 1b - .\n\t"				\
+		".popsection"					\
+		: [__ret] "=r" (__ret));			\
+	__ret;							\
+})
+#else
+/*
+ * Loading 64-bit constants into a register from immediates is a non-trivial
+ * task on riscv64. To get it somewhat performant, load 32 bits into two
+ * different registers and then combine the results.
+ *
+ * If the processor supports the Zbkb extension, we can combine the final
+ * "slli,slli,srli,add" into the single "pack" instruction. If the processor
+ * doesn't support Zbkb but does support the Zbb extension, we can
+ * combine the final "slli,srli,add" into one instruction "add.uw".
+ */
+#define runtime_const_ptr(sym)						\
+({									\
+	typeof(sym) __ret, __tmp;					\
+	asm_inline(".option push\n\t"					\
+		".option norvc\n\t"					\
+		"1:\t"							\
+		"lui	%[__ret],0x89abd\n\t"				\
+		"lui	%[__tmp],0x1234\n\t"				\
+		"addiw	%[__ret],%[__ret],-0x211\n\t"			\
+		"addiw	%[__tmp],%[__tmp],0x567\n\t"			\
+		ALTERNATIVE_2(						\
+			"slli	%[__tmp],%[__tmp],32\n\t"		\
+			"slli	%[__ret],%[__ret],32\n\t"		\
+			"srli	%[__ret],%[__ret],32\n\t"		\
+			"add	%[__ret],%[__ret],%[__tmp]\n\t",	\
+			".option push\n\t"				\
+			".option arch,+zba\n\t"				\
+			"slli	%[__tmp],%[__tmp],32\n\t"		\
+			"add.uw %[__ret],%[__ret],%[__tmp]\n\t"		\
+			"nop\n\t"					\
+			"nop\n\t"					\
+			".option pop\n\t",				\
+			0, RISCV_ISA_EXT_ZBA, 1,			\
+			".option push\n\t"				\
+			".option arch,+zbkb\n\t"			\
+			"pack	%[__ret],%[__ret],%[__tmp]\n\t"		\
+			"nop\n\t"					\
+			"nop\n\t"					\
+			"nop\n\t"					\
+			".option pop\n\t",				\
+			0, RISCV_ISA_EXT_ZBKB, 1			\
+		)							\
+		".option pop\n\t"					\
+		".pushsection runtime_ptr_" #sym ",\"a\"\n\t"		\
+		".long 1b - .\n\t"					\
+		".popsection"						\
+		: [__ret] "=r" (__ret), [__tmp] "=r" (__tmp));		\
+	__ret;								\
+})
+#endif
+
+#ifdef CONFIG_32BIT
+#define SRLI "srli "
+#else
+#define SRLI "srliw "
+#endif
+
+#define runtime_const_shift_right_32(val, sym)			\
+({								\
+	u32 __ret;						\
+	asm_inline(".option push\n\t"				\
+		".option norvc\n\t"				\
+		"1:\t"						\
+		SRLI "%[__ret],%[__val],12\n\t"			\
+		".option pop\n\t"				\
+		".pushsection runtime_shift_" #sym ",\"a\"\n\t"	\
+		".long 1b - .\n\t"				\
+		".popsection"					\
+		: [__ret] "=r" (__ret)				\
+		: [__val] "r" (val));				\
+	__ret;							\
+})
+
+#define runtime_const_init(type, sym) do {			\
+	extern s32 __start_runtime_##type##_##sym[];		\
+	extern s32 __stop_runtime_##type##_##sym[];		\
+								\
+	runtime_const_fixup(__runtime_fixup_##type,		\
+			    (unsigned long)(sym),		\
+			    __start_runtime_##type##_##sym,	\
+			    __stop_runtime_##type##_##sym);	\
+} while (0)
+
+static inline void __runtime_fixup_caches(void *where, unsigned int insns)
+{
+	/* On riscv there are currently only cache-wide flushes so va is ignored. */
+	__always_unused uintptr_t va = (uintptr_t)where;
+
+	flush_icache_range(va, va + 4*insns);
+}
+
+/*
+ * The 32-bit immediate is stored in a lui+addi pairing.
+ * lui holds the upper 20 bits of the immediate in the first 20 bits of the instruction.
+ * addi holds the lower 12 bits of the immediate in the first 12 bits of the instruction.
+ */
+static inline void __runtime_fixup_32(__le16 *lui_parcel, __le16 *addi_parcel, unsigned int val)
+{
+	unsigned int lower_immediate, upper_immediate;
+	__le32 lui_res, addi_res;
+	u32 lui_insn, addi_insn;
+
+	lui_insn = (u32)le16_to_cpu(lui_parcel[0]) | (u32)le16_to_cpu(lui_parcel[1]) << 16;
+	addi_insn = (u32)le16_to_cpu(addi_parcel[0]) | (u32)le16_to_cpu(addi_parcel[1]) << 16;
+
+	lower_immediate = sign_extend32(val, 11);
+	upper_immediate = (val - lower_immediate);
+
+	if (upper_immediate & 0xfffff000) {
+		/* replace upper 20 bits of lui with upper immediate */
+		lui_insn &= 0x00000fff;
+		lui_insn |= upper_immediate & 0xfffff000;
+	} else {
+		/* replace lui with nop if immediate is small enough to fit in addi */
+		lui_insn = 0x00000013;
+	}
+
+	if (lower_immediate & 0x00000fff) {
+		/* replace upper 12 bits of addi with lower 12 bits of val */
+		addi_insn &= 0x000fffff;
+		addi_insn |= (lower_immediate & 0x00000fff) << 20;
+	} else {
+		/* replace addi with nop if lower_immediate is empty */
+		addi_insn = 0x00000013;
+	}
+
+	addi_res = cpu_to_le32(addi_insn);
+	lui_res = cpu_to_le32(lui_insn);
+	patch_insn_write(addi_parcel, &addi_res, sizeof(addi_res));
+	patch_insn_write(lui_parcel, &lui_res, sizeof(lui_res));
+}
+
+static inline void __runtime_fixup_ptr(void *where, unsigned long val)
+{
+#ifdef CONFIG_32BIT
+		__runtime_fixup_32(where, where + 4, val);
+		__runtime_fixup_caches(where, 2);
+#else
+		__runtime_fixup_32(where, where + 8, val);
+		__runtime_fixup_32(where + 4, where + 12, val >> 32);
+		__runtime_fixup_caches(where, 4);
+#endif
+}
+
+/*
+ * Replace the least significant 5 bits of the srli/srliw immediate that is
+ * located at bits 20-24
+ */
+static inline void __runtime_fixup_shift(void *where, unsigned long val)
+{
+	__le16 *parcel = where;
+	__le32 res;
+	u32 insn;
+
+	insn = (u32)le16_to_cpu(parcel[0]) | (u32)le16_to_cpu(parcel[1]) << 16;
+
+	insn &= 0xfe0fffff;
+	insn |= (val & 0b11111) << 20;
+
+	res = cpu_to_le32(insn);
+	patch_text_nosync(where, &res, sizeof(insn));
+}
+
+static inline void runtime_const_fixup(void (*fn)(void *, unsigned long),
+				       unsigned long val, s32 *start, s32 *end)
+{
+	while (start < end) {
+		fn(*start + (void *)start, val);
+		start++;
+	}
+}
+
+#endif /* _ASM_RISCV_RUNTIME_CONST_H */
diff --git a/arch/riscv/kernel/vmlinux.lds.S b/arch/riscv/kernel/vmlinux.lds.S
index 002ca58dd998cb78b662837b5ebac988fb6c77bb..61bd5ba6680a786bf1db7dc37bf1acda0639b5c7 100644
--- a/arch/riscv/kernel/vmlinux.lds.S
+++ b/arch/riscv/kernel/vmlinux.lds.S
@@ -97,6 +97,9 @@ SECTIONS
 	{
 		EXIT_DATA
 	}
+
+	RUNTIME_CONST_VARIABLES
+
 	PERCPU_SECTION(L1_CACHE_BYTES)
 
 	.rel.dyn : {

---
base-commit: ffd294d346d185b70e28b1a28abe367bbfe53c04
change-id: 20250123-runtime_const_riscv-6cd854ee2817
-- 
- Charlie
Re: [PATCH v5] riscv: Add runtime constant support
Posted by kernel test robot 12 months ago
Hi Charlie,

kernel test robot noticed the following build errors:

[auto build test ERROR on ffd294d346d185b70e28b1a28abe367bbfe53c04]

url:    https://github.com/intel-lab-lkp/linux/commits/Charlie-Jenkins/riscv-Add-runtime-constant-support/20250204-044527
base:   ffd294d346d185b70e28b1a28abe367bbfe53c04
patch link:    https://lore.kernel.org/r/20250203-runtime_const_riscv-v5-1-bc61736a3229%40rivosinc.com
patch subject: [PATCH v5] riscv: Add runtime constant support
config: riscv-randconfig-r072-20250212 (https://download.01.org/0day-ci/archive/20250212/202502120355.WlAf0wvw-lkp@intel.com/config)
compiler: clang version 15.0.7 (https://github.com/llvm/llvm-project 8dfdcc7b7bf66834a761bd8de445840ef68e4d1a)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250212/202502120355.WlAf0wvw-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202502120355.WlAf0wvw-lkp@intel.com/

All error/warnings (new ones prefixed by >>):

>> fs/dcache.c:112:9: warning: unknown option, expected 'push', 'pop', 'rvc', 'norvc', 'relax' or 'norelax' [-Winline-asm]
           return runtime_const_ptr(dentry_hashtable) +
                  ^
   arch/riscv/include/asm/runtime-const.h:52:19: note: expanded from macro 'runtime_const_ptr'
                           ".option push\n\t"                              \
                                          ^
   <inline asm>:32:10: note: instantiated into assembly here
           .option arch,+zba
                   ^
>> fs/dcache.c:112:9: error: instruction requires the following: 'Zba' (Address Generation Instructions)
           return runtime_const_ptr(dentry_hashtable) +
                  ^
   arch/riscv/include/asm/runtime-const.h:54:32: note: expanded from macro 'runtime_const_ptr'
                           "slli   %[__tmp],%[__tmp],32\n\t"               \
                                                         ^
   <inline asm>:34:2: note: instantiated into assembly here
           add.uw a1,a1,a3
           ^
>> fs/dcache.c:112:9: warning: unknown option, expected 'push', 'pop', 'rvc', 'norvc', 'relax' or 'norelax' [-Winline-asm]
           return runtime_const_ptr(dentry_hashtable) +
                  ^
   arch/riscv/include/asm/runtime-const.h:60:19: note: expanded from macro 'runtime_const_ptr'
                           ".option push\n\t"                              \
                                          ^
   <inline asm>:59:10: note: instantiated into assembly here
           .option arch,+zbkb
                   ^
>> fs/dcache.c:112:9: error: instruction requires the following: 'Zbp' (Permutation 'Zb' Instructions) or 'Zbkb' (Bitmanip instructions for Cryptography)
           return runtime_const_ptr(dentry_hashtable) +
                  ^
   arch/riscv/include/asm/runtime-const.h:61:25: note: expanded from macro 'runtime_const_ptr'
                           ".option arch,+zbkb\n\t"                        \
                                                ^
   <inline asm>:60:2: note: instantiated into assembly here
           pack    a1,a1,a3
           ^
>> fs/dcache.c:112:9: warning: unknown option, expected 'push', 'pop', 'rvc', 'norvc', 'relax' or 'norelax' [-Winline-asm]
           return runtime_const_ptr(dentry_hashtable) +
                  ^
   arch/riscv/include/asm/runtime-const.h:52:19: note: expanded from macro 'runtime_const_ptr'
                           ".option push\n\t"                              \
                                          ^
   <inline asm>:32:10: note: instantiated into assembly here
           .option arch,+zba
                   ^
>> fs/dcache.c:112:9: error: instruction requires the following: 'Zba' (Address Generation Instructions)
           return runtime_const_ptr(dentry_hashtable) +
                  ^
   arch/riscv/include/asm/runtime-const.h:54:32: note: expanded from macro 'runtime_const_ptr'
                           "slli   %[__tmp],%[__tmp],32\n\t"               \
                                                         ^
   <inline asm>:34:2: note: instantiated into assembly here
           add.uw a3,a3,a4
           ^
>> fs/dcache.c:112:9: warning: unknown option, expected 'push', 'pop', 'rvc', 'norvc', 'relax' or 'norelax' [-Winline-asm]
           return runtime_const_ptr(dentry_hashtable) +
                  ^
   arch/riscv/include/asm/runtime-const.h:60:19: note: expanded from macro 'runtime_const_ptr'
                           ".option push\n\t"                              \
                                          ^
   <inline asm>:59:10: note: instantiated into assembly here
           .option arch,+zbkb
                   ^
>> fs/dcache.c:112:9: error: instruction requires the following: 'Zbp' (Permutation 'Zb' Instructions) or 'Zbkb' (Bitmanip instructions for Cryptography)
           return runtime_const_ptr(dentry_hashtable) +
                  ^
   arch/riscv/include/asm/runtime-const.h:61:25: note: expanded from macro 'runtime_const_ptr'
                           ".option arch,+zbkb\n\t"                        \
                                                ^
   <inline asm>:60:2: note: instantiated into assembly here
           pack    a3,a3,a4
           ^
>> fs/dcache.c:112:9: warning: unknown option, expected 'push', 'pop', 'rvc', 'norvc', 'relax' or 'norelax' [-Winline-asm]
           return runtime_const_ptr(dentry_hashtable) +
                  ^
   arch/riscv/include/asm/runtime-const.h:52:19: note: expanded from macro 'runtime_const_ptr'
                           ".option push\n\t"                              \
                                          ^
   <inline asm>:32:10: note: instantiated into assembly here
           .option arch,+zba
                   ^
>> fs/dcache.c:112:9: error: instruction requires the following: 'Zba' (Address Generation Instructions)
           return runtime_const_ptr(dentry_hashtable) +
                  ^
   arch/riscv/include/asm/runtime-const.h:54:32: note: expanded from macro 'runtime_const_ptr'
                           "slli   %[__tmp],%[__tmp],32\n\t"               \
                                                         ^
   <inline asm>:34:2: note: instantiated into assembly here
           add.uw a0,a0,a1
           ^
>> fs/dcache.c:112:9: warning: unknown option, expected 'push', 'pop', 'rvc', 'norvc', 'relax' or 'norelax' [-Winline-asm]
           return runtime_const_ptr(dentry_hashtable) +
                  ^
   arch/riscv/include/asm/runtime-const.h:60:19: note: expanded from macro 'runtime_const_ptr'
                           ".option push\n\t"                              \
                                          ^
   <inline asm>:59:10: note: instantiated into assembly here
           .option arch,+zbkb
                   ^
>> fs/dcache.c:112:9: error: instruction requires the following: 'Zbp' (Permutation 'Zb' Instructions) or 'Zbkb' (Bitmanip instructions for Cryptography)
           return runtime_const_ptr(dentry_hashtable) +
                  ^
   arch/riscv/include/asm/runtime-const.h:61:25: note: expanded from macro 'runtime_const_ptr'
                           ".option arch,+zbkb\n\t"                        \
                                                ^
   <inline asm>:60:2: note: instantiated into assembly here
           pack    a0,a0,a1
           ^
>> fs/dcache.c:112:9: warning: unknown option, expected 'push', 'pop', 'rvc', 'norvc', 'relax' or 'norelax' [-Winline-asm]
           return runtime_const_ptr(dentry_hashtable) +
                  ^
   arch/riscv/include/asm/runtime-const.h:52:19: note: expanded from macro 'runtime_const_ptr'
                           ".option push\n\t"                              \
                                          ^
   <inline asm>:32:10: note: instantiated into assembly here
           .option arch,+zba
                   ^
>> fs/dcache.c:112:9: error: instruction requires the following: 'Zba' (Address Generation Instructions)
           return runtime_const_ptr(dentry_hashtable) +
                  ^
   arch/riscv/include/asm/runtime-const.h:54:32: note: expanded from macro 'runtime_const_ptr'
                           "slli   %[__tmp],%[__tmp],32\n\t"               \
                                                         ^
   <inline asm>:34:2: note: instantiated into assembly here
           add.uw a1,a1,a2
           ^
>> fs/dcache.c:112:9: warning: unknown option, expected 'push', 'pop', 'rvc', 'norvc', 'relax' or 'norelax' [-Winline-asm]
           return runtime_const_ptr(dentry_hashtable) +
                  ^
   arch/riscv/include/asm/runtime-const.h:60:19: note: expanded from macro 'runtime_const_ptr'
                           ".option push\n\t"                              \
                                          ^
   <inline asm>:59:10: note: instantiated into assembly here
           .option arch,+zbkb
                   ^
>> fs/dcache.c:112:9: error: instruction requires the following: 'Zbp' (Permutation 'Zb' Instructions) or 'Zbkb' (Bitmanip instructions for Cryptography)
           return runtime_const_ptr(dentry_hashtable) +
                  ^
   arch/riscv/include/asm/runtime-const.h:61:25: note: expanded from macro 'runtime_const_ptr'
                           ".option arch,+zbkb\n\t"                        \
                                                ^
   <inline asm>:60:2: note: instantiated into assembly here
           pack    a1,a1,a2
           ^
>> fs/dcache.c:112:9: error: invalid .org offset '21034' (at offset '21038')
           return runtime_const_ptr(dentry_hashtable) +
                  ^
   arch/riscv/include/asm/runtime-const.h:47:3: note: expanded from macro 'runtime_const_ptr'
                   ALTERNATIVE_2(                                          \
                   ^
   arch/riscv/include/asm/alternative-macros.h:163:2: note: expanded from macro 'ALTERNATIVE_2'
           _ALTERNATIVE_CFG_2(old_content, new_content_1, vendor_id_1, patch_id_1, CONFIG_k_1,     \
           ^
   arch/riscv/include/asm/alternative-macros.h:108:2: note: expanded from macro '_ALTERNATIVE_CFG_2'
           __ALTERNATIVE_CFG_2(old_c, new_c_1, vendor_id_1, patch_id_1, IS_ENABLED(CONFIG_k_1),    \
           ^
   arch/riscv/include/asm/alternative-macros.h:98:2: note: expanded from macro '__ALTERNATIVE_CFG_2'
           __ALTERNATIVE_CFG(old_c, new_c_1, vendor_id_1, patch_id_1, enable_1)    \
           ^
   arch/riscv/include/asm/alternative-macros.h:94:2: note: expanded from macro '__ALTERNATIVE_CFG'
           ALT_NEW_CONTENT(vendor_id, patch_id, enable, new_c)
           ^
   arch/riscv/include/asm/alternative-macros.h:81:3: note: expanded from macro 'ALT_NEW_CONTENT'
           ".org   . - (887b - 886b) + (889b - 888b)\n"                    \
            ^
   <inline asm>:41:6: note: instantiated into assembly here
   .org    . - (887b - 886b) + (889b - 888b)
           ^
   fs/dcache.c:112:9: error: invalid .org offset '21050' (at offset '21054')
           return runtime_const_ptr(dentry_hashtable) +
                  ^
   arch/riscv/include/asm/runtime-const.h:47:3: note: expanded from macro 'runtime_const_ptr'
                   ALTERNATIVE_2(                                          \
                   ^
   arch/riscv/include/asm/alternative-macros.h:163:2: note: expanded from macro 'ALTERNATIVE_2'
           _ALTERNATIVE_CFG_2(old_content, new_content_1, vendor_id_1, patch_id_1, CONFIG_k_1,     \
           ^
   arch/riscv/include/asm/alternative-macros.h:108:2: note: expanded from macro '_ALTERNATIVE_CFG_2'
           __ALTERNATIVE_CFG_2(old_c, new_c_1, vendor_id_1, patch_id_1, IS_ENABLED(CONFIG_k_1),    \
           ^
   arch/riscv/include/asm/alternative-macros.h:99:2: note: expanded from macro '__ALTERNATIVE_CFG_2'
           ALT_NEW_CONTENT(vendor_id_2, patch_id_2, enable_2, new_c_2)
           ^
   arch/riscv/include/asm/alternative-macros.h:81:3: note: expanded from macro 'ALT_NEW_CONTENT'
           ".org   . - (887b - 886b) + (889b - 888b)\n"                    \
            ^
   <inline asm>:68:6: note: instantiated into assembly here
   .org    . - (887b - 886b) + (889b - 888b)
           ^
   fs/dcache.c:112:9: error: invalid .org offset '21066' (at offset '21070')
           return runtime_const_ptr(dentry_hashtable) +
                  ^
   arch/riscv/include/asm/runtime-const.h:47:3: note: expanded from macro 'runtime_const_ptr'
                   ALTERNATIVE_2(                                          \
                   ^
   arch/riscv/include/asm/alternative-macros.h:163:2: note: expanded from macro 'ALTERNATIVE_2'
           _ALTERNATIVE_CFG_2(old_content, new_content_1, vendor_id_1, patch_id_1, CONFIG_k_1,     \
           ^
   arch/riscv/include/asm/alternative-macros.h:108:2: note: expanded from macro '_ALTERNATIVE_CFG_2'
           __ALTERNATIVE_CFG_2(old_c, new_c_1, vendor_id_1, patch_id_1, IS_ENABLED(CONFIG_k_1),    \
           ^
   arch/riscv/include/asm/alternative-macros.h:98:2: note: expanded from macro '__ALTERNATIVE_CFG_2'
           __ALTERNATIVE_CFG(old_c, new_c_1, vendor_id_1, patch_id_1, enable_1)    \
           ^
   arch/riscv/include/asm/alternative-macros.h:94:2: note: expanded from macro '__ALTERNATIVE_CFG'
           ALT_NEW_CONTENT(vendor_id, patch_id, enable, new_c)
           ^
   arch/riscv/include/asm/alternative-macros.h:81:3: note: expanded from macro 'ALT_NEW_CONTENT'
           ".org   . - (887b - 886b) + (889b - 888b)\n"                    \
            ^
   <inline asm>:41:6: note: instantiated into assembly here
   .org    . - (887b - 886b) + (889b - 888b)
           ^
   fs/dcache.c:112:9: error: invalid .org offset '21082' (at offset '21086')
           return runtime_const_ptr(dentry_hashtable) +
                  ^
   arch/riscv/include/asm/runtime-const.h:47:3: note: expanded from macro 'runtime_const_ptr'
                   ALTERNATIVE_2(                                          \
                   ^
   arch/riscv/include/asm/alternative-macros.h:163:2: note: expanded from macro 'ALTERNATIVE_2'
           _ALTERNATIVE_CFG_2(old_content, new_content_1, vendor_id_1, patch_id_1, CONFIG_k_1,     \
           ^
   arch/riscv/include/asm/alternative-macros.h:108:2: note: expanded from macro '_ALTERNATIVE_CFG_2'
           __ALTERNATIVE_CFG_2(old_c, new_c_1, vendor_id_1, patch_id_1, IS_ENABLED(CONFIG_k_1),    \
           ^
   arch/riscv/include/asm/alternative-macros.h:99:2: note: expanded from macro '__ALTERNATIVE_CFG_2'
           ALT_NEW_CONTENT(vendor_id_2, patch_id_2, enable_2, new_c_2)
           ^
   arch/riscv/include/asm/alternative-macros.h:81:3: note: expanded from macro 'ALT_NEW_CONTENT'
           ".org   . - (887b - 886b) + (889b - 888b)\n"                    \
            ^
   <inline asm>:68:6: note: instantiated into assembly here
   .org    . - (887b - 886b) + (889b - 888b)
           ^
   fs/dcache.c:112:9: error: invalid .org offset '21098' (at offset '21102')
           return runtime_const_ptr(dentry_hashtable) +
                  ^
   arch/riscv/include/asm/runtime-const.h:47:3: note: expanded from macro 'runtime_const_ptr'
                   ALTERNATIVE_2(                                          \
                   ^
   arch/riscv/include/asm/alternative-macros.h:163:2: note: expanded from macro 'ALTERNATIVE_2'
           _ALTERNATIVE_CFG_2(old_content, new_content_1, vendor_id_1, patch_id_1, CONFIG_k_1,     \
           ^
   arch/riscv/include/asm/alternative-macros.h:108:2: note: expanded from macro '_ALTERNATIVE_CFG_2'
           __ALTERNATIVE_CFG_2(old_c, new_c_1, vendor_id_1, patch_id_1, IS_ENABLED(CONFIG_k_1),    \
           ^
   arch/riscv/include/asm/alternative-macros.h:98:2: note: expanded from macro '__ALTERNATIVE_CFG_2'
           __ALTERNATIVE_CFG(old_c, new_c_1, vendor_id_1, patch_id_1, enable_1)    \
           ^
   arch/riscv/include/asm/alternative-macros.h:94:2: note: expanded from macro '__ALTERNATIVE_CFG'
           ALT_NEW_CONTENT(vendor_id, patch_id, enable, new_c)
           ^
   arch/riscv/include/asm/alternative-macros.h:81:3: note: expanded from macro 'ALT_NEW_CONTENT'
           ".org   . - (887b - 886b) + (889b - 888b)\n"                    \
            ^
   <inline asm>:41:6: note: instantiated into assembly here
   .org    . - (887b - 886b) + (889b - 888b)
           ^
   fs/dcache.c:112:9: error: invalid .org offset '21114' (at offset '21118')
           return runtime_const_ptr(dentry_hashtable) +
                  ^
   arch/riscv/include/asm/runtime-const.h:47:3: note: expanded from macro 'runtime_const_ptr'
                   ALTERNATIVE_2(                                          \
                   ^
   arch/riscv/include/asm/alternative-macros.h:163:2: note: expanded from macro 'ALTERNATIVE_2'
           _ALTERNATIVE_CFG_2(old_content, new_content_1, vendor_id_1, patch_id_1, CONFIG_k_1,     \
           ^
   arch/riscv/include/asm/alternative-macros.h:108:2: note: expanded from macro '_ALTERNATIVE_CFG_2'
           __ALTERNATIVE_CFG_2(old_c, new_c_1, vendor_id_1, patch_id_1, IS_ENABLED(CONFIG_k_1),    \
           ^
   arch/riscv/include/asm/alternative-macros.h:99:2: note: expanded from macro '__ALTERNATIVE_CFG_2'
           ALT_NEW_CONTENT(vendor_id_2, patch_id_2, enable_2, new_c_2)
           ^
   arch/riscv/include/asm/alternative-macros.h:81:3: note: expanded from macro 'ALT_NEW_CONTENT'
           ".org   . - (887b - 886b) + (889b - 888b)\n"                    \
            ^
   <inline asm>:68:6: note: instantiated into assembly here
   .org    . - (887b - 886b) + (889b - 888b)
           ^
   fs/dcache.c:112:9: error: invalid .org offset '21130' (at offset '21134')
           return runtime_const_ptr(dentry_hashtable) +
                  ^
   arch/riscv/include/asm/runtime-const.h:47:3: note: expanded from macro 'runtime_const_ptr'
                   ALTERNATIVE_2(                                          \
                   ^
   arch/riscv/include/asm/alternative-macros.h:163:2: note: expanded from macro 'ALTERNATIVE_2'
           _ALTERNATIVE_CFG_2(old_content, new_content_1, vendor_id_1, patch_id_1, CONFIG_k_1,     \
           ^
   arch/riscv/include/asm/alternative-macros.h:108:2: note: expanded from macro '_ALTERNATIVE_CFG_2'
           __ALTERNATIVE_CFG_2(old_c, new_c_1, vendor_id_1, patch_id_1, IS_ENABLED(CONFIG_k_1),    \
           ^
   arch/riscv/include/asm/alternative-macros.h:98:2: note: expanded from macro '__ALTERNATIVE_CFG_2'
           __ALTERNATIVE_CFG(old_c, new_c_1, vendor_id_1, patch_id_1, enable_1)    \
           ^
   arch/riscv/include/asm/alternative-macros.h:94:2: note: expanded from macro '__ALTERNATIVE_CFG'
           ALT_NEW_CONTENT(vendor_id, patch_id, enable, new_c)
           ^
   arch/riscv/include/asm/alternative-macros.h:81:3: note: expanded from macro 'ALT_NEW_CONTENT'
           ".org   . - (887b - 886b) + (889b - 888b)\n"                    \
            ^
   <inline asm>:41:6: note: instantiated into assembly here
   .org    . - (887b - 886b) + (889b - 888b)
           ^
   fs/dcache.c:112:9: error: invalid .org offset '21146' (at offset '21150')
           return runtime_const_ptr(dentry_hashtable) +
                  ^
   arch/riscv/include/asm/runtime-const.h:47:3: note: expanded from macro 'runtime_const_ptr'
                   ALTERNATIVE_2(                                          \
                   ^
   arch/riscv/include/asm/alternative-macros.h:163:2: note: expanded from macro 'ALTERNATIVE_2'
           _ALTERNATIVE_CFG_2(old_content, new_content_1, vendor_id_1, patch_id_1, CONFIG_k_1,     \
           ^
   arch/riscv/include/asm/alternative-macros.h:108:2: note: expanded from macro '_ALTERNATIVE_CFG_2'
           __ALTERNATIVE_CFG_2(old_c, new_c_1, vendor_id_1, patch_id_1, IS_ENABLED(CONFIG_k_1),    \
           ^
   arch/riscv/include/asm/alternative-macros.h:99:2: note: expanded from macro '__ALTERNATIVE_CFG_2'
           ALT_NEW_CONTENT(vendor_id_2, patch_id_2, enable_2, new_c_2)
           ^
   arch/riscv/include/asm/alternative-macros.h:81:3: note: expanded from macro 'ALT_NEW_CONTENT'
           ".org   . - (887b - 886b) + (889b - 888b)\n"                    \
            ^
   <inline asm>:68:6: note: instantiated into assembly here
   .org    . - (887b - 886b) + (889b - 888b)
           ^
>> fs/dcache.c:112:9: error: invalid .org offset '21034' (at offset '21038')
           return runtime_const_ptr(dentry_hashtable) +
                  ^
   arch/riscv/include/asm/runtime-const.h:47:3: note: expanded from macro 'runtime_const_ptr'
                   ALTERNATIVE_2(                                          \
                   ^
   arch/riscv/include/asm/alternative-macros.h:163:2: note: expanded from macro 'ALTERNATIVE_2'
           _ALTERNATIVE_CFG_2(old_content, new_content_1, vendor_id_1, patch_id_1, CONFIG_k_1,     \
           ^
   arch/riscv/include/asm/alternative-macros.h:108:2: note: expanded from macro '_ALTERNATIVE_CFG_2'
           __ALTERNATIVE_CFG_2(old_c, new_c_1, vendor_id_1, patch_id_1, IS_ENABLED(CONFIG_k_1),    \
           ^
   arch/riscv/include/asm/alternative-macros.h:98:2: note: expanded from macro '__ALTERNATIVE_CFG_2'
           __ALTERNATIVE_CFG(old_c, new_c_1, vendor_id_1, patch_id_1, enable_1)    \
           ^
   arch/riscv/include/asm/alternative-macros.h:94:2: note: expanded from macro '__ALTERNATIVE_CFG'
           ALT_NEW_CONTENT(vendor_id, patch_id, enable, new_c)
           ^
   arch/riscv/include/asm/alternative-macros.h:81:3: note: expanded from macro 'ALT_NEW_CONTENT'
           ".org   . - (887b - 886b) + (889b - 888b)\n"                    \
            ^
   <inline asm>:41:6: note: instantiated into assembly here
   .org    . - (887b - 886b) + (889b - 888b)
           ^
   fs/dcache.c:112:9: error: invalid .org offset '21050' (at offset '21054')
           return runtime_const_ptr(dentry_hashtable) +
                  ^
   arch/riscv/include/asm/runtime-const.h:47:3: note: expanded from macro 'runtime_const_ptr'
                   ALTERNATIVE_2(                                          \
                   ^
   arch/riscv/include/asm/alternative-macros.h:163:2: note: expanded from macro 'ALTERNATIVE_2'
           _ALTERNATIVE_CFG_2(old_content, new_content_1, vendor_id_1, patch_id_1, CONFIG_k_1,     \
           ^
   arch/riscv/include/asm/alternative-macros.h:108:2: note: expanded from macro '_ALTERNATIVE_CFG_2'
           __ALTERNATIVE_CFG_2(old_c, new_c_1, vendor_id_1, patch_id_1, IS_ENABLED(CONFIG_k_1),    \
           ^
   arch/riscv/include/asm/alternative-macros.h:99:2: note: expanded from macro '__ALTERNATIVE_CFG_2'
           ALT_NEW_CONTENT(vendor_id_2, patch_id_2, enable_2, new_c_2)
           ^
   arch/riscv/include/asm/alternative-macros.h:81:3: note: expanded from macro 'ALT_NEW_CONTENT'
           ".org   . - (887b - 886b) + (889b - 888b)\n"                    \
            ^
   <inline asm>:68:6: note: instantiated into assembly here
   .org    . - (887b - 886b) + (889b - 888b)
           ^
   fs/dcache.c:112:9: error: invalid .org offset '21066' (at offset '21070')
           return runtime_const_ptr(dentry_hashtable) +
                  ^
   arch/riscv/include/asm/runtime-const.h:47:3: note: expanded from macro 'runtime_const_ptr'
                   ALTERNATIVE_2(                                          \
                   ^
   arch/riscv/include/asm/alternative-macros.h:163:2: note: expanded from macro 'ALTERNATIVE_2'
           _ALTERNATIVE_CFG_2(old_content, new_content_1, vendor_id_1, patch_id_1, CONFIG_k_1,     \
           ^
   arch/riscv/include/asm/alternative-macros.h:108:2: note: expanded from macro '_ALTERNATIVE_CFG_2'
           __ALTERNATIVE_CFG_2(old_c, new_c_1, vendor_id_1, patch_id_1, IS_ENABLED(CONFIG_k_1),    \
           ^
   arch/riscv/include/asm/alternative-macros.h:98:2: note: expanded from macro '__ALTERNATIVE_CFG_2'
           __ALTERNATIVE_CFG(old_c, new_c_1, vendor_id_1, patch_id_1, enable_1)    \
           ^
   arch/riscv/include/asm/alternative-macros.h:94:2: note: expanded from macro '__ALTERNATIVE_CFG'
           ALT_NEW_CONTENT(vendor_id, patch_id, enable, new_c)
           ^
   arch/riscv/include/asm/alternative-macros.h:81:3: note: expanded from macro 'ALT_NEW_CONTENT'
           ".org   . - (887b - 886b) + (889b - 888b)\n"                    \
            ^
   <inline asm>:41:6: note: instantiated into assembly here
   .org    . - (887b - 886b) + (889b - 888b)
           ^
   fatal error: too many errors emitted, stopping now [-ferror-limit=]
   8 warnings and 20 errors generated.


vim +/Zba +112 fs/dcache.c

ceb5bdc2d246f6 Nicholas Piggin 2011-01-07  109  
e60cc61153e61e Linus Torvalds  2024-06-10  110  static inline struct hlist_bl_head *d_hash(unsigned long hashlen)
ceb5bdc2d246f6 Nicholas Piggin 2011-01-07  111  {
e78298556ee5d8 Linus Torvalds  2024-06-04 @112  	return runtime_const_ptr(dentry_hashtable) +
e78298556ee5d8 Linus Torvalds  2024-06-04  113  		runtime_const_shift_right_32(hashlen, d_hash_shift);
ceb5bdc2d246f6 Nicholas Piggin 2011-01-07  114  }
ceb5bdc2d246f6 Nicholas Piggin 2011-01-07  115  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki