[PATCH v4 2/2] mfd: cgbc: add a hwmon cell

Thomas Richard posted 2 patches 10 months, 2 weeks ago
[PATCH v4 2/2] mfd: cgbc: add a hwmon cell
Posted by Thomas Richard 10 months, 2 weeks ago
The Board Controller has some internal sensors.
Add a hwmon cell for the cgbc-hwmon driver which adds support for
temperature, voltage, current and fan sensors.

Signed-off-by: Thomas Richard <thomas.richard@bootlin.com>
---
 drivers/mfd/cgbc-core.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/mfd/cgbc-core.c b/drivers/mfd/cgbc-core.c
index 85283c8dde25..0460e4e3f3c5 100644
--- a/drivers/mfd/cgbc-core.c
+++ b/drivers/mfd/cgbc-core.c
@@ -236,6 +236,7 @@ static struct mfd_cell cgbc_devs[] = {
 	{ .name = "cgbc-gpio"	},
 	{ .name = "cgbc-i2c", .id = 1 },
 	{ .name = "cgbc-i2c", .id = 2 },
+	{ .name = "cgbc-hwmon"	},
 };
 
 static int cgbc_map(struct cgbc_device_data *cgbc)

-- 
2.39.5
Re: [PATCH v4 2/2] mfd: cgbc: add a hwmon cell
Posted by Lee Jones 10 months, 1 week ago
If you resubmit this set, please capitalise the first char in the
subject line after the driver identifiers.

> The Board Controller has some internal sensors.
> Add a hwmon cell for the cgbc-hwmon driver which adds support for
> temperature, voltage, current and fan sensors.

Generally fine.

Line-breaking just for a new sentence is an odd choice though.

> Signed-off-by: Thomas Richard <thomas.richard@bootlin.com>
> ---
>  drivers/mfd/cgbc-core.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/mfd/cgbc-core.c b/drivers/mfd/cgbc-core.c
> index 85283c8dde25..0460e4e3f3c5 100644
> --- a/drivers/mfd/cgbc-core.c
> +++ b/drivers/mfd/cgbc-core.c
> @@ -236,6 +236,7 @@ static struct mfd_cell cgbc_devs[] = {
>  	{ .name = "cgbc-gpio"	},
>  	{ .name = "cgbc-i2c", .id = 1 },
>  	{ .name = "cgbc-i2c", .id = 2 },
> +	{ .name = "cgbc-hwmon"	},
>  };
>  
>  static int cgbc_map(struct cgbc_device_data *cgbc)
> 
> -- 
> 2.39.5
> 

-- 
Lee Jones [李琼斯]
Re: (subset) [PATCH v4 2/2] mfd: cgbc: add a hwmon cell
Posted by Lee Jones 9 months ago
On Mon, 03 Feb 2025 12:01:06 +0100, Thomas Richard wrote:
> The Board Controller has some internal sensors.
> Add a hwmon cell for the cgbc-hwmon driver which adds support for
> temperature, voltage, current and fan sensors.
> 
> 

Applied, thanks!

[2/2] mfd: cgbc: add a hwmon cell
      commit: 6672baa795851fac209135f2ee24643280e1d017

--
Lee Jones [李琼斯]