When __GFP_DIRECT_RECLAIM (included in GFP_NOIO) is specified,
bio_alloc_bioset() never fails to allocate a bio. For more details, see
the comment in bio_alloc_bioset() in block/bio.c

Signed-off-by: Kohei Enju <enjuk@amazon.com>
---
 drivers/target/target_core_iblock.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/target/target_core_iblock.c b/drivers/target/target_core_iblock.c
index c8dc92a7d63e..9ef23eea55e7 100644
--- a/drivers/target/target_core_iblock.c
+++ b/drivers/target/target_core_iblock.c
@@ -369,10 +369,6 @@ static struct bio *iblock_get_bio(struct se_cmd *cmd, sector_t lba, u32 sg_num,
 	 */
 	bio = bio_alloc_bioset(ib_dev->ibd_bd, bio_max_segs(sg_num), opf,
 			       GFP_NOIO, &ib_dev->ibd_bio_set);
-	if (!bio) {
-		pr_err("Unable to allocate memory for bio\n");
-		return NULL;
-	}
 
 	bio->bi_private = cmd;
 	bio->bi_end_io = &iblock_bio_done;
-- 
2.39.5 (Apple Git-154)

> When __GFP_DIRECT_RECLAIM (included in GFP_NOIO) is specified,
> bio_alloc_bioset() never fails to allocate a bio. For more details, see
> the comment in bio_alloc_bioset() in block/bio.c

See also:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.13#n94


Can a blank line be also omitted together with the mentioned compound statement?

Regards,
Markus

> > When __GFP_DIRECT_RECLAIM (included in GFP_NOIO) is specified,
> > bio_alloc_bioset() never fails to allocate a bio. For more details, see
> > the comment in bio_alloc_bioset() in block/bio.c
> 
> See also:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.13#n94

Thanks. I'll modify the commit message into imperative mood.

> Can a blank line be also omitted together with the mentioned compound statement?

Sure, I think so. 
I'll submit a v2 patch with the modified commit message and without the blank line.

Regards,
Kohei