platform/x86/intel/ifs: Update documentation with image download path

[PATCH] platform/x86/intel/ifs: Update documentation with image download path

Posted by Jithu Joseph 1 year ago

The documentation previously listed the path to download In Field Scan
(IFS) test images as "TBD".

Update the documentation to include the correct image download location.
Also move the download link to the appropriate section within the doc.

Signed-off-by: Jithu Joseph <jithu.joseph@intel.com>
---
 drivers/platform/x86/intel/ifs/ifs.h | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/drivers/platform/x86/intel/ifs/ifs.h b/drivers/platform/x86/intel/ifs/ifs.h
index 5c3c0dfa1bf8..41fc21e7ef14 100644
--- a/drivers/platform/x86/intel/ifs/ifs.h
+++ b/drivers/platform/x86/intel/ifs/ifs.h
@@ -23,12 +23,14 @@
  * IFS Image
  * ---------
  *
- * Intel provides a firmware file containing the scan tests via
- * github [#f1]_.  Similar to microcode there is a separate file for each
+ * Intel provides firmware files containing the scan tests via the webpage [#f1]_.
+ * Look under "In-Field Scan Test Images Download" section towards the
+ * end of the page. Similar to microcode there are separate files for each
  * family-model-stepping. IFS Images are not applicable for some test types.
  * Wherever applicable the sysfs directory would provide a "current_batch" file
  * (see below) for loading the image.
  *
+ * .. [#f1] https://intel.com/InFieldScan
  *
  * IFS Image Loading
  * -----------------
@@ -125,9 +127,6 @@
  * 2) Hardware allows for some number of cores to be tested in parallel.
  * The driver does not make use of this, it only tests one core at a time.
  *
- * .. [#f1] https://github.com/intel/TBD
- *
- *
  * Structural Based Functional Test at Field (SBAF):
  * -------------------------------------------------
  *

base-commit: ffd294d346d185b70e28b1a28abe367bbfe53c04
-- 
2.34.1

Re: [PATCH] platform/x86/intel/ifs: Update documentation with image download path

Posted by Ilpo Järvinen 1 year ago

On Fri, 31 Jan 2025, Jithu Joseph wrote:

> The documentation previously listed the path to download In Field Scan
> (IFS) test images as "TBD".
> 
> Update the documentation to include the correct image download location.
> Also move the download link to the appropriate section within the doc.
> 
> Signed-off-by: Jithu Joseph <jithu.joseph@intel.com>

I've applied this patch into the fixes branch with Anisse added as
Reported-by.

Thanks Anisse for raising this issue and Jithu for getting the gears 
moving to provide an useful resolution.

> ---
>  drivers/platform/x86/intel/ifs/ifs.h | 9 ++++-----
>  1 file changed, 4 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/platform/x86/intel/ifs/ifs.h b/drivers/platform/x86/intel/ifs/ifs.h
> index 5c3c0dfa1bf8..41fc21e7ef14 100644
> --- a/drivers/platform/x86/intel/ifs/ifs.h
> +++ b/drivers/platform/x86/intel/ifs/ifs.h
> @@ -23,12 +23,14 @@
>   * IFS Image
>   * ---------
>   *
> - * Intel provides a firmware file containing the scan tests via
> - * github [#f1]_.  Similar to microcode there is a separate file for each
> + * Intel provides firmware files containing the scan tests via the webpage [#f1]_.
> + * Look under "In-Field Scan Test Images Download" section towards the
> + * end of the page. Similar to microcode there are separate files for each
>   * family-model-stepping. IFS Images are not applicable for some test types.
>   * Wherever applicable the sysfs directory would provide a "current_batch" file
>   * (see below) for loading the image.
>   *
> + * .. [#f1] https://intel.com/InFieldScan
>   *
>   * IFS Image Loading
>   * -----------------
> @@ -125,9 +127,6 @@
>   * 2) Hardware allows for some number of cores to be tested in parallel.
>   * The driver does not make use of this, it only tests one core at a time.
>   *
> - * .. [#f1] https://github.com/intel/TBD
> - *
> - *
>   * Structural Based Functional Test at Field (SBAF):
>   * -------------------------------------------------
>   *
> 
> base-commit: ffd294d346d185b70e28b1a28abe367bbfe53c04
> 

-- 
 i.

Re: [PATCH] platform/x86/intel/ifs: Update documentation with image download path

Posted by Joseph, Jithu 1 year ago


On 2/4/2025 12:07 AM, Ilpo Järvinen wrote:
> On Fri, 31 Jan 2025, Jithu Joseph wrote:
> 
>> The documentation previously listed the path to download In Field Scan
>> (IFS) test images as "TBD".
>>
>> Update the documentation to include the correct image download location.
>> Also move the download link to the appropriate section within the doc.
>>
>> Signed-off-by: Jithu Joseph <jithu.joseph@intel.com>
> 
> I've applied this patch into the fixes branch with Anisse added as
> Reported-by.

Thank you, Anisse,  for reporting this, and apologies for missing the Reported-by tag.

Thanks Ilpo for taking the patch and Tony for your inputs on how to go about this.

> 
> Thanks Anisse for raising this issue and Jithu for getting the gears 
> moving to provide an useful resolution.
> 

Jithu

Re: [PATCH] platform/x86/intel/ifs: Update documentation with image download path

Posted by Anisse Astier 1 year ago

Hi Jithu,

Mar 04 févr 2025, à 22:10, Joseph, Jithu a écrit :
> On 2/4/2025 12:07 AM, Ilpo Järvinen wrote:
>> On Fri, 31 Jan 2025, Jithu Joseph wrote:
>> 
>>> The documentation previously listed the path to download In Field Scan
>>> (IFS) test images as "TBD".
>>>
>>> Update the documentation to include the correct image download location.
>>> Also move the download link to the appropriate section within the doc.
>>>
>>> Signed-off-by: Jithu Joseph <jithu.joseph@intel.com>
>> 
>> I've applied this patch into the fixes branch with Anisse added as
>> Reported-by.
>
> Thank you, Anisse,  for reporting this, and apologies for missing the 
> Reported-by tag.
>
> Thanks Ilpo for taking the patch and Tony for your inputs on how to go 
> about this.
>
>> 
>> Thanks Anisse for raising this issue and Jithu for getting the gears 
>> moving to provide an useful resolution.

Thanks for the update, and the Reported-by tag.

Does this patch mean you got confirmation that the scan tests firmware images will stay restricted to Intel customers with an NDA?

Regards,

Anisse

Re: [PATCH] platform/x86/intel/ifs: Update documentation with image download path

Posted by Joseph, Jithu 1 year ago

On 2/4/2025 9:50 PM, Anisse Astier wrote:
> 
> Thanks for the update, and the Reported-by tag.
> 
> Does this patch mean you got confirmation that the scan tests firmware images will stay restricted to Intel customers with an NDA?

On the contrary, Intel is making the images publicly available. 
A new section has been added towards the end of the page[1], allowing anyone to download the images without requiring an NDA.

Jithu

[1] https://intel.com/InFieldScan

Re: [PATCH] platform/x86/intel/ifs: Update documentation with image download path

Posted by Anisse Astier 1 year ago


Mer 05 févr 2025, à 07:31, Joseph, Jithu a écrit :
> On 2/4/2025 9:50 PM, Anisse Astier wrote:
>> 
>> Thanks for the update, and the Reported-by tag.
>> 
>> Does this patch mean you got confirmation that the scan tests firmware images will stay restricted to Intel customers with an NDA?
>
> On the contrary, Intel is making the images publicly available. 
> A new section has been added towards the end of the page[1], allowing 
> anyone to download the images without requiring an NDA.

Wow, that's great news!
(I had read the page a bit too quickly, sorry!)

I see the download link for EMR, does it mean SRF and GNR are upcoming? What about SPR?

Kind regards,

Anisse

RE: [PATCH] platform/x86/intel/ifs: Update documentation with image download path

Posted by Luck, Tony 1 year ago

> I see the download link for EMR, does it mean SRF and GNR are upcoming? What about SPR?

Yes, SRF and GNR will be added.

There are no plans to make the SPR files public.

-Tony