[PATCH] m68k: Do not include <linux/fb.h>

Thomas Zimmermann posted 1 patch 1 year ago
There is a newer version of this series
arch/m68k/kernel/setup_no.c | 1 -
arch/m68k/kernel/uboot.c    | 1 -
2 files changed, 2 deletions(-)
[PATCH] m68k: Do not include <linux/fb.h>
Posted by Thomas Zimmermann 1 year ago
The m68k architecture's source files does not require <linux/fb.h>.
Remove the include statements.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
 arch/m68k/kernel/setup_no.c | 1 -
 arch/m68k/kernel/uboot.c    | 1 -
 2 files changed, 2 deletions(-)

diff --git a/arch/m68k/kernel/setup_no.c b/arch/m68k/kernel/setup_no.c
index c926da9d5ec28..f9872098f5ca5 100644
--- a/arch/m68k/kernel/setup_no.c
+++ b/arch/m68k/kernel/setup_no.c
@@ -21,7 +21,6 @@
 #include <linux/sched.h>
 #include <linux/delay.h>
 #include <linux/interrupt.h>
-#include <linux/fb.h>
 #include <linux/module.h>
 #include <linux/mm.h>
 #include <linux/console.h>
diff --git a/arch/m68k/kernel/uboot.c b/arch/m68k/kernel/uboot.c
index 8bb1cb3a7490e..5e52ea150d5cb 100644
--- a/arch/m68k/kernel/uboot.c
+++ b/arch/m68k/kernel/uboot.c
@@ -10,7 +10,6 @@
 #include <linux/sched.h>
 #include <linux/delay.h>
 #include <linux/interrupt.h>
-#include <linux/fb.h>
 #include <linux/module.h>
 #include <linux/mm.h>
 #include <linux/console.h>
-- 
2.48.1
Re: [PATCH] m68k: Do not include <linux/fb.h>
Posted by John Paul Adrian Glaubitz 1 year ago
Hi Thomas,

On Fri, 2025-01-31 at 15:40 +0100, Thomas Zimmermann wrote:
> The m68k architecture's source files does not require <linux/fb.h>.

Minor: Replace "does" with "do".

Adrian

> Remove the include statements.
> 
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
>  arch/m68k/kernel/setup_no.c | 1 -
>  arch/m68k/kernel/uboot.c    | 1 -
>  2 files changed, 2 deletions(-)
> 
> diff --git a/arch/m68k/kernel/setup_no.c b/arch/m68k/kernel/setup_no.c
> index c926da9d5ec28..f9872098f5ca5 100644
> --- a/arch/m68k/kernel/setup_no.c
> +++ b/arch/m68k/kernel/setup_no.c
> @@ -21,7 +21,6 @@
>  #include <linux/sched.h>
>  #include <linux/delay.h>
>  #include <linux/interrupt.h>
> -#include <linux/fb.h>
>  #include <linux/module.h>
>  #include <linux/mm.h>
>  #include <linux/console.h>
> diff --git a/arch/m68k/kernel/uboot.c b/arch/m68k/kernel/uboot.c
> index 8bb1cb3a7490e..5e52ea150d5cb 100644
> --- a/arch/m68k/kernel/uboot.c
> +++ b/arch/m68k/kernel/uboot.c
> @@ -10,7 +10,6 @@
>  #include <linux/sched.h>
>  #include <linux/delay.h>
>  #include <linux/interrupt.h>
> -#include <linux/fb.h>
>  #include <linux/module.h>
>  #include <linux/mm.h>
>  #include <linux/console.h>

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer
`. `'   Physicist
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913
Re: [PATCH] m68k: Do not include <linux/fb.h>
Posted by Greg Ungerer 1 year ago
Hi Thomas,

On 1/2/25 00:40, Thomas Zimmermann wrote:
> The m68k architecture's source files does not require <linux/fb.h>.
> Remove the include statements.
> 
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>

Looks good, thanks. I will apply to the m68knommu git tree, for-next branch,
after the current merge window closes.

Regards
Greg


> ---
>   arch/m68k/kernel/setup_no.c | 1 -
>   arch/m68k/kernel/uboot.c    | 1 -
>   2 files changed, 2 deletions(-)
> 
> diff --git a/arch/m68k/kernel/setup_no.c b/arch/m68k/kernel/setup_no.c
> index c926da9d5ec28..f9872098f5ca5 100644
> --- a/arch/m68k/kernel/setup_no.c
> +++ b/arch/m68k/kernel/setup_no.c
> @@ -21,7 +21,6 @@
>   #include <linux/sched.h>
>   #include <linux/delay.h>
>   #include <linux/interrupt.h>
> -#include <linux/fb.h>
>   #include <linux/module.h>
>   #include <linux/mm.h>
>   #include <linux/console.h>
> diff --git a/arch/m68k/kernel/uboot.c b/arch/m68k/kernel/uboot.c
> index 8bb1cb3a7490e..5e52ea150d5cb 100644
> --- a/arch/m68k/kernel/uboot.c
> +++ b/arch/m68k/kernel/uboot.c
> @@ -10,7 +10,6 @@
>   #include <linux/sched.h>
>   #include <linux/delay.h>
>   #include <linux/interrupt.h>
> -#include <linux/fb.h>
>   #include <linux/module.h>
>   #include <linux/mm.h>
>   #include <linux/console.h>