[PATCH 3/3] gpio: bcm-kona: Add missing newline to dev_err format string

Artur Weber posted 3 patches 1 year ago
There is a newer version of this series
[PATCH 3/3] gpio: bcm-kona: Add missing newline to dev_err format string
Posted by Artur Weber 1 year ago
Add a missing newline to the format string of the "Couldn't get IRQ
for bank..." error message.

Fixes: 757651e3d60e ("gpio: bcm281xx: Add GPIO driver")
Signed-off-by: Artur Weber <aweber.kernel@gmail.com>
---
 drivers/gpio/gpio-bcm-kona.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpio/gpio-bcm-kona.c b/drivers/gpio/gpio-bcm-kona.c
index eeaa921df6f072129dbdf1c73d6da2bd7c1fe716..724db3434d277c5f9ea36b0d050e34c451787e4a 100644
--- a/drivers/gpio/gpio-bcm-kona.c
+++ b/drivers/gpio/gpio-bcm-kona.c
@@ -661,7 +661,7 @@ static int bcm_kona_gpio_probe(struct platform_device *pdev)
 		bank->irq = platform_get_irq(pdev, i);
 		bank->kona_gpio = kona_gpio;
 		if (bank->irq < 0) {
-			dev_err(dev, "Couldn't get IRQ for bank %d", i);
+			dev_err(dev, "Couldn't get IRQ for bank %d\n", i);
 			ret = -ENOENT;
 			goto err_irq_domain;
 		}

-- 
2.48.1
Re: [PATCH 3/3] gpio: bcm-kona: Add missing newline to dev_err format string
Posted by Florian Fainelli 1 year ago
On 1/30/25 09:10, Artur Weber wrote:
> Add a missing newline to the format string of the "Couldn't get IRQ
> for bank..." error message.
> 
> Fixes: 757651e3d60e ("gpio: bcm281xx: Add GPIO driver")
> Signed-off-by: Artur Weber <aweber.kernel@gmail.com>

Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
-- 
Florian
Re: [PATCH 3/3] gpio: bcm-kona: Add missing newline to dev_err format string
Posted by Markus Mayer 1 year ago
On Thu, 30 Jan 2025 at 10:41, Florian Fainelli
<florian.fainelli@broadcom.com> wrote:
>
> On 1/30/25 09:10, Artur Weber wrote:
> > Add a missing newline to the format string of the "Couldn't get IRQ
> > for bank..." error message.
> >
> > Fixes: 757651e3d60e ("gpio: bcm281xx: Add GPIO driver")
> > Signed-off-by: Artur Weber <aweber.kernel@gmail.com>
>
> Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>

Reviewed-by: Markus Mayer <mmayer@broadcom.com>