[v1] drm/bridge: analogix_dp: Use devm_platform_ioremap_resource()

[PATCH] drm/bridge: analogix_dp: Use devm_platform_ioremap_resource()

Posted by oushixiong1025@163.com 7 months, 2 weeks ago

From: Shixiong Ou <oushixiong@kylinos.cn>

Convert platform_get_resource(), devm_ioremap_resource() to a single
call to devm_platform_ioremap_resource().

Signed-off-by: Shixiong Ou <oushixiong@kylinos.cn>
---
 drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
index bfa88409a7ff..f6e4bdc05ba0 100644
--- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
+++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
@@ -1553,7 +1553,6 @@ analogix_dp_probe(struct device *dev, struct analogix_dp_plat_data *plat_data)
 {
 	struct platform_device *pdev = to_platform_device(dev);
 	struct analogix_dp_device *dp;
-	struct resource *res;
 	unsigned int irq_flags;
 	int ret;
 
@@ -1605,9 +1604,7 @@ analogix_dp_probe(struct device *dev, struct analogix_dp_plat_data *plat_data)
 		return ERR_CAST(dp->clock);
 	}
 
-	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-
-	dp->reg_base = devm_ioremap_resource(&pdev->dev, res);
+	dp->reg_base = devm_platform_ioremap_resource(pdev, 0);
 	if (IS_ERR(dp->reg_base)) {
 		ret = PTR_ERR(dp->reg_base);
 		goto err_disable_clk;
-- 
2.43.0

Re: [PATCH] drm/bridge: analogix_dp: Use devm_platform_ioremap_resource()

Posted by Robert Foss 6 months, 3 weeks ago

On Tue, 28 Jan 2025 14:56:45 +0800, oushixiong1025@163.com wrote:
> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_ioremap_resource().
> 
> 

Applied, thanks!

[1/1] drm/bridge: analogix_dp: Use devm_platform_ioremap_resource()
      (no commit info)



Rob

Re: [PATCH] drm/bridge: analogix_dp: Use devm_platform_ioremap_resource()

Posted by Robert Foss 7 months ago

On Tue, Jan 28, 2025 at 7:57 AM <oushixiong1025@163.com> wrote:
>
> From: Shixiong Ou <oushixiong@kylinos.cn>
>
> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_ioremap_resource().
>
> Signed-off-by: Shixiong Ou <oushixiong@kylinos.cn>
> ---
>  drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> index bfa88409a7ff..f6e4bdc05ba0 100644
> --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> @@ -1553,7 +1553,6 @@ analogix_dp_probe(struct device *dev, struct analogix_dp_plat_data *plat_data)
>  {
>         struct platform_device *pdev = to_platform_device(dev);
>         struct analogix_dp_device *dp;
> -       struct resource *res;
>         unsigned int irq_flags;
>         int ret;
>
> @@ -1605,9 +1604,7 @@ analogix_dp_probe(struct device *dev, struct analogix_dp_plat_data *plat_data)
>                 return ERR_CAST(dp->clock);
>         }
>
> -       res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -
> -       dp->reg_base = devm_ioremap_resource(&pdev->dev, res);
> +       dp->reg_base = devm_platform_ioremap_resource(pdev, 0);
>         if (IS_ERR(dp->reg_base)) {
>                 ret = PTR_ERR(dp->reg_base);
>                 goto err_disable_clk;
> --
> 2.43.0
>

Reviewed-by: Robert Foss <rfoss@kernel.org>