[PATCH 1/2] ipv4, bpf: Introduced to support the ULP to get or set sockets

zhangmingyi posted 2 patches 3 days, 10 hours ago
[PATCH 1/2] ipv4, bpf: Introduced to support the ULP to get or set sockets
Posted by zhangmingyi 3 days, 10 hours ago
Note that tcp_getsockopt and tcp_setsockopt support TCP_ULP, while
bpf_getsockopt and bpf_setsockopt do not support TCP_ULP.
I'm not sure why there is such a difference, but I noticed that
tcp_setsockopt is called in bpf_setsockopt.I think we can add the
handling of this case.

Signed-off-by: zhangmingyi <zhangmingyi5@huawei.com>
---
 net/core/filter.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/net/core/filter.c b/net/core/filter.c
index 713d6f454df3..bdb5c43d6fb0 100644
--- a/net/core/filter.c
+++ b/net/core/filter.c
@@ -5380,6 +5380,7 @@ static int sol_tcp_sockopt(struct sock *sk, int optname,
 	case TCP_CONGESTION:
 		return sol_tcp_sockopt_congestion(sk, optval, optlen, getopt);
 	case TCP_SAVED_SYN:
+	case TCP_ULP:
 		if (*optlen < 1)
 			return -EINVAL;
 		break;
-- 
2.43.0
Re: [PATCH 1/2] ipv4, bpf: Introduced to support the ULP to get or set sockets
Posted by Martin KaFai Lau 21 hours ago
On 1/27/25 1:07 AM, zhangmingyi wrote:
> Note that tcp_getsockopt and tcp_setsockopt support TCP_ULP, while
> bpf_getsockopt and bpf_setsockopt do not support TCP_ULP.
> I'm not sure why there is such a difference, but I noticed that
> tcp_setsockopt is called in bpf_setsockopt.I think we can add the
> handling of this case.
> 
> Signed-off-by: zhangmingyi <zhangmingyi5@huawei.com>

A nit that I found it useful to recognize different authors of the mailing list. 
It would be easier to have a formatted name. It seems "Mingyi Zhang" was used 
earlier, as seen by searching the git log history.