From: "Dr. David Alan Gilbert" <linux@treblig.org>

mvs_phys_reset() was added in 2009's
commit 20b09c2992fe ("[SCSI] mvsas: add support for 94xx; layout change;
bug fixes")
but hasn't been used.

Remove it.

Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
---
 drivers/scsi/mvsas/mv_sas.c | 10 ----------
 drivers/scsi/mvsas/mv_sas.h |  1 -
 2 files changed, 11 deletions(-)

diff --git a/drivers/scsi/mvsas/mv_sas.c b/drivers/scsi/mvsas/mv_sas.c
index 1444b1f1c4c8..c4592de4fefc 100644
--- a/drivers/scsi/mvsas/mv_sas.c
+++ b/drivers/scsi/mvsas/mv_sas.c
@@ -151,16 +151,6 @@ static inline u8 mvs_assign_reg_set(struct mvs_info *mvi,
 	return MVS_CHIP_DISP->assign_reg_set(mvi, &dev->taskfileset);
 }
 
-void mvs_phys_reset(struct mvs_info *mvi, u32 phy_mask, int hard)
-{
-	u32 no;
-	for_each_phy(phy_mask, phy_mask, no) {
-		if (!(phy_mask & 1))
-			continue;
-		MVS_CHIP_DISP->phy_reset(mvi, no, hard);
-	}
-}
-
 int mvs_phy_control(struct asd_sas_phy *sas_phy, enum phy_func func,
 			void *funcdata)
 {
diff --git a/drivers/scsi/mvsas/mv_sas.h b/drivers/scsi/mvsas/mv_sas.h
index 19b01f7c4767..09ce3f2241f2 100644
--- a/drivers/scsi/mvsas/mv_sas.h
+++ b/drivers/scsi/mvsas/mv_sas.h
@@ -425,7 +425,6 @@ struct mvs_task_exec_info {
 void mvs_get_sas_addr(void *buf, u32 buflen);
 void mvs_iounmap(void __iomem *regs);
 int mvs_ioremap(struct mvs_info *mvi, int bar, int bar_ex);
-void mvs_phys_reset(struct mvs_info *mvi, u32 phy_mask, int hard);
 int mvs_phy_control(struct asd_sas_phy *sas_phy, enum phy_func func,
 			void *funcdata);
 void mvs_set_sas_addr(struct mvs_info *mvi, int port_id, u32 off_lo,
-- 
2.48.1

On Mon, 27 Jan 2025 00:26:01 +0000, linux@treblig.org wrote:

> mvs_phys_reset() was added in 2009's
> commit 20b09c2992fe ("[SCSI] mvsas: add support for 94xx; layout change;
> bug fixes")
> but hasn't been used.
> 
> Remove it.
> 
> [...]

Applied to 6.15/scsi-queue, thanks!

[1/1] scsi: mvsas: remove unused mvs_phys_reset
      https://git.kernel.org/mkp/scsi/c/a307d6ec1239

-- 
Martin K. Petersen	Oracle Linux Engineering

> mvs_phys_reset() was added in 2009's
> commit 20b09c2992fe ("[SCSI] mvsas: add support for 94xx; layout change;
> bug fixes")
> but hasn't been used.

Applied to 6.15/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering