[v1] arm64: defconfig: Enable gb_beagleplay

[PATCH] arm64: defconfig: Enable gb_beagleplay

Posted by Ayush Singh 2 days, 19 hours ago

Enable greybus driver for Ti CC1352P7 over UART.

The driver communicates with Ti CC1352P7 co-processor which acts as
Greybus SVC. Additionally, it also provides firmware upload API support
for Ti CC1352P7 over UART.

Signed-off-by: Ayush Singh <ayush@beagleboard.org>
---
Enable greybus driver for Ti CC1352P5 over UART used in BeaglePlay [0].

[0]: https://www.beagleboard.org/boards/beagleplay
---
 arch/arm64/configs/defconfig | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index cb7da44155999b59aff95966f4cdc9107f2af46a..24353b0aa3e0ae1786ce99706a52cbf25d037d3b 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -1760,3 +1760,6 @@ CONFIG_CORESIGHT_STM=m
 CONFIG_CORESIGHT_CPU_DEBUG=m
 CONFIG_CORESIGHT_CTI=m
 CONFIG_MEMTEST=y
+CONFIG_GREYBUS=m
+CONFIG_GREYBUS_BEAGLEPLAY=m
+CONFIG_FW_UPLOAD=y

---
base-commit: 5ffa57f6eecefababb8cbe327222ef171943b183
change-id: 20250127-defconfig-beagleplay-de4553bb3882

Best regards,
-- 
Ayush Singh <ayush@beagleboard.org>

Re: [PATCH] arm64: defconfig: Enable gb_beagleplay

Posted by Krzysztof Kozlowski 2 days, 14 hours ago

On 27/01/2025 13:39, Ayush Singh wrote:
> Enable greybus driver for Ti CC1352P7 over UART.


Which upstream hardware uses it?

> 
> The driver communicates with Ti CC1352P7 co-processor which acts as
> Greybus SVC. Additionally, it also provides firmware upload API support
> for Ti CC1352P7 over UART.
> 
> Signed-off-by: Ayush Singh <ayush@beagleboard.org>
> ---
> Enable greybus driver for Ti CC1352P5 over UART used in BeaglePlay [0].
> 
> [0]: https://www.beagleboard.org/boards/beagleplay
> ---
>  arch/arm64/configs/defconfig | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> index cb7da44155999b59aff95966f4cdc9107f2af46a..24353b0aa3e0ae1786ce99706a52cbf25d037d3b 100644
> --- a/arch/arm64/configs/defconfig
> +++ b/arch/arm64/configs/defconfig
> @@ -1760,3 +1760,6 @@ CONFIG_CORESIGHT_STM=m
>  CONFIG_CORESIGHT_CPU_DEBUG=m
>  CONFIG_CORESIGHT_CTI=m
>  CONFIG_MEMTEST=y
> +CONFIG_GREYBUS=m
> +CONFIG_GREYBUS_BEAGLEPLAY=m
> +CONFIG_FW_UPLOAD=y


Does not look like placed according to Kconfig order (see savedefconfig).


Best regards,
Krzysztof

Re: [PATCH] arm64: defconfig: Enable gb_beagleplay

Posted by Ayush Singh 2 days, 14 hours ago

On 1/27/25 23:11, Krzysztof Kozlowski wrote:

> On 27/01/2025 13:39, Ayush Singh wrote:
>> Enable greybus driver for Ti CC1352P7 over UART.
>
> Which upstream hardware uses it?

ti,cc1352p7 [0] on beagleplay [1].

>> The driver communicates with Ti CC1352P7 co-processor which acts as
>> Greybus SVC. Additionally, it also provides firmware upload API support
>> for Ti CC1352P7 over UART.
>>
>> Signed-off-by: Ayush Singh <ayush@beagleboard.org>
>> ---
>> Enable greybus driver for Ti CC1352P5 over UART used in BeaglePlay [0].
>>
>> [0]: https://www.beagleboard.org/boards/beagleplay
>> ---
>>   arch/arm64/configs/defconfig | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
>> index cb7da44155999b59aff95966f4cdc9107f2af46a..24353b0aa3e0ae1786ce99706a52cbf25d037d3b 100644
>> --- a/arch/arm64/configs/defconfig
>> +++ b/arch/arm64/configs/defconfig
>> @@ -1760,3 +1760,6 @@ CONFIG_CORESIGHT_STM=m
>>   CONFIG_CORESIGHT_CPU_DEBUG=m
>>   CONFIG_CORESIGHT_CTI=m
>>   CONFIG_MEMTEST=y
>> +CONFIG_GREYBUS=m
>> +CONFIG_GREYBUS_BEAGLEPLAY=m
>> +CONFIG_FW_UPLOAD=y
>
> Does not look like placed according to Kconfig order (see savedefconfig).

Thanks, I did not know about it. Will fix in next patch.


>
>
> Best regards,
> Krzysztof


[0]: 
https://elixir.bootlin.com/linux/v6.13/source/Documentation/devicetree/bindings/net/ti,cc1352p7.yaml

[1]: 
https://elixir.bootlin.com/linux/v6.13/source/arch/arm64/boot/dts/ti/k3-am625-beagleplay.dts#L895


Best regards,

Ayush Singh

Re: [PATCH] arm64: defconfig: Enable gb_beagleplay

Posted by Krzysztof Kozlowski 2 days, 14 hours ago

On 27/01/2025 19:08, Ayush Singh wrote:
> On 1/27/25 23:11, Krzysztof Kozlowski wrote:
> 
>> On 27/01/2025 13:39, Ayush Singh wrote:
>>> Enable greybus driver for Ti CC1352P7 over UART.
>>
>> Which upstream hardware uses it?

So TI K3/AM625 BeaglePlay or whatever recognizable name is. This is
supposed to be in commit msg, because this is defconfig for *all vendors*.

Best regards,
Krzysztof