Bluetooth: Unnecessary braces around single line statment.

[PATCH] Bluetooth: Unnecessary braces around single line statment.

Posted by deaner92@yahoo.com 1 year ago

From: Jeremy Clifton <deaner92@yahoo.com>

Warning found with checkpatch.pl script. Removed unnecessary braces.

Signed-off-by: Jeremy Clifton <deaner92@yahoo.com>
---
 drivers/bluetooth/bfusb.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/bluetooth/bfusb.c b/drivers/bluetooth/bfusb.c
index cab93935cc7f..0d6ad50da046 100644
--- a/drivers/bluetooth/bfusb.c
+++ b/drivers/bluetooth/bfusb.c
@@ -365,9 +365,8 @@ static void bfusb_rx_complete(struct urb *urb)
 			buf   += 3;
 		}
 
-		if (count < len) {
+		if (count < len)
 			bt_dev_err(data->hdev, "block extends over URB buffer ranges");
-		}
 
 		if ((hdr & 0xe1) == 0xc1)
 			bfusb_recv_block(data, hdr, buf, len);
-- 
2.43.0

Re: [PATCH] Bluetooth: Unnecessary braces around single line statment.

Posted by Paul Menzel 1 year ago

Dear Jeremy,


Thank you for your patch. Could you please make the summary/title a 
statement, and remove the dot/period at the end:

Bluetooth: Remove unnecessary braces around single line statement

Am 25.01.25 um 17:58 schrieb deaner92@yahoo.com:
> From: Jeremy Clifton <deaner92@yahoo.com>
> 
> Warning found with checkpatch.pl script. Removed unnecessary braces.

I’d use imperative mood for the second sentence:

Remove unnecessary braces.

Also please add a Fixes: tag.

> Signed-off-by: Jeremy Clifton <deaner92@yahoo.com>
> ---
>   drivers/bluetooth/bfusb.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/bluetooth/bfusb.c b/drivers/bluetooth/bfusb.c
> index cab93935cc7f..0d6ad50da046 100644
> --- a/drivers/bluetooth/bfusb.c
> +++ b/drivers/bluetooth/bfusb.c
> @@ -365,9 +365,8 @@ static void bfusb_rx_complete(struct urb *urb)
>   			buf   += 3;
>   		}
>   
> -		if (count < len) {
> +		if (count < len)
>   			bt_dev_err(data->hdev, "block extends over URB buffer ranges");
> -		}
>   
>   		if ((hdr & 0xe1) == 0xc1)
>   			bfusb_recv_block(data, hdr, buf, len);

Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de>


Kind regards,

Paul

Re: [PATCH] Bluetooth: Remove unnecessary braces around single line statement

Posted by Jeremy Dean 1 year ago

Dear Paul,

I have changed the subject. 

Fixes: Coding style, unnecessary braces

On Sun, Jan 26, 2025 at 09:02:04AM +0100, Paul Menzel wrote:
> Dear Jeremy,
> 
> 
> Thank you for your patch. Could you please make the summary/title a
> statement, and remove the dot/period at the end:
> 
> Bluetooth: Remove unnecessary braces around single line statement
> 
> Am 25.01.25 um 17:58 schrieb deaner92@yahoo.com:
> > From: Jeremy Clifton <deaner92@yahoo.com>
> > 
> > Warning found with checkpatch.pl script. Removed unnecessary braces.
> 
> I’d use imperative mood for the second sentence:
> 
> Remove unnecessary braces.
> 
> Also please add a Fixes: tag.
> 
> > Signed-off-by: Jeremy Clifton <deaner92@yahoo.com>
> > ---
> >   drivers/bluetooth/bfusb.c | 3 +--
> >   1 file changed, 1 insertion(+), 2 deletions(-)
> > 
> > diff --git a/drivers/bluetooth/bfusb.c b/drivers/bluetooth/bfusb.c
> > index cab93935cc7f..0d6ad50da046 100644
> > --- a/drivers/bluetooth/bfusb.c
> > +++ b/drivers/bluetooth/bfusb.c
> > @@ -365,9 +365,8 @@ static void bfusb_rx_complete(struct urb *urb)
> >   			buf   += 3;
> >   		}
> > -		if (count < len) {
> > +		if (count < len)
> >   			bt_dev_err(data->hdev, "block extends over URB buffer ranges");
> > -		}
> >   		if ((hdr & 0xe1) == 0xc1)
> >   			bfusb_recv_block(data, hdr, buf, len);
> 
> Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de>
> 
> 
> Kind regards,
> 
> Paul

Re: Bluetooth: Remove unnecessary braces around single line statement

Posted by Markus Elfring 1 year ago

> I have changed the subject.
>
> Fixes: Coding style, unnecessary braces

See also once more:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.13#n145

Is such a tag really relevant for a coding style adjustment?


https://lore.kernel.org/all/?q=%22This+looks+like+a+new+version+of+a+previously+submitted+patch%22

Regards,
Markus