nouveau/svm: fix + cleanup for nouveau_atomic_range_fault()

[PATCH v1 0/2] nouveau/svm: fix + cleanup for nouveau_atomic_range_fault()

Posted by David Hildenbrand 1 year, 3 months ago

One fix and a minor cleanup.

Only compile-tested due to lack of HW, so I'd be happy if someone with
access to HW could test. But not sure how easy this is to trigger. Likely
some concurrent MADV_DONTNEED on the PTE we just converted might be able
to trigger it.

Cc: Karol Herbst <kherbst@redhat.com>
Cc: Lyude Paul <lyude@redhat.com>
Cc: Danilo Krummrich <dakr@kernel.org>
Cc: David Airlie <airlied@gmail.com>
Cc: Simona Vetter <simona@ffwll.ch>
Cc: Alistair Popple <apopple@nvidia.com>

David Hildenbrand (2):
  nouveau/svm: fix missing folio unlock + put after
    make_device_exclusive_range()
  nouveau/svm: don't initialize ret in nouveau_atomic_range_fault()

 drivers/gpu/drm/nouveau/nouveau_svm.c | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

-- 
2.47.1

Re: [PATCH v1 0/2] nouveau/svm: fix + cleanup for nouveau_atomic_range_fault()

Posted by Alistair Popple 1 year, 3 months ago

On Fri, Jan 24, 2025 at 07:15:22PM +0100, David Hildenbrand wrote:
> One fix and a minor cleanup.
> 
> Only compile-tested due to lack of HW, so I'd be happy if someone with
> access to HW could test. But not sure how easy this is to trigger. Likely
> some concurrent MADV_DONTNEED on the PTE we just converted might be able
> to trigger it.

I have this setup so will certainly test it and see if I can trigger the bug
as well. Thanks for the fixes.
 
> Cc: Karol Herbst <kherbst@redhat.com>
> Cc: Lyude Paul <lyude@redhat.com>
> Cc: Danilo Krummrich <dakr@kernel.org>
> Cc: David Airlie <airlied@gmail.com>
> Cc: Simona Vetter <simona@ffwll.ch>
> Cc: Alistair Popple <apopple@nvidia.com>
> 
> David Hildenbrand (2):
>   nouveau/svm: fix missing folio unlock + put after
>     make_device_exclusive_range()
>   nouveau/svm: don't initialize ret in nouveau_atomic_range_fault()
> 
>  drivers/gpu/drm/nouveau/nouveau_svm.c | 11 ++++++++---
>  1 file changed, 8 insertions(+), 3 deletions(-)
> 
> -- 
> 2.47.1
>