1. Patchew
  2. linux
  3. View series

[PATCH] documentation: networking: fix spelling mistakes

Khaled Elnaggar posted 1 patch 11 months ago 
Documentation/networking/can.rst  | 4 ++--
Documentation/networking/napi.rst | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
[PATCH] documentation: networking: fix spelling mistakes
Posted by Khaled Elnaggar 11 months ago 
Fix a couple of typos/spelling mistakes in the documentation.

Signed-off-by: Khaled Elnaggar <khaledelnaggarlinux@gmail.com>
---
Hello, I hope the patch is self-explanatory. Please let me know if you
have any comments.

Aside: CCing Shuah and linux-kernel-mentees as I am working on the mentorship
application tasks.

Thanks
Khaled
---
 Documentation/networking/can.rst  | 4 ++--
 Documentation/networking/napi.rst | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/Documentation/networking/can.rst b/Documentation/networking/can.rst
index 62519d38c58b..b018ce346392 100644
--- a/Documentation/networking/can.rst
+++ b/Documentation/networking/can.rst
@@ -699,10 +699,10 @@ RAW socket option CAN_RAW_JOIN_FILTERS

 The CAN_RAW socket can set multiple CAN identifier specific filters that
 lead to multiple filters in the af_can.c filter processing. These filters
-are indenpendent from each other which leads to logical OR'ed filters when
+are independent from each other which leads to logical OR'ed filters when
 applied (see :ref:`socketcan-rawfilter`).

-This socket option joines the given CAN filters in the way that only CAN
+This socket option joins the given CAN filters in the way that only CAN
 frames are passed to user space that matched *all* given CAN filters. The
 semantic for the applied filters is therefore changed to a logical AND.

diff --git a/Documentation/networking/napi.rst b/Documentation/networking/napi.rst
index 6083210ab2a4..f970a2be271a 100644
--- a/Documentation/networking/napi.rst
+++ b/Documentation/networking/napi.rst
@@ -362,7 +362,7 @@ It is expected that ``irq-suspend-timeout`` will be set to a value much larger
 than ``gro_flush_timeout`` as ``irq-suspend-timeout`` should suspend IRQs for
 the duration of one userland processing cycle.

-While it is not stricly necessary to use ``napi_defer_hard_irqs`` and
+While it is not strictly necessary to use ``napi_defer_hard_irqs`` and
 ``gro_flush_timeout`` to use IRQ suspension, their use is strongly
 recommended.

--
2.45.2
Re: [PATCH] documentation: networking: fix spelling mistakes
Posted by Bagas Sanjaya 10 months, 4 weeks ago 
On Thu, Jan 23, 2025 at 10:25:20AM +0200, Khaled Elnaggar wrote:
> diff --git a/Documentation/networking/can.rst b/Documentation/networking/can.rst
> index 62519d38c58b..b018ce346392 100644
> --- a/Documentation/networking/can.rst
> +++ b/Documentation/networking/can.rst
> @@ -699,10 +699,10 @@ RAW socket option CAN_RAW_JOIN_FILTERS
> 
>  The CAN_RAW socket can set multiple CAN identifier specific filters that
>  lead to multiple filters in the af_can.c filter processing. These filters
> -are indenpendent from each other which leads to logical OR'ed filters when
> +are independent from each other which leads to logical OR'ed filters when
>  applied (see :ref:`socketcan-rawfilter`).
> 
> -This socket option joines the given CAN filters in the way that only CAN
> +This socket option joins the given CAN filters in the way that only CAN
>  frames are passed to user space that matched *all* given CAN filters. The
>  semantic for the applied filters is therefore changed to a logical AND.
> 
> diff --git a/Documentation/networking/napi.rst b/Documentation/networking/napi.rst
> index 6083210ab2a4..f970a2be271a 100644
> --- a/Documentation/networking/napi.rst
> +++ b/Documentation/networking/napi.rst
> @@ -362,7 +362,7 @@ It is expected that ``irq-suspend-timeout`` will be set to a value much larger
>  than ``gro_flush_timeout`` as ``irq-suspend-timeout`` should suspend IRQs for
>  the duration of one userland processing cycle.
> 
> -While it is not stricly necessary to use ``napi_defer_hard_irqs`` and
> +While it is not strictly necessary to use ``napi_defer_hard_irqs`` and
>  ``gro_flush_timeout`` to use IRQ suspension, their use is strongly
>  recommended.
> 

Looks OK, thanks!

Reviewed-by: Bagas Sanjaya <bagasdotme@gmail.com>

-- 
An old man doll... just what I always wanted! - Clara
Re: [PATCH] documentation: networking: fix spelling mistakes
Posted by Randy Dunlap 11 months ago 

On 1/23/25 12:25 AM, Khaled Elnaggar wrote:
> Fix a couple of typos/spelling mistakes in the documentation.
> 
> Signed-off-by: Khaled Elnaggar <khaledelnaggarlinux@gmail.com>


Acked-by: Randy Dunlap <rdunlap@infradead.org>

Thanks.

> ---
> Hello, I hope the patch is self-explanatory. Please let me know if you
> have any comments.
> 
> Aside: CCing Shuah and linux-kernel-mentees as I am working on the mentorship
> application tasks.
> 
> Thanks
> Khaled
> ---
>  Documentation/networking/can.rst  | 4 ++--
>  Documentation/networking/napi.rst | 2 +-
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/networking/can.rst b/Documentation/networking/can.rst
> index 62519d38c58b..b018ce346392 100644
> --- a/Documentation/networking/can.rst
> +++ b/Documentation/networking/can.rst
> @@ -699,10 +699,10 @@ RAW socket option CAN_RAW_JOIN_FILTERS
> 
>  The CAN_RAW socket can set multiple CAN identifier specific filters that
>  lead to multiple filters in the af_can.c filter processing. These filters
> -are indenpendent from each other which leads to logical OR'ed filters when
> +are independent from each other which leads to logical OR'ed filters when
>  applied (see :ref:`socketcan-rawfilter`).
> 
> -This socket option joines the given CAN filters in the way that only CAN
> +This socket option joins the given CAN filters in the way that only CAN
>  frames are passed to user space that matched *all* given CAN filters. The
>  semantic for the applied filters is therefore changed to a logical AND.
> 
> diff --git a/Documentation/networking/napi.rst b/Documentation/networking/napi.rst
> index 6083210ab2a4..f970a2be271a 100644
> --- a/Documentation/networking/napi.rst
> +++ b/Documentation/networking/napi.rst
> @@ -362,7 +362,7 @@ It is expected that ``irq-suspend-timeout`` will be set to a value much larger
>  than ``gro_flush_timeout`` as ``irq-suspend-timeout`` should suspend IRQs for
>  the duration of one userland processing cycle.
> 
> -While it is not stricly necessary to use ``napi_defer_hard_irqs`` and
> +While it is not strictly necessary to use ``napi_defer_hard_irqs`` and
>  ``gro_flush_timeout`` to use IRQ suspension, their use is strongly
>  recommended.
> 
> --
> 2.45.2
> 
> 

-- 
~Randy
Re: [PATCH] documentation: networking: fix spelling mistakes
Posted by Przemek Kitszel 11 months ago 
On 1/23/25 09:25, Khaled Elnaggar wrote:
> Fix a couple of typos/spelling mistakes in the documentation.
> 
> Signed-off-by: Khaled Elnaggar <khaledelnaggarlinux@gmail.com>
> ---
> Hello, I hope the patch is self-explanatory. Please let me know if you
> have any comments.

looks good, also process wise, also this comment is properly put

(one thing to possibly improve would be to put "net" as the target in
the subject (see other patches on the netdev mailing list); for
non-fixes it would be "net-next"; but don't resubmit just for that)

I'm assuming you have fixed all the typos in that two files, with that:
Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>

> 
> Aside: CCing Shuah and linux-kernel-mentees as I am working on the mentorship
> application tasks.
> 
> Thanks
> Khaled
> ---
>   Documentation/networking/can.rst  | 4 ++--
>   Documentation/networking/napi.rst | 2 +-
>   2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/networking/can.rst b/Documentation/networking/can.rst
> index 62519d38c58b..b018ce346392 100644
> --- a/Documentation/networking/can.rst
> +++ b/Documentation/networking/can.rst
> @@ -699,10 +699,10 @@ RAW socket option CAN_RAW_JOIN_FILTERS
> 
>   The CAN_RAW socket can set multiple CAN identifier specific filters that
>   lead to multiple filters in the af_can.c filter processing. These filters
> -are indenpendent from each other which leads to logical OR'ed filters when
> +are independent from each other which leads to logical OR'ed filters when
>   applied (see :ref:`socketcan-rawfilter`).
> 
> -This socket option joines the given CAN filters in the way that only CAN
> +This socket option joins the given CAN filters in the way that only CAN
>   frames are passed to user space that matched *all* given CAN filters. The
>   semantic for the applied filters is therefore changed to a logical AND.
> 
> diff --git a/Documentation/networking/napi.rst b/Documentation/networking/napi.rst
> index 6083210ab2a4..f970a2be271a 100644
> --- a/Documentation/networking/napi.rst
> +++ b/Documentation/networking/napi.rst
> @@ -362,7 +362,7 @@ It is expected that ``irq-suspend-timeout`` will be set to a value much larger
>   than ``gro_flush_timeout`` as ``irq-suspend-timeout`` should suspend IRQs for
>   the duration of one userland processing cycle.
> 
> -While it is not stricly necessary to use ``napi_defer_hard_irqs`` and
> +While it is not strictly necessary to use ``napi_defer_hard_irqs`` and
>   ``gro_flush_timeout`` to use IRQ suspension, their use is strongly
>   recommended.
> 
> --
> 2.45.2
> 
>
Re: [PATCH] documentation: networking: fix spelling mistakes
Posted by Khaled Elnaggar 10 months, 4 weeks ago 
On 1/23/25 11:12 AM, Przemek Kitszel wrote:

> looks good, also process wise, also this comment is properly put
> (one thing to possibly improve would be to put "net" as the target in
> the subject (see other patches on the netdev mailing list); for
> non-fixes it would be "net-next"; but don't resubmit just for that)

Ahaa, I also should not have sent this patch during a merge
window where net-next is closed?

Thank you for the heads up, I will be spending more time with
https://docs.kernel.org/process/maintainer-netdev.html

> I'm assuming you have fixed all the typos in that two files, with that:
> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>

Yes that was all I could find in these two files.

Thanks,
Khaled
Re: [PATCH] documentation: networking: fix spelling mistakes
Posted by Przemek Kitszel 10 months, 3 weeks ago 
On 1/25/25 13:11, Khaled Elnaggar wrote:
> On 1/23/25 11:12 AM, Przemek Kitszel wrote:
> 
>> looks good, also process wise, also this comment is properly put
>> (one thing to possibly improve would be to put "net" as the target in
>> the subject (see other patches on the netdev mailing list); for
>> non-fixes it would be "net-next"; but don't resubmit just for that)
> 
> Ahaa, I also should not have sent this patch during a merge
> window where net-next is closed?

this patch is fine for -net, as this is fixing the bugs in the text,
those are rather special, as there is no risk of regression :)
I'm not sure if Fixes tag is necessary for spelling fixes though.

> 
> Thank you for the heads up, I will be spending more time with
> https://docs.kernel.org/process/maintainer-netdev.html
> 
>> I'm assuming you have fixed all the typos in that two files, with that:
>> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
> 
> Yes that was all I could find in these two files.
> 
> Thanks,
> Khaled
>
Re: [PATCH] documentation: networking: fix spelling mistakes
Posted by Khaled Elnaggar 10 months, 3 weeks ago 
On 1/27/25 10:16 AM, Przemek Kitszel wrote:

> this patch is fine for -net, as this is fixing the bugs in the text,
> those are rather special, as there is no risk of regression :)
> I'm not sure if Fixes tag is necessary for spelling fixes though.

Makes sense. Thanks.
Khaled
Re: [PATCH] documentation: networking: fix spelling mistakes
Posted by Marc Kleine-Budde 11 months ago 
On 23.01.2025 10:25:20, Khaled Elnaggar wrote:
> Fix a couple of typos/spelling mistakes in the documentation.
> 
> Signed-off-by: Khaled Elnaggar <khaledelnaggarlinux@gmail.com>
Acked-by: Marc Kleine-Budde <mkl@pengutronix.de>

Feel free to take the patch via the net-tree.

Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde          |
Embedded Linux                   | https://www.pengutronix.de |
Vertretung Nürnberg              | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |

Patchew 2.1-devel-b67e4c2

© 2016 - 2025 Red Hat, Inc.