Document the 'dll-hsr-list' property for MMC device tree bindings.
The 'dll-hsr-list' property defines the DLL configurations for HS400
and HS200 modes.
Signed-off-by: Sachin Gupta <quic_sachgupt@quicinc.com>
---
Documentation/devicetree/bindings/mmc/sdhci-msm.yaml | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml b/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml
index 8b393e26e025..65dc3053df75 100644
--- a/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml
+++ b/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml
@@ -133,6 +133,11 @@ properties:
$ref: /schemas/types.yaml#/definitions/uint32
description: platform specific settings for DLL_CONFIG reg.
+ qcom,dll-hsr-list:
+ maxItems: 10
+ $ref: /schemas/types.yaml#/definitions/uint32
+ description: platform specific settings for DLL registers.
+
iommus:
minItems: 1
maxItems: 8
--
2.17.1On Wed, 22 Jan 2025 15:17:04 +0530, Sachin Gupta wrote: > Document the 'dll-hsr-list' property for MMC device tree bindings. > The 'dll-hsr-list' property defines the DLL configurations for HS400 > and HS200 modes. > > Signed-off-by: Sachin Gupta <quic_sachgupt@quicinc.com> > --- > Documentation/devicetree/bindings/mmc/sdhci-msm.yaml | 5 +++++ > 1 file changed, 5 insertions(+) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml: properties:qcom,dll-hsr-list:maxItems: False schema does not allow 10 hint: Scalar properties should not have array keywords from schema $id: http://devicetree.org/meta-schemas/keywords.yaml# doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250122094707.24859-2-quic_sachgupt@quicinc.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On 22/01/2025 10:47, Sachin Gupta wrote: > Document the 'dll-hsr-list' property for MMC device tree bindings. > The 'dll-hsr-list' property defines the DLL configurations for HS400 > and HS200 modes. > > Signed-off-by: Sachin Gupta <quic_sachgupt@quicinc.com> > --- > Documentation/devicetree/bindings/mmc/sdhci-msm.yaml | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml b/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml > index 8b393e26e025..65dc3053df75 100644 > --- a/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml > +++ b/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml > @@ -133,6 +133,11 @@ properties: > $ref: /schemas/types.yaml#/definitions/uint32 > description: platform specific settings for DLL_CONFIG reg. > > + qcom,dll-hsr-list: > + maxItems: 10 > + $ref: /schemas/types.yaml#/definitions/uint32 uint32 has only one item. Anyway, there is already DLL there, so don't duplicate or explain why this is different. Explain also why this is not deducible from the compatible. Please provide here link to DTS user so we can validate how you use it. Best regards, Krzysztof
On 1/22/2025 3:56 PM, Krzysztof Kozlowski wrote: > On 22/01/2025 10:47, Sachin Gupta wrote: >> Document the 'dll-hsr-list' property for MMC device tree bindings. >> The 'dll-hsr-list' property defines the DLL configurations for HS400 >> and HS200 modes. >> >> Signed-off-by: Sachin Gupta <quic_sachgupt@quicinc.com> >> --- >> Documentation/devicetree/bindings/mmc/sdhci-msm.yaml | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml b/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml >> index 8b393e26e025..65dc3053df75 100644 >> --- a/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml >> +++ b/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml >> @@ -133,6 +133,11 @@ properties: >> $ref: /schemas/types.yaml#/definitions/uint32 >> description: platform specific settings for DLL_CONFIG reg. >> >> + qcom,dll-hsr-list: >> + maxItems: 10 >> + $ref: /schemas/types.yaml#/definitions/uint32 > uint32 has only one item. Anyway, there is already DLL there, so don't > duplicate or explain why this is different. Explain also why this is not > deducible from the compatible. I will change it to reflect array from uint32. There is change with artanis DLL hw addition where it need total of 5 entries (dll_config, dll_config_2, dll_config_3, dll_usr_ctl, ddr_config) for each HS400 and HS200 modes, hence the new addition in dt. And these values are not fixed and varies for every SoC, hence this needs to be passed through dt like it was passed earlier for qcom,dll-config & qcom,ddr-config. And backward compatibility would be taken care by check for qcom,dll-hsr-list, where new settings would apply for soc where qcom,dll-hsr-list is added into dt. > > Please provide here link to DTS user so we can validate how you use it. > > > Best regards, > Krzysztof
On 26/06/2025 16:16, Ram Prakash Gupta wrote: > On 1/22/2025 3:56 PM, Krzysztof Kozlowski wrote: >> On 22/01/2025 10:47, Sachin Gupta wrote: >>> Document the 'dll-hsr-list' property for MMC device tree bindings. >>> The 'dll-hsr-list' property defines the DLL configurations for HS400 >>> and HS200 modes. >>> >>> Signed-off-by: Sachin Gupta <quic_sachgupt@quicinc.com> >>> --- >>> Documentation/devicetree/bindings/mmc/sdhci-msm.yaml | 5 +++++ >>> 1 file changed, 5 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml b/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml >>> index 8b393e26e025..65dc3053df75 100644 >>> --- a/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml >>> +++ b/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml >>> @@ -133,6 +133,11 @@ properties: >>> $ref: /schemas/types.yaml#/definitions/uint32 >>> description: platform specific settings for DLL_CONFIG reg. >>> >>> + qcom,dll-hsr-list: >>> + maxItems: 10 >>> + $ref: /schemas/types.yaml#/definitions/uint32 >> uint32 has only one item. Anyway, there is already DLL there, so don't >> duplicate or explain why this is different. Explain also why this is not >> deducible from the compatible. > Timeline still amazes me. I will be grumpy on this thread. > I will change it to reflect array from uint32. > There is change with artanis DLL hw addition where it need total of 5 entries > (dll_config, dll_config_2, dll_config_3, dll_usr_ctl, ddr_config) > for each HS400 and HS200 modes, hence the new addition in dt. And these values > are not fixed and varies for every SoC, hence this needs to be passed through > dt like it was passed earlier for qcom,dll-config & qcom,ddr-config. Eh, no. That's not a valid reason. It's still SoC deducible. Don't bring your downstream practices here, but remove EVERYTHING from downstream and start doing things like upstream is doing. Best regards, Krzysztof
On 6/26/25 7:42 PM, Krzysztof Kozlowski wrote: > On 26/06/2025 16:16, Ram Prakash Gupta wrote: >> On 1/22/2025 3:56 PM, Krzysztof Kozlowski wrote: >>> On 22/01/2025 10:47, Sachin Gupta wrote: >>>> Document the 'dll-hsr-list' property for MMC device tree bindings. >>>> The 'dll-hsr-list' property defines the DLL configurations for HS400 >>>> and HS200 modes. >>>> >>>> Signed-off-by: Sachin Gupta <quic_sachgupt@quicinc.com> >>>> --- >>>> Documentation/devicetree/bindings/mmc/sdhci-msm.yaml | 5 +++++ >>>> 1 file changed, 5 insertions(+) >>>> >>>> diff --git a/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml b/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml >>>> index 8b393e26e025..65dc3053df75 100644 >>>> --- a/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml >>>> +++ b/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml >>>> @@ -133,6 +133,11 @@ properties: >>>> $ref: /schemas/types.yaml#/definitions/uint32 >>>> description: platform specific settings for DLL_CONFIG reg. >>>> >>>> + qcom,dll-hsr-list: >>>> + maxItems: 10 >>>> + $ref: /schemas/types.yaml#/definitions/uint32 >>> uint32 has only one item. Anyway, there is already DLL there, so don't >>> duplicate or explain why this is different. Explain also why this is not >>> deducible from the compatible. >> > > > Timeline still amazes me. I will be grumpy on this thread. > >> I will change it to reflect array from uint32. >> There is change with artanis DLL hw addition where it need total of 5 entries >> (dll_config, dll_config_2, dll_config_3, dll_usr_ctl, ddr_config) >> for each HS400 and HS200 modes, hence the new addition in dt. And these values >> are not fixed and varies for every SoC, hence this needs to be passed through >> dt like it was passed earlier for qcom,dll-config & qcom,ddr-config. > > > Eh, no. That's not a valid reason. It's still SoC deducible. Don't bring > your downstream practices here, but remove EVERYTHING from downstream > and start doing things like upstream is doing. QC SoCs have between 0 and 4 SDHCI instances, each one potentially requiring different tuning, let's keep this data in DT Konrad
On 27/06/2025 15:57, Konrad Dybcio wrote: > On 6/26/25 7:42 PM, Krzysztof Kozlowski wrote: >> On 26/06/2025 16:16, Ram Prakash Gupta wrote: >>> On 1/22/2025 3:56 PM, Krzysztof Kozlowski wrote: >>>> On 22/01/2025 10:47, Sachin Gupta wrote: >>>>> Document the 'dll-hsr-list' property for MMC device tree bindings. >>>>> The 'dll-hsr-list' property defines the DLL configurations for HS400 >>>>> and HS200 modes. >>>>> >>>>> Signed-off-by: Sachin Gupta <quic_sachgupt@quicinc.com> >>>>> --- >>>>> Documentation/devicetree/bindings/mmc/sdhci-msm.yaml | 5 +++++ >>>>> 1 file changed, 5 insertions(+) >>>>> >>>>> diff --git a/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml b/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml >>>>> index 8b393e26e025..65dc3053df75 100644 >>>>> --- a/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml >>>>> +++ b/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml >>>>> @@ -133,6 +133,11 @@ properties: >>>>> $ref: /schemas/types.yaml#/definitions/uint32 >>>>> description: platform specific settings for DLL_CONFIG reg. >>>>> >>>>> + qcom,dll-hsr-list: >>>>> + maxItems: 10 >>>>> + $ref: /schemas/types.yaml#/definitions/uint32 >>>> uint32 has only one item. Anyway, there is already DLL there, so don't >>>> duplicate or explain why this is different. Explain also why this is not >>>> deducible from the compatible. >>> >> >> >> Timeline still amazes me. I will be grumpy on this thread. >> >>> I will change it to reflect array from uint32. >>> There is change with artanis DLL hw addition where it need total of 5 entries >>> (dll_config, dll_config_2, dll_config_3, dll_usr_ctl, ddr_config) >>> for each HS400 and HS200 modes, hence the new addition in dt. And these values >>> are not fixed and varies for every SoC, hence this needs to be passed through >>> dt like it was passed earlier for qcom,dll-config & qcom,ddr-config. >> >> >> Eh, no. That's not a valid reason. It's still SoC deducible. Don't bring >> your downstream practices here, but remove EVERYTHING from downstream >> and start doing things like upstream is doing. > > QC SoCs have between 0 and 4 SDHCI instances, each one potentially requiring > different tuning, let's keep this data in DT OK, this should be explained in commit msg. Best regards, Krzysztof
On 6/27/2025 8:20 PM, Krzysztof Kozlowski wrote: > On 27/06/2025 15:57, Konrad Dybcio wrote: >> On 6/26/25 7:42 PM, Krzysztof Kozlowski wrote: >>> On 26/06/2025 16:16, Ram Prakash Gupta wrote: >>>> On 1/22/2025 3:56 PM, Krzysztof Kozlowski wrote: >>>>> On 22/01/2025 10:47, Sachin Gupta wrote: >>>>>> Document the 'dll-hsr-list' property for MMC device tree bindings. >>>>>> The 'dll-hsr-list' property defines the DLL configurations for HS400 >>>>>> and HS200 modes. >>>>>> >>>>>> Signed-off-by: Sachin Gupta <quic_sachgupt@quicinc.com> >>>>>> --- >>>>>> Documentation/devicetree/bindings/mmc/sdhci-msm.yaml | 5 +++++ >>>>>> 1 file changed, 5 insertions(+) >>>>>> >>>>>> diff --git a/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml b/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml >>>>>> index 8b393e26e025..65dc3053df75 100644 >>>>>> --- a/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml >>>>>> +++ b/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml >>>>>> @@ -133,6 +133,11 @@ properties: >>>>>> $ref: /schemas/types.yaml#/definitions/uint32 >>>>>> description: platform specific settings for DLL_CONFIG reg. >>>>>> >>>>>> + qcom,dll-hsr-list: >>>>>> + maxItems: 10 >>>>>> + $ref: /schemas/types.yaml#/definitions/uint32 >>>>> uint32 has only one item. Anyway, there is already DLL there, so don't >>>>> duplicate or explain why this is different. Explain also why this is not >>>>> deducible from the compatible. >>> >>> Timeline still amazes me. I will be grumpy on this thread. >>> >>>> I will change it to reflect array from uint32. >>>> There is change with artanis DLL hw addition where it need total of 5 entries >>>> (dll_config, dll_config_2, dll_config_3, dll_usr_ctl, ddr_config) >>>> for each HS400 and HS200 modes, hence the new addition in dt. And these values >>>> are not fixed and varies for every SoC, hence this needs to be passed through >>>> dt like it was passed earlier for qcom,dll-config & qcom,ddr-config. >>> >>> Eh, no. That's not a valid reason. It's still SoC deducible. Don't bring >>> your downstream practices here, but remove EVERYTHING from downstream >>> and start doing things like upstream is doing. >> QC SoCs have between 0 and 4 SDHCI instances, each one potentially requiring >> different tuning, let's keep this data in DT > > OK, this should be explained in commit msg. > > Best regards, > Krzysztof sure, I will update this into commit message. Thanks, Ram
On 6/26/2025 11:12 PM, Krzysztof Kozlowski wrote: > On 26/06/2025 16:16, Ram Prakash Gupta wrote: >> On 1/22/2025 3:56 PM, Krzysztof Kozlowski wrote: >>> On 22/01/2025 10:47, Sachin Gupta wrote: >>>> Document the 'dll-hsr-list' property for MMC device tree bindings. >>>> The 'dll-hsr-list' property defines the DLL configurations for HS400 >>>> and HS200 modes. >>>> >>>> Signed-off-by: Sachin Gupta <quic_sachgupt@quicinc.com> >>>> --- >>>> Documentation/devicetree/bindings/mmc/sdhci-msm.yaml | 5 +++++ >>>> 1 file changed, 5 insertions(+) >>>> >>>> diff --git a/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml b/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml >>>> index 8b393e26e025..65dc3053df75 100644 >>>> --- a/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml >>>> +++ b/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml >>>> @@ -133,6 +133,11 @@ properties: >>>> $ref: /schemas/types.yaml#/definitions/uint32 >>>> description: platform specific settings for DLL_CONFIG reg. >>>> >>>> + qcom,dll-hsr-list: >>>> + maxItems: 10 >>>> + $ref: /schemas/types.yaml#/definitions/uint32 >>> uint32 has only one item. Anyway, there is already DLL there, so don't >>> duplicate or explain why this is different. Explain also why this is not >>> deducible from the compatible. > > Timeline still amazes me. I will be grumpy on this thread. > >> I will change it to reflect array from uint32. >> There is change with artanis DLL hw addition where it need total of 5 entries >> (dll_config, dll_config_2, dll_config_3, dll_usr_ctl, ddr_config) >> for each HS400 and HS200 modes, hence the new addition in dt. And these values >> are not fixed and varies for every SoC, hence this needs to be passed through >> dt like it was passed earlier for qcom,dll-config & qcom,ddr-config. > > Eh, no. That's not a valid reason. It's still SoC deducible. Don't bring > your downstream practices here, but remove EVERYTHING from downstream > and start doing things like upstream is doing. > > Best regards, > Krzysztof Sorry I did not get it - you mean to say keep these values in driver file? how is it possible to tie these value with only one compatible which can vary with every soc or you are suggesting me to make code change in driver for every target having artanis dll hw. And sorry but considering upstream only this design was put in place, its not about downstream, since there are already dll_config and ddr_config which are passed through dt, its logical here to pass rest of the dll related parameters through dt only. Thanks, Ram
On 6/26/2025 7:46 PM, Ram Prakash Gupta wrote: > On 1/22/2025 3:56 PM, Krzysztof Kozlowski wrote: >> On 22/01/2025 10:47, Sachin Gupta wrote: >>> Document the 'dll-hsr-list' property for MMC device tree bindings. >>> The 'dll-hsr-list' property defines the DLL configurations for HS400 >>> and HS200 modes. >>> >>> Signed-off-by: Sachin Gupta <quic_sachgupt@quicinc.com> >>> --- >>> Documentation/devicetree/bindings/mmc/sdhci-msm.yaml | 5 +++++ >>> 1 file changed, 5 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml b/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml >>> index 8b393e26e025..65dc3053df75 100644 >>> --- a/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml >>> +++ b/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml >>> @@ -133,6 +133,11 @@ properties: >>> $ref: /schemas/types.yaml#/definitions/uint32 >>> description: platform specific settings for DLL_CONFIG reg. >>> >>> + qcom,dll-hsr-list: >>> + maxItems: 10 >>> + $ref: /schemas/types.yaml#/definitions/uint32 >> uint32 has only one item. Anyway, there is already DLL there, so don't >> duplicate or explain why this is different. Explain also why this is not >> deducible from the compatible. > I will change it to reflect array from uint32. > There is change with artanis DLL hw addition where it need total of 5 entries > (dll_config, dll_config_2, dll_config_3, dll_usr_ctl, ddr_config) > for each HS400 and HS200 modes, hence the new addition in dt. And these values > are not fixed and varies for every SoC, hence this needs to be passed through > dt like it was passed earlier for qcom,dll-config & qcom,ddr-config. > > And backward compatibility would be taken care by check for qcom,dll-hsr-list, > where new settings would apply for soc where qcom,dll-hsr-list is added into > dt. > >> Please provide here link to DTS user so we can validate how you use it. >> >> >> Best regards, >> Krzysztof sure, will provide with V4 patchset.
© 2016 - 2025 Red Hat, Inc.