Document the PCIe controller on IPQ5332 platform. IPQ5332 will
use IPQ9574 as the fall back compatible.
Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com>
---
v7: Moved ipq9574 related changes to a separate patch
Add 'global' interrupt
v6: Commit message update only. Add info regarding the moving of
ipq9574 from 5 "reg" definition to 5 or 6 reg definition.
v5: Re-arrange 5332 and 9574 compatibles to handle fallback usage in dts
v4: * v3 reused ipq9574 bindings for ipq5332. Instead add one for ipq5332
* DTS uses ipq9574 compatible as fallback. Hence move ipq9574 to be able
to use the 'reg' section for both ipq5332 and ipq9574. Else, dtbs_check
and dt_binding_check flag errors.
---
.../devicetree/bindings/pci/qcom,pcie.yaml | 13 +++++++++++--
1 file changed, 11 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
index 413c6b76c26c..ead97286fd41 100644
--- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
+++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
@@ -34,6 +34,10 @@ properties:
- items:
- const: qcom,pcie-msm8998
- const: qcom,pcie-msm8996
+ - items:
+ - enum:
+ - qcom,pcie-ipq5332
+ - const: qcom,pcie-ipq9574
reg:
minItems: 4
@@ -45,11 +49,11 @@ properties:
interrupts:
minItems: 1
- maxItems: 8
+ maxItems: 9
interrupt-names:
minItems: 1
- maxItems: 8
+ maxItems: 9
iommu-map:
minItems: 1
@@ -205,6 +209,7 @@ allOf:
compatible:
contains:
enum:
+ - qcom,pcie-ipq5332
- qcom,pcie-ipq9574
- qcom,pcie-sdx55
then:
@@ -407,6 +412,7 @@ allOf:
compatible:
contains:
enum:
+ - qcom,pcie-ipq5332
- qcom,pcie-ipq9574
then:
properties:
@@ -439,6 +445,7 @@ allOf:
interrupts:
minItems: 8
interrupt-names:
+ minItems: 8
items:
- const: msi0
- const: msi1
@@ -448,6 +455,7 @@ allOf:
- const: msi5
- const: msi6
- const: msi7
+ - const: global
- if:
properties:
@@ -555,6 +563,7 @@ allOf:
enum:
- qcom,pcie-apq8064
- qcom,pcie-ipq4019
+ - qcom,pcie-ipq5332
- qcom,pcie-ipq8064
- qcom,pcie-ipq8064v2
- qcom,pcie-ipq8074
--
2.34.1On Wed, Jan 22, 2025 at 12:04:09PM +0530, Varadarajan Narayanan wrote: > Document the PCIe controller on IPQ5332 platform. IPQ5332 will > use IPQ9574 as the fall back compatible. > > Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com> > --- > v7: Moved ipq9574 related changes to a separate patch > Add 'global' interrupt > > v6: Commit message update only. Add info regarding the moving of > ipq9574 from 5 "reg" definition to 5 or 6 reg definition. > > v5: Re-arrange 5332 and 9574 compatibles to handle fallback usage in dts > > v4: * v3 reused ipq9574 bindings for ipq5332. Instead add one for ipq5332 > * DTS uses ipq9574 compatible as fallback. Hence move ipq9574 to be able > to use the 'reg' section for both ipq5332 and ipq9574. Else, dtbs_check > and dt_binding_check flag errors. > --- > .../devicetree/bindings/pci/qcom,pcie.yaml | 13 +++++++++++-- > 1 file changed, 11 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > index 413c6b76c26c..ead97286fd41 100644 > --- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > @@ -34,6 +34,10 @@ properties: > - items: > - const: qcom,pcie-msm8998 > - const: qcom,pcie-msm8996 > + - items: > + - enum: > + - qcom,pcie-ipq5332 > + - const: qcom,pcie-ipq9574 Repeated many times on reviews to qcom: don't add to the end of the lists. In case of multiple items, these are ordered by fallback, so this goes next to other ipq entry... wait, that's already qcom,pcie-ipq9574, so why are you duplicating? On what tree are you working? Best regards, Krzysztof
On Thu, Jan 23, 2025 at 08:58:29AM +0100, Krzysztof Kozlowski wrote: > On Wed, Jan 22, 2025 at 12:04:09PM +0530, Varadarajan Narayanan wrote: > > Document the PCIe controller on IPQ5332 platform. IPQ5332 will > > use IPQ9574 as the fall back compatible. > > > > Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com> > > --- > > v7: Moved ipq9574 related changes to a separate patch > > Add 'global' interrupt > > > > v6: Commit message update only. Add info regarding the moving of > > ipq9574 from 5 "reg" definition to 5 or 6 reg definition. > > > > v5: Re-arrange 5332 and 9574 compatibles to handle fallback usage in dts > > > > v4: * v3 reused ipq9574 bindings for ipq5332. Instead add one for ipq5332 > > * DTS uses ipq9574 compatible as fallback. Hence move ipq9574 to be able > > to use the 'reg' section for both ipq5332 and ipq9574. Else, dtbs_check > > and dt_binding_check flag errors. > > --- > > .../devicetree/bindings/pci/qcom,pcie.yaml | 13 +++++++++++-- > > 1 file changed, 11 insertions(+), 2 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > > index 413c6b76c26c..ead97286fd41 100644 > > --- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > > +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > > @@ -34,6 +34,10 @@ properties: > > - items: > > - const: qcom,pcie-msm8998 > > - const: qcom,pcie-msm8996 > > + - items: > > + - enum: > > + - qcom,pcie-ipq5332 > > + - const: qcom,pcie-ipq9574 > > Repeated many times on reviews to qcom: don't add to the end of the > lists. In case of multiple items, these are ordered by fallback, so this > goes next to other ipq entry... wait, that's already qcom,pcie-ipq9574, > so why are you duplicating? > > On what tree are you working? Looks like ipq5424 changes got merged between the time I cloned linux-next, tested and posted the patch. Will fix this and post a new one. Thanks Varada
On Thu, Jan 23, 2025 at 01:35:36PM +0530, Varadarajan Narayanan wrote: > On Thu, Jan 23, 2025 at 08:58:29AM +0100, Krzysztof Kozlowski wrote: > > On Wed, Jan 22, 2025 at 12:04:09PM +0530, Varadarajan Narayanan wrote: > > > Document the PCIe controller on IPQ5332 platform. IPQ5332 will > > > use IPQ9574 as the fall back compatible. > > > > > > Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com> > > > --- > > > v7: Moved ipq9574 related changes to a separate patch > > > Add 'global' interrupt > > > > > > v6: Commit message update only. Add info regarding the moving of > > > ipq9574 from 5 "reg" definition to 5 or 6 reg definition. > > > > > > v5: Re-arrange 5332 and 9574 compatibles to handle fallback usage in dts > > > > > > v4: * v3 reused ipq9574 bindings for ipq5332. Instead add one for ipq5332 > > > * DTS uses ipq9574 compatible as fallback. Hence move ipq9574 to be able > > > to use the 'reg' section for both ipq5332 and ipq9574. Else, dtbs_check > > > and dt_binding_check flag errors. > > > --- > > > .../devicetree/bindings/pci/qcom,pcie.yaml | 13 +++++++++++-- > > > 1 file changed, 11 insertions(+), 2 deletions(-) > > > > > > diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > > > index 413c6b76c26c..ead97286fd41 100644 > > > --- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > > > +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > > > @@ -34,6 +34,10 @@ properties: > > > - items: > > > - const: qcom,pcie-msm8998 > > > - const: qcom,pcie-msm8996 > > > + - items: > > > + - enum: > > > + - qcom,pcie-ipq5332 > > > + - const: qcom,pcie-ipq9574 > > > > Repeated many times on reviews to qcom: don't add to the end of the > > lists. In case of multiple items, these are ordered by fallback, so this > > goes next to other ipq entry... wait, that's already qcom,pcie-ipq9574, > > so why are you duplicating? > > > > On what tree are you working? > > Looks like ipq5424 changes got merged between the time I cloned > linux-next, tested and posted the patch. Will fix this and post > a new one. Yeah, that would explain. Please grow the enum instead. Best regards, Krzysztof
© 2016 - 2025 Red Hat, Inc.