lib/tests/module/gen_test_kallsyms.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Use "#!/usr/bin/env bash" instead of "#!/bin/bash". This is necessary
for nix environments as they only provide /usr/bin/env at the standard
location.
Signed-off-by: Joel Granados <joel.granados@kernel.org>
---
I just saw this break my allyes test build. I had usually done it in
debian, but now that its on NixOs; this patch corrects the build error.
---
lib/tests/module/gen_test_kallsyms.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/tests/module/gen_test_kallsyms.sh b/lib/tests/module/gen_test_kallsyms.sh
index 561dcac0f359..31fe4ed63de8 100755
--- a/lib/tests/module/gen_test_kallsyms.sh
+++ b/lib/tests/module/gen_test_kallsyms.sh
@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
TARGET=$(basename $1)
DIR=lib/tests/module
---
base-commit: ffd294d346d185b70e28b1a28abe367bbfe53c04
change-id: 20250122-jag-nix-ify-1aa2061c4ad8
Best regards,
--
Joel Granados <joel.granados@kernel.org>
On Wed, Jan 22, 2025 at 11:33:49AM +0100, Joel Granados wrote: > Use "#!/usr/bin/env bash" instead of "#!/bin/bash". This is necessary > for nix environments as they only provide /usr/bin/env at the standard > location. > > Signed-off-by: Joel Granados <joel.granados@kernel.org> Acked-by: Luis Chamberlain <mcgrof@kernel.org> This can go through the modules tree. Luis > --- > I just saw this break my allyes test build. I had usually done it in > debian, but now that its on NixOs; this patch corrects the build error. > --- > lib/tests/module/gen_test_kallsyms.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/tests/module/gen_test_kallsyms.sh b/lib/tests/module/gen_test_kallsyms.sh > index 561dcac0f359..31fe4ed63de8 100755 > --- a/lib/tests/module/gen_test_kallsyms.sh > +++ b/lib/tests/module/gen_test_kallsyms.sh > @@ -1,4 +1,4 @@ > -#!/bin/bash > +#!/usr/bin/env bash > > TARGET=$(basename $1) > DIR=lib/tests/module > > --- > base-commit: ffd294d346d185b70e28b1a28abe367bbfe53c04 > change-id: 20250122-jag-nix-ify-1aa2061c4ad8 > > Best regards, > -- > Joel Granados <joel.granados@kernel.org> > >
On 1/28/25 21:37, Luis Chamberlain wrote: > On Wed, Jan 22, 2025 at 11:33:49AM +0100, Joel Granados wrote: >> Use "#!/usr/bin/env bash" instead of "#!/bin/bash". This is necessary >> for nix environments as they only provide /usr/bin/env at the standard >> location. >> >> Signed-off-by: Joel Granados <joel.granados@kernel.org> > > Acked-by: Luis Chamberlain <mcgrof@kernel.org> > > This can go through the modules tree. Queued on modules-fixes. -- Thanks, Petr
© 2016 - 2025 Red Hat, Inc.