[PATCH] docs: Fix backticks in README instructions

carlodelos90 posted 1 patch 1 year ago
README | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
[PATCH] docs: Fix backticks in README instructions
Posted by carlodelos90 1 year ago
The commands 'make pdfdocs' and make 'htmldocs' were formatted with backticks. which caused confusion in some contexts, like GitHub. However, using tripple backticks is not universally compatible.

This patch replaces backticks with normal quotes to ensure clarity and compatibility across all rendering contexts.

Signed-off-by: Carlo K <carlodelos90@gmail.com>
---
 README | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/README b/README
index fd903645e6de..c1d280c622e9 100644
--- a/README
+++ b/README
@@ -5,8 +5,8 @@ There are several guides for kernel developers and users. These guides can
 be rendered in a number of formats, like HTML and PDF. Please read
 Documentation/admin-guide/README.rst first.
 
-In order to build the documentation, use ``make htmldocs`` or
-``make pdfdocs``.  The formatted documentation can also be read online at:
+In order to build the documentation, use "make htmldocs" or
+"make pdfdocs".  The formatted documentation can also be read online at:
 
     https://www.kernel.org/doc/html/latest/
 
-- 
2.39.5 (Apple Git-154)
Re: [PATCH] docs: Fix backticks in README instructions
Posted by Jonathan Corbet 1 year ago
We're getting there.  I'm going to be extra-picky here to point out a
few things that are important for working with the kernel community,
though.

As Akira suggested, please use checkpatch on your patches.  Also, you
should always Cc people who have commented on previous versions.

carlodelos90 <carlodelos90@gmail.com> writes:

> The commands 'make pdfdocs' and make 'htmldocs' were formatted with backticks. which caused confusion in some contexts, like GitHub. However, using tripple backticks is not universally compatible.
>
> This patch replaces backticks with normal quotes to ensure clarity and compatibility across all rendering contexts.

Please adhere to the 80-column limit for changelog messages.

Some maintainers will get really annoyed at the "This patch" wording;
changelogs should describe changes in an imperative tense.

> Signed-off-by: Carlo K <carlodelos90@gmail.com>

It won't really matter for a non-copyrightable change like this, but we
do want to see a full name in the signoff.

> ---
>  README | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/README b/README
> index fd903645e6de..c1d280c622e9 100644
> --- a/README
> +++ b/README
> @@ -5,8 +5,8 @@ There are several guides for kernel developers and users. These guides can
>  be rendered in a number of formats, like HTML and PDF. Please read
>  Documentation/admin-guide/README.rst first.
>  
> -In order to build the documentation, use ``make htmldocs`` or
> -``make pdfdocs``.  The formatted documentation can also be read online at:
> +In order to build the documentation, use "make htmldocs" or
> +"make pdfdocs".  The formatted documentation can also be read online at:
>  
>      https://www.kernel.org/doc/html/latest/

The change itself is good.

Thanks,

jon
Re: [PATCH] docs: Fix backticks in README instructions
Posted by Akira Yokosawa 1 year ago
[+CC: Jon]
Hi,

Not a comment on the patch contents, just nitpicking.

carlodelos90 wrote:
> The commands 'make pdfdocs' and make 'htmldocs' were formatted with backticks. which caused confusion in some contexts, like GitHub. However, using tripple backticks is not universally compatible.
> 
> This patch replaces backticks with normal quotes to ensure clarity and compatibility across all rendering contexts.
> 
> Signed-off-by: Carlo K <carlodelos90@gmail.com>

I'd suggest you to run scripts/checkpatch.pl on your patch.
It is good in catching issues in patches especially from new contributors.

Besides that, you have failed to denote a patch version.

I'd say [PATCH v2] in the subject of this patch.  Next one will be v3.

As we are in the middle of the merge window, I'd suggest you to take
some time and skim through documents under Documentation/process/,
especially submitting-patches.rst and submit-checklist.rst among others,
before submitting a v3.

Questions are always welcome!

Thanks, Akira