soc: qcom: Do not expose internal servreg_location_entry_ei array

[PATCH] soc: qcom: Do not expose internal servreg_location_entry_ei array

Posted by Krzysztof Kozlowski 11 months ago

'struct qmi_elem_info servreg_location_entry_ei' is used only internally
in qcom_pdr_msg.c, so drop the extern declaration to make headers
smaller and code more obvious about intention.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 drivers/soc/qcom/pdr_internal.h | 1 -
 drivers/soc/qcom/qcom_pdr_msg.c | 3 +--
 2 files changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/soc/qcom/pdr_internal.h b/drivers/soc/qcom/pdr_internal.h
index 8d17f7fb79e7..039508c1bbf7 100644
--- a/drivers/soc/qcom/pdr_internal.h
+++ b/drivers/soc/qcom/pdr_internal.h
@@ -91,7 +91,6 @@ struct servreg_loc_pfr_resp {
 	struct qmi_response_type_v01 rsp;
 };
 
-extern const struct qmi_elem_info servreg_location_entry_ei[];
 extern const struct qmi_elem_info servreg_get_domain_list_req_ei[];
 extern const struct qmi_elem_info servreg_get_domain_list_resp_ei[];
 extern const struct qmi_elem_info servreg_register_listener_req_ei[];
diff --git a/drivers/soc/qcom/qcom_pdr_msg.c b/drivers/soc/qcom/qcom_pdr_msg.c
index bf3e4a47165e..ca98932140d8 100644
--- a/drivers/soc/qcom/qcom_pdr_msg.c
+++ b/drivers/soc/qcom/qcom_pdr_msg.c
@@ -8,7 +8,7 @@
 
 #include "pdr_internal.h"
 
-const struct qmi_elem_info servreg_location_entry_ei[] = {
+static const struct qmi_elem_info servreg_location_entry_ei[] = {
 	{
 		.data_type      = QMI_STRING,
 		.elem_len       = SERVREG_NAME_LENGTH + 1,
@@ -47,7 +47,6 @@ const struct qmi_elem_info servreg_location_entry_ei[] = {
 	},
 	{}
 };
-EXPORT_SYMBOL_GPL(servreg_location_entry_ei);
 
 const struct qmi_elem_info servreg_get_domain_list_req_ei[] = {
 	{
-- 
2.43.0

Re: [PATCH] soc: qcom: Do not expose internal servreg_location_entry_ei array

Posted by Bjorn Andersson 10 months, 1 week ago

On Tue, 21 Jan 2025 11:28:17 +0100, Krzysztof Kozlowski wrote:
> 'struct qmi_elem_info servreg_location_entry_ei' is used only internally
> in qcom_pdr_msg.c, so drop the extern declaration to make headers
> smaller and code more obvious about intention.
> 
> 

Applied, thanks!

[1/1] soc: qcom: Do not expose internal servreg_location_entry_ei array
      commit: 2e14c17a2e3d697bef6b5bf49b253d6e52f3d186

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>

Re: [PATCH] soc: qcom: Do not expose internal servreg_location_entry_ei array

Posted by Konrad Dybcio 10 months, 3 weeks ago

On 21.01.2025 11:28 AM, Krzysztof Kozlowski wrote:
> 'struct qmi_elem_info servreg_location_entry_ei' is used only internally
> in qcom_pdr_msg.c, so drop the extern declaration to make headers
> smaller and code more obvious about intention.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad